Patch Set 1: Code-Review-1
We can't reduce the detection window unless the timing concerns in e90c24c8 are
considered and/or the underlying issue is addressed. One possibility is
disabling 4/1 SPS support and/or defaulting to 4/4 SPS (which has more stable
timing), but those are much more
Patch Set 1:
> Btw, if I understand correctly what you're talking about - it's not
> "jitter", i.e. it doesn't change in time, there is an error which
> is static after PLL has been locked.
Correct. It's timing 'jitter' in the sense that it changes run-to-run, but the
timing offset static
Patch Set 1:
> > Tom, could you explain why did you set search window to -/+6
> > symbols? My experiments showed that at least `tail` should be set
> > to 3 in order for `max_toa` to actually represent maximum TOA.
> And
> > same for `head` - from my experiments I think it should be 3.
>
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/2765/1//COMMIT_MSG
Commit Message:
PS1, Line 7: W
> I this is still WIP, I am not sure it should be submitted to gerit? If it's
I thought it's better to discuss it here with the code/patch in front of us. I
can probably move the
Patch Set 1:
> Tom, could you explain why did you set search window to -/+6
> symbols? My experiments showed that at least `tail` should be set
> to 3 in order for `max_toa` to actually represent maximum TOA. And
> same for `head` - from my experiments I think it should be 3.
Previous
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/2765/1//COMMIT_MSG
Commit Message:
PS1, Line 7: W
I this is still WIP, I am not sure it should be submitted to gerit? If it's not
WIP, it should not say so.
Line 9: Otherwise we detect bursts with search window far beyond specified.
Patch Set 1:
Tom, could you explain why did you set search window to -/+6 symbols? My
experiments showed that at least `tail` should be set to 3 in order for
`max_toa` to actually represent maximum TOA. And same for `head` - from my
experiments I think it should be 3.
--
To view, visit
Review at https://gerrit.osmocom.org/2765
WIP:sigProcLib: Reduce burst detection window for NB.
Otherwise we detect bursts with search window far beyond specified.
Change-Id: If3cb40d2311504a13c03e1fbccad663ac201d9a4
---
M Transceiver52M/sigProcLib.cpp
1 file changed, 2 insertions(+), 2
