osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

2018-02-25 Thread lynxis lazus
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6911/1/contrib/jenkins.sh File contrib/jenkins.sh: Line 86: if [ -z "${INSIDE_CHROOT}" ]; then > I think this should always be executed, with no condition. Otherwise in the oh yes. you're right. I just looked at the warning (shellcheck).

osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

2018-02-25 Thread Pau Espin Pedrol
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/6911/1/contrib/jenkins.sh File contrib/jenkins.sh: Line 86: if [ -z "${INSIDE_CHROOT}" ]; then I think this should always be executed, with no condition. Otherwise in the case in which we call us recursively, the workspace

[PATCH] osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

2018-02-25 Thread lynxis lazus
Review at https://gerrit.osmocom.org/6911 jenkins.sh: enable the cleanup workspace after building Emptyness with a literal string will never be zero. Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull