libosmocore[master]: Add a README file for some background information about this...

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2094 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If034c6f551ff9bfaff0b8368fd0963f3147155b9 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmo-abis[master]: jenkins: add value_string termination check

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1947 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37c14c1a18207f64aa5e15ec0d2503bc834b2627 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master

osmo-pcu[master]: jenkins: add value_string termination check

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1958 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27217c9162efd800eebcb403eab770f4528d21ac Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

openbsc[master]: jenkins: add value_string termination check

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1946 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4183415cd1ead9d46ae3a556e94243325ef5a844 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

[PATCH] osmo-trx[master]: Add test program to verify convolution implementation

2017-03-16 Thread dexter
Review at https://gerrit.osmocom.org/2104 Add test program to verify convolution implementation Convolution is a complex process and we should be able to verify if computing results change when the implementation is touched. This commit adds a test program that executes some testcases. The

[PATCH] osmo-trx[master]: ssedetect: Add runtime CPU detection

2017-03-16 Thread dexter
Review at https://gerrit.osmocom.org/2100 ssedetect: Add runtime CPU detection The current implementation can select the SSE support level during compiletime only. This commit adds functionality to automatically detect and switch the SSE support level and automatically switch the

osmo-trx[master]: Add test program to verify convolution implementation

2017-03-16 Thread Harald Welte
Patch Set 1: it would be great if the tests would not only test the (fastest) one selected by default based on the CPU capabilies on the host running the test, but if we actaully executed all versions supported by the CPU, i.e. generic-C, SSE3 and SSE4.1 on modern systems. -- To view, visit

[PATCH] osmo-trx[master]: buildenv: Turn off native architecture builds

2017-03-16 Thread dexter
Review at https://gerrit.osmocom.org/2098 buildenv: Turn off native architecture builds The compiler option -march=native instructs the compiler to auto-optimize the code for the current build architecture. This is fine for building and using locally, but contraproductive when generating

osmo-trx[master]: cosmetic: remove code duplication

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2103 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8d8534a343e27cde79ddc85be4998ebd0cb6e5c Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

libosmocore[master]: core/conv: implement optimized Viterbi decoder

2017-03-16 Thread Max
Patch Set 4: That's a nitpicking of course, but maybe change the name to viterbi_common.c or viterbi_generic.c to avoid confusion with the generated files? -- To view, visit https://gerrit.osmocom.org/1337 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

libosmocore[master]: core/conv: implement optimized Viterbi decoder

2017-03-16 Thread tnt
Patch Set 5: @Harald: Ooops, I had completely missed the updated version, I'll check it out this weekend. -- To view, visit https://gerrit.osmocom.org/1337 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-hlr[master]: debug log: output ind slot, previous sqn, and sqn db update

2017-03-16 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2091 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86442ea45f6c1948b3d260f59d35bdca38fbd32 Gerrit-PatchSet: 3 Gerrit-Project: osmo-hlr Gerrit-Branch: master

[MERGED] openbsc[master]: Don't drop OML links for Get Attributes NACK

2017-03-16 Thread Max
Max has submitted this change and it was merged. Change subject: Don't drop OML links for Get Attributes NACK .. Don't drop OML links for Get Attributes NACK Previously any OML NACK message will result in BSC dropping OML link

[MERGED] osmo-hlr[master]: jenkins: add value_string termination check

2017-03-16 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins: add value_string termination check .. jenkins: add value_string termination check Change-Id: I8cf15d898ef274c505cda0a6b8ddcbf01ba190d9

[PATCH] osmo-tetra[master]: reformat README file as markdown

2017-03-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/2106 reformat README file as markdown Change-Id: I7b2602fa1614cafcfb6e6c4fad0d15ba183b0d1d --- R README.md 1 file changed, 31 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/06/2106/1 diff --git a/README

[PATCH] osmo-tetra[master]: README.md: Add general information about the project

2017-03-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/2107 README.md: Add general information about the project Change-Id: I3e187676a2c1ceb305f97e95d906659609135068 --- M README.md 1 file changed, 44 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/07/2107/1

osmo-sip-connector[master]: jenkins: add value_string termination check

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1957 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic247005aeeabdf349caf48657af0249da8c8d9ea Gerrit-PatchSet: 1 Gerrit-Project: osmo-sip-connector Gerrit-Branch:

libosmo-abis[master]: Add README file to libosmo-abis repository

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2095 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76ced414b22637792389fcf79ae6c7159502259b Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master

libosmo-netif[master]: stream: When destroying, make sure to kill reconnect timer

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2112 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6597130f472f1e2b8d9682002250ecd54675bb0 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: stream_client: Actually use/honor the reconect parameter

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2110 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I817e026404cbd9145cae2ce90bc57a1db1d2e12b Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: stream: don't crash in _close() when fd is not initialized

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2111 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aa04999ab01cb7971ee2dad45dfc31ab4142868 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master

[MERGED] osmo-hlr[master]: UMTS AKA: implement SQN increment according to SEQ and IND

2017-03-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: UMTS AKA: implement SQN increment according to SEQ and IND .. UMTS AKA: implement SQN increment according to SEQ and IND Add ind_bitlen column to auc_3g

osmo-pcu[master]: Add support for sending OML Alerts via BTS

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/2071/1/src/encoding.cpp File src/encoding.cpp: Line 380: pcu_tx_txt_ind(PCU_OML_ALERT, "PCU: length of IMM.ASS without " we are sending the message over the PCU socket, so it is clear that it originates from

[PATCH] libosmo-netif[master]: stream_client: Actually use/honor the reconect parameter

2017-03-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/2110 stream_client: Actually use/honor the reconect parameter The reconnect behavior was likely broken in commit de3f57a8293a5b39435d6f283da23e0172bad8bb If the user requests a re-connect, we should start it. Not only in case the connection drops later,

libosmocore[master]: logging: fail gracefully if log_info() was not called

2017-03-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2109 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3007860d2efe6ea9aec27e7d7439d44a7cd19c2 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] osmo-hlr[master]: debug log: output ind slot, previous sqn, and sqn db update

2017-03-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: debug log: output ind slot, previous sqn, and sqn db update .. debug log: output ind slot, previous sqn, and sqn db update Change-Id:

[MERGED] libosmocore[master]: auth_milenage: fix check against too large ind

2017-03-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: auth_milenage: fix check against too large ind .. auth_milenage: fix check against too large ind To ensure that the IND index appended to SEQ does not