Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2159
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3b71b3a06b34a6fd781bf197ecf9d5cc1711d13
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
(4 comments)
We should get the remaining EOL whitespace removals into this patch.
https://gerrit.osmocom.org/#/c/2151/1/Transceiver52M/sigProcLib.h
File Transceiver52M/sigProcLib.h:
PS1, Line 82:
Additional whitespace fix
PS1, Line 94:
Additional whitespace fix
PS1, Line
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2157
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c0ac2715aea1a90c9e6ebcd982522b80a547099
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2151
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7718cca45c245c9e91250ab2877f5436d4029698
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2151
to look at the new patch set (#2).
sigProcLib.h: Fix whitespaces. No non-whitespace changes.
The file seem to be using "2 spaces" indent, bt some lines are using
tabs which breaks
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1986
to look at the new patch set (#3).
select: Find the highest fd when filling the fd_sets
Instead of returning maxfd, which is the highest fd ever seen, take
the highest we have seen on
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2102
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic913aa13c23c348ae62e78c9dfd6ed8b0a62798c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
FYI: the latest version of autoconf-archive is 2017.03.21
--
To view, visit https://gerrit.osmocom.org/2134
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I846e190e92f1258cd412d1b2d79b539e204e04b3
Gerrit-PatchSet: 1
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2100
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba74f8a6e4e921ff31e4bd9f0c7c881fe547423a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2150
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d68cbdab8fb504d7f155029654a576d318a201e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Max has submitted this change and it was merged.
Change subject: Add support for PCU version report
..
Add support for PCU version report
Expand 3GPP TS 52.021 ยง9.4.43 Probable Cause with Osmocom-specific value
for PCU version
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2086
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e6cc86604947a173e8675ba4b41a3bda2d3296
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/1982
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0593d6530c097cca34125a0ae2dd1b019b4dd80d
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1966
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4de23daf79bb07ca0c0b818eefe350d18d27e4d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Holger Freyther has submitted this change and it was merged.
Change subject: mncc/sip: Attempt to parse the media from session in progress
..
mncc/sip: Attempt to parse the media from session in progress
Parse the media from
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2052
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2ac1215ae948558324627f76e28c72a23dc6a68
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sim-auth
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: OM2000: Send ALTCRQ for SuperChannel after receiving IS Enable
Req Ack
..
OM2000: Send ALTCRQ for SuperChannel after receiving IS Enable Req Ack
When
Harald Welte has submitted this change and it was merged.
Change subject: abis_om2k: protect MO FSMs by NULL check
..
abis_om2k: protect MO FSMs by NULL check
Also set MO FSMs to NULL after freeing them.
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: RBS2000 RSL: Support for sending RSL PAGING CMD for GPRS
..
RBS2000 RSL: Support for sending RSL PAGING CMD for GPRS
Change-Id:
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2160
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fd4abb42c153fcd26bcfe22a2554b5c2d02d810
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: libbsc: add rsl_ericsson_imm_assign_cmd() which reply with a
confirmation message
..
libbsc: add rsl_ericsson_imm_assign_cmd() which reply with a
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1875
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82844ec7a302bac30d6daee9ebca2188fd48ca46
Gerrit-PatchSet: 9
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 2:
> actualyl, no. Files in "include/osmocom/" should only be files that
> are installed into the system. "tests.h" sounds like something
> only needed during unit tests, and it does not belong into a
> directory containing system-wide installed header files? Am I
> missing
Holger Freyther has submitted this change and it was merged.
Change subject: debian: Add -dbg packages for the osmo-pcap-client and
osmo-pcap-server
..
debian: Add -dbg packages for the osmo-pcap-client and osmo-pcap-server
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2000
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d6c8e491be459151c1531b86f28bb1dc2ee8bb4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2029
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b1e1f4ca045bd63536476702a5812f27d9b36d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sip-connector
Gerrit-Branch:
Holger Freyther has submitted this change and it was merged.
Change subject: mncc: Enable in-band signalling for early media
..
mncc: Enable in-band signalling for early media
Besides sending the alerting request we should
Holger Freyther has submitted this change and it was merged.
Change subject: sip: Actually honor the remote port of the pbx
..
sip: Actually honor the remote port of the pbx
So far the remote_port has never been used.
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/1986
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6d7271273ec08bb511c21b936891bc508843e4
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8719c392f57e0dbed0c0c792d1381592dcd662c1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sip-connector
Gerrit-Branch:
Holger Freyther has submitted this change and it was merged.
Change subject: debian: Make a new release with the new feature
..
debian: Make a new release with the new feature
Change-Id:
Holger Freyther has submitted this change and it was merged.
Change subject: testpbx: Enable GSM and AMR as codecs to actually be relevant
..
testpbx: Enable GSM and AMR as codecs to actually be relevant
Without these codecs
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2028
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c778b1f0e7484a755716133f91767af8b1102c0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch:
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1874
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf770fae89f7aedf6eba9a119db9b8acc7f938df
Gerrit-PatchSet: 4
Gerrit-Project: osmo-sip-connector
Gerrit-Branch:
Holger Freyther has submitted this change and it was merged.
Change subject: dtmf: Forward DTMF from MNCC to SIP
..
dtmf: Forward DTMF from MNCC to SIP
We are not using the RTP telephony-event here but the older dtmf
relay. We
Patch Set 1: Code-Review+1
> could you
> take a brief look and decide which way to go with the 'attribute'
> style -- are they no longer needed now, or should we rewrite this
> patch to use those instead?
this is exactly what has happened. The implementation first used those
attributes and
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2083
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57459c0610f2c7b36d599b13087c8deef8bdd9e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Holger Freyther has submitted this change and it was merged.
Change subject: dtmf: Start handling the DTMF MNCC messages and respond
..
dtmf: Start handling the DTMF MNCC messages and respond
Simply respond to the dtmf
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1990
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd49b4aa6b01b118fe67e39dddef50b2946159c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch:
Holger Freyther has submitted this change and it was merged.
Change subject: testpbx: Add another number that will just play a ringback
..
testpbx: Add another number that will just play a ringback
This will enable early media
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2160
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fd4abb42c153fcd26bcfe22a2554b5c2d02d810
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
> AX_EXT is macro from autoconf-archive package - I think it's avery
> bad idea to supply our own modified copy: this means we'll have to
> track all upstream fixes manually. I think we should either move
> this code directly to configure.ac or add our own macro wrapping
>
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2040
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88560291b5a3a3d7a0bac4d3c089b45f1f6b297f
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2157
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c0ac2715aea1a90c9e6ebcd982522b80a547099
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
I think rather than the printing of the version via the log, it should also be
stored soemwhere in the 'gsm_bts_trx' associated with the PCU for this TRX, so
the user can show it in 'show trx'.
The same should be done with OsmoBTS version. At any time, the sysadmin should
be
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2153
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic033371a387353eb12b1827a0eb16c00c07da88a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2156
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f3f4267b4137a0bc031f27e0f896fba9b9f3433
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2155
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fe3aae53fb2fa5bb7637e976de6059eabe08202
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2155
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fe3aae53fb2fa5bb7637e976de6059eabe08202
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2147
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a5ae6e87d4c69945053fdefec185d0fb1a26399
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2156/1/CommonLibs/Vector.h
File CommonLibs/Vector.h:
PS1, Line 231: const
This method modifies protected member data block and I do not believe should
declared const.
Yes, the class compiles and is strictly valid because the data,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2154
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic45f71b634e48808356d68925bb9f5783e0bf0d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2153
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic033371a387353eb12b1827a0eb16c00c07da88a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2162
vty: reduce code duplication
Use libosmocore's osmo_str2lower() instead of local equivalent.
Change-Id: I7faced2eaf0f6f87f06081235eea9d4c3ba71a7e
---
M src/common/vty.c
1 file changed, 6 insertions(+), 32 deletions(-)
git pull
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/2161/1//COMMIT_MSG
Commit Message:
Line 7: gsm_bts: add version details
'and variant'
Line 12: hw vendor of OsmoBTS
could you explain to the uninformed reader why this is useful and who will use
it? thx!
Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2134
to look at the new patch set (#3).
buildenv: Split up SSE3 and SSE4.1 code
Currently we find SSE3 and SSE4.1 code mixed togehter along with
generic
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2098
to look at the new patch set (#3).
buildenv: Turn off native architecture builds
The compiler option -march=native instructs the compiler to auto-optimize
the code for
57 matches
Mail list logo
