Review at https://gerrit.osmocom.org/2175
fix writing of ICCID for sysmo-usim-sjs1
The programming procedure for sysmo-usim-sjs1 lacks
writing the ICCID. This commit adds the missing call
to update_binary()
Change-Id: Ief85aa07c562d8d7b2a6dec302d2f485d0b1e577
---
M pySim/cards.py
1 file
Review at https://gerrit.osmocom.org/2174
Fix select control parameter
sysmo-usim-sjs1 requires P2 to be set to 0x0C (request FCI) when
using the USIM application commands. The FCI is not used by pysim
anyway and might even cause problems with other cards.
This commit adds a pair of get/set
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2178/2/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:
Line 64:scl_encoded = gsm0808_enc_speech_codec_list(scl);
why not simply pass the msgb into the gsm0808_enc_speech_codec_list() function,
so that function will msgb_put()
Review at https://gerrit.osmocom.org/2178
gsm0808: Add AoIP specific elements to gsm0808_create_... functions
the classic A implementation in libosmocore lacks support for AoIP
message elements. This patch adds support for AoIP by adding a set
of new gsm0808_create_..., which support the
Review at https://gerrit.osmocom.org/2176
gsm0808: Add utils for AoIP Transport Layer Address
The planned support for true A over IP requires the encoding and
decoding of a so called "AoIP Transport Layer Address" element.
This commt adds parsing functionality and tests for the element
Review at https://gerrit.osmocom.org/2177
gsm0808: Add utils for Speech Codec List and Speech Codec
The planned support for true A over IP requires the encoding and
decoding of a so called "Speech Codec Element" element.
This commt adds parsing functionality and tests for the element
Review at https://gerrit.osmocom.org/2184
gsm0808: Add create functions for BSS_MAP_MSG_ASSIGMENT_RQST
gsm0808.h/c lacks functionality to generate BSS_MAP_MSG_ASSIGMENT_RQST messages.
These messages are required if the code is used in an MSC implementation.
This commit adds a
Review at https://gerrit.osmocom.org/2182
gsm0808: Add create functions for CIPHER MODE COMMAND
gsm0808.h/c lacks functionality to generate CIPHER MODE COMMAND messages. These
messages are required if the code is used in an MSC implementation.
This commit adds a gsm0808_create_cipher()
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2177/2/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 151: struct msgb *gsm0808_enc_speech_codec(struct gsm0808_speech_codec *sc)
I think I don't really understand the idea behind those functions. When we
encode an entire
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2180/2/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 374: msgb_alloc(ELEMENT_MSGB_MAXLEN, "Encryption Information
Element");
codingstyle wise we rather break the line before the "Encryption..." string
than
Review at https://gerrit.osmocom.org/2181
gsm0808: Add utils for Cell Identifier List
The planned support for true A over IP requires the encoding of
the a Cell Identifier List element (see also BSS_MAP_MSG_PAGING).
This commt adds encoding/decoding functionality and tests for
the element
Review at https://gerrit.osmocom.org/2183
gsm0808: Add create functions for BSS_MAP_MSG_PAGING
gsm0808.h/c lacks functionality to generate BSS_MAP_MSG_PAGING messages. These
messages are required if the code is used in an MSC implementation.
This commit adds a gsm0808_create_paging()
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2176
to look at the new patch set (#2).
gsm0808: Add utils for AoIP Transport Layer Address
The planned support for true A over IP requires the encoding and
decoding of a so called "AoIP
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2176/2/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 72: struct sockaddr_storage *gsm0808_dec_aoip_trasp_addr(const void *ctx,
in genera we try to avoid dynamic allcoations whenever it is not needed, So I
guess a more
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2181/2/include/osmocom/gsm/protocol/gsm_08_08.h
File include/osmocom/gsm/protocol/gsm_08_08.h:
Line 457: struct gsm0808_cell_id_list {
also here, I would generally try to avoid resorting to linked lists and dynamic
allocations. The
Review at https://gerrit.osmocom.org/2185
config: Remove OpenBTS style sqlite configuration
OpenBTS relies on reading in configuration values from the OpenBTS.config
sqlite3 database. This configuration method is not maintained and not
recommended for Osmocom or OpenBTS use. Command line setup
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2186
to look at the new patch set (#2).
radioInterface: Remove UmTRX 'diversity' option
The 'diversity' option was an experimental 2 antenna receiver
implementation for UmTRX. The
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2185
to look at the new patch set (#2).
config: Remove OpenBTS style sqlite configuration
OpenBTS relies on reading in configuration values from the OpenBTS.config
sqlite3 database. This
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2188
to look at the new patch set (#2).
Transceiver: Remove unsigned negative compares
Change-Id: I49f30699786c52736ef334dae61f7bbd65d878d5
Fixes: Coverity CID 149353, 149356
---
M
Review at https://gerrit.osmocom.org/2187
Resampler: Fix non-array delete for filter taps
Change-Id: I59cdb01809da5940c74aaae9d17f413aefbf04b2
Fixes: Coverity CID 149349
---
M Transceiver52M/Resampler.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
20 matches
Mail list logo
