Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6295
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8af50a8847a5b438cf2ef660399d4c8bbac86a71
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1:
(1 comment)
This one is fixed, I'll send update regarding other comments later on.
https://gerrit.osmocom.org/#/c/6296/1/tests/msc_vlr/msc_vlr_test_rest.c
File tests/msc_vlr/msc_vlr_test_rest.c:
Line 26: void test_early_stage(const char *imsi)
> This doesn't seem to belong here
Review at https://gerrit.osmocom.org/6308
Fix whitespace issues
We don't usually put space before in-place increment or decrement. Let's
make code look similar to other Osmocom projects.
Change-Id: I5962431ad16c97e412939dc1b8949f6361a5c26e
---
M src/libcommon/oap_client.c
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6297
to look at the new patch set (#3).
Expand VLR tests
Print the IMSI used for each test. This enables expansion to tests with
several IMSIs in follow-up patches.
Change-Id:
VLR tests: remove weird code
Having while(0) as a body for for() cycle generate too much WTF while
looking at the code while not serving any obvious purpose. Let's just
drop it to avoid confusing developers.
Change-Id: I1f571ec319ff3231fd9acd4066e470476c3b1f78
Related: OS#2864
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6296
to look at the new patch set (#3).
Fix VLR test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes code
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6304
to look at the new patch set (#3).
VLR tests: don't fail via assert
Don't fail tests using thwart_rx_non_initial_requests() via
OSMO_ASSERT. Instead log extended error which will fail
Review at https://gerrit.osmocom.org/6291
jobs: add Coverity Upload Job
Change-Id: I852b42a698a4568b51e993bb5e86efeed6afdb32
---
A jobs/coverity.yml
1 file changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/6291/1
diff --git
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6291
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I852b42a698a4568b51e993bb5e86efeed6afdb32
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 3: Code-Review-1
(3 comments)
I'd be in favor of keeping the macro, but adding another parameter to it.
https://gerrit.osmocom.org/#/c/6296/1/tests/msc_vlr/msc_vlr_test_rest.c
File tests/msc_vlr/msc_vlr_test_rest.c:
Line 26: void test_early_stage(const char *imsi)
This doesn't seem
Review at https://gerrit.osmocom.org/6306
abis_rsl: do not allow SACCH in MF mode on SAPI=0
osmo-msc does currently not check if an MS attemts to establish an
SACCH link on SAPI=0. This combination is not permitted and should
be dropped.
- Make sure that establish indication for SAPI=0 and
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6306
to look at the new patch set (#2).
abis_rsl: do not allow SACCH in MF mode on SAPI=0
osmo-msc does currently not check if an MS attemts to establish an
SACCH link on SAPI=0. This
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6303
to look at the new patch set (#2).
abis_rsl: permit first EstablishInd only on SAPI=0
When the first EstablishInd (DCCH) is made by the MS, then it must by
definition happen on SAPI=0.
Hello daniel, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6295
to look at the new patch set (#2).
Constify msc_subscr_conn_is_accepted() parameter
Related: OS#2864
Change-Id: I8af50a8847a5b438cf2ef660399d4c8bbac86a71
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6296
to look at the new patch set (#2).
Fix VLR test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes code
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6294
to look at the new patch set (#2).
VLR tests: mark static test functions as such
Related: OS#2864
Change-Id: I5eac4c24257fd38068ba629d3c21848181703220
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6304
to look at the new patch set (#2).
VLR tests: don't fail via assert
Don't fail tests using thwart_rx_non_initial_requests() via
OSMO_ASSERT. Instead log extended error which will fail
Review at https://gerrit.osmocom.org/6305
VLR tests: remove weird code
Having while(0) as a body for for() cycle generate too much WTF while
looking at the code while not serving any obvious purpose. Let's just
drop it to avoid confusing developers.
Change-Id:
Review at https://gerrit.osmocom.org/6307
VLR tests: always print test parameters
For each test print:
* the test number
* IMSI
Unfortunately tests are organized in such a way that we don't know the
number of particular test in advance. Nevertheless, it make sense to
always print it
Hello daniel, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6296
to look at the new patch set (#4).
Fix VLR test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes
Review at https://gerrit.osmocom.org/6285
MSC: ignore symlinks and build byproducts
Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91
---
A msc/.gitignore
1 file changed, 214 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/85/6285/1
Patch Set 1:
gitignore claims to support negation of previously-excluded files, so something
like
*.cc
*.hh
!MNCC_EncDec.cc
should work. This would allow us to list those few .cc files that are not
generated, rather than listing each and every cc or hh file that is generated.
--
To view,
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6285
to look at the new patch set (#2).
MSC: ignore symlinks and build byproducts
Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91
---
A msc/.gitignore
1 file changed, 69 insertions(+),
Review at https://gerrit.osmocom.org/6286
Add macros for all ACC bit flags in the rach control IE.
Add macros which document the purpose of each bit in the rach_control.t2
and rach_control.t3 octets. These macros might also be useful for later
work on BTS cell ramping.
This change keeps the
Patch Set 2:
I think it was superseded by other merged patches. Pau?
--
To view, visit https://gerrit.osmocom.org/2225
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf
Gerrit-PatchSet: 2
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6286/1/include/osmocom/gsm/protocol/gsm_04_08.h
File include/osmocom/gsm/protocol/gsm_04_08.h:
Line 464: #define GSM48_RACH_CTRL_ACC15_BARRED 0x80
That's rather odd location for defines. Can we place it outside of struct
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6298
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I903f6bf14a15abc6cae1d527195414c5f081c2df
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6299
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02d1f2ac717fee278e3903d325942697637a5d28
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6293
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe207a83c477c918a865a8a34cad7ca5d45c7eac
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6292
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d5e0e3d7f92fc51fa438b92f00c79f63945e74f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6300
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c28b206625cb081a98a722b8c793ce02af74441
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: abis_rsl: do not allow SACCH in MF mode on SAPI=0
..
abis_rsl: do not allow SACCH in MF mode on SAPI=0
osmo-msc does currently not check if an MS
Harald Welte has submitted this change and it was merged.
Change subject: abis_rsl: permit first EstablishInd only on SAPI=0
..
abis_rsl: permit first EstablishInd only on SAPI=0
When the first EstablishInd (DCCH) is made by
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6306
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12962072c0ea689d2b9b5c2899ffb59be9310dcb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6308
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5962431ad16c97e412939dc1b8949f6361a5c26e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Fix whitespace issues
..
Fix whitespace issues
We don't usually put space before in-place increment or decrement. Let's
make code look similar to other
Harald Welte has submitted this change and it was merged.
Change subject: start-testsuite.sh: Pass a third parameter to ttcn3_start
..
start-testsuite.sh: Pass a third parameter to ttcn3_start
The name of the parameters is a
Harald Welte has submitted this change and it was merged.
Change subject: MSC_Tests: Make imsi suffix for f_start_handler unique per test
..
MSC_Tests: Make imsi suffix for f_start_handler unique per test
Change-Id:
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/6301/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:
Line 1596: testcase TC_mo_dtmf_duplicate() runs on MTC_CT {
this empty test case is probably an accident?
Line 1617: execute( TC_lu_imsi_noauth_notmsi() );
list new test case in
Harald Welte has submitted this change and it was merged.
Change subject: deps: Ensure that branches are updated on make update as well
..
deps: Ensure that branches are updated on make update as well
Don't just force-checkout
Harald Welte has submitted this change and it was merged.
Change subject: L3_Templates: Use tid parameter in ts_ML3_MO_CC template
..
L3_Templates: Use tid parameter in ts_ML3_MO_CC template
Change-Id:
Patch Set 1:
Looks good. The DSL is quite nice!
--
To view, visit https://gerrit.osmocom.org/6291
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I852b42a698a4568b51e993bb5e86efeed6afdb32
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6303
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf4fca0bd42dfe5bc63e8b08754ebbe0a5e252c3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6302
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6914067ec8daa8903f0ef0c877f178cfd61659
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Review at https://gerrit.osmocom.org/6292
deps: Ensure that master is updated on checkout
Change-Id: I7d5e0e3d7f92fc51fa438b92f00c79f63945e74f
---
M deps/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/92/6292/1
Review at https://gerrit.osmocom.org/6293
start-testsuite.sh: Allow a third parameter
Change-Id: Ibe207a83c477c918a865a8a34cad7ca5d45c7eac
---
M start-testsuite.sh
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Review at https://gerrit.osmocom.org/6303
abis_rsl: permit first EstablishInd only on SAPI=0
When the first EstablishInd (DCCH) is made by the MS, then it must by
definition happen on SAPI=0. The MS may establish multiple connection
on other SAPIs afterwards. At the moment osmo-bsc does not
Review at https://gerrit.osmocom.org/6296
Fix MSC test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes code harder to read
and maintain. Fix this by converting it to function.
Also don't use assert to fail but
Review at https://gerrit.osmocom.org/6297
Expand MSC tests
Print the IMSI used for each test. This enables expansion to tests with
several IMSIs in follow-up patches.
Change-Id: I7958608e5136351f7b7c0c57fe79791d989ce9c3
Related: OS#2864
---
M tests/msc_vlr/msc_vlr_test_authen_reuse.ok
M
Review at https://gerrit.osmocom.org/6295
Constify msc_subscr_conn_is_accepted() parameter
Related: OS#2864
Change-Id: I8af50a8847a5b438cf2ef660399d4c8bbac86a71
---
M include/osmocom/msc/osmo_msc.h
M src/libmsc/subscr_conn.c
2 files changed, 2 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6294
Mark static test functions as such
Change-Id: I5eac4c24257fd38068ba629d3c21848181703220
---
M tests/msc_vlr/msc_vlr_tests.c
M tests/msc_vlr/msc_vlr_tests.h
2 files changed, 7 insertions(+), 14 deletions(-)
git pull
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6303/1/src/libbsc/abis_rsl.c
File src/libbsc/abis_rsl.c:
Line 2189: rllh->link_id & 0x7);
Don't we have function for that? If not that we probably should.
--
To view, visit https://gerrit.osmocom.org/6303
Review at https://gerrit.osmocom.org/6304
MSC tests: don't fail via assert
Don't fail tests using thwart_rx_non_initial_requests() via
OSMO_ASSERT. Instead log extended error which will fail the test
eventually but allows to gather additional info helpful for debugging.
Change-Id:
Patch Set 1:
The job ran successfully without uploading
https://jenkins.osmocom.org/jenkins/job/osmocom-coverity/
--
To view, visit https://gerrit.osmocom.org/6291
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/6298
MNCC_Emulation: Initialize connection table
Change-Id: I903f6bf14a15abc6cae1d527195414c5f081c2df
---
M library/MNCC_Emulation.ttcn
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Review at https://gerrit.osmocom.org/6300
L3_Templates: Use tid parameter in ts_ML3_MO_CC template
Change-Id: I6c28b206625cb081a98a722b8c793ce02af74441
---
M library/L3_Templates.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Review at https://gerrit.osmocom.org/6299
MSC_Tests: Make imsi suffix for f_start_handler unique per test
Change-Id: I02d1f2ac717fee278e3903d325942697637a5d28
---
M msc/MSC_Tests.ttcn
1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6293
to look at the new patch set (#2).
start-testsuite.sh: Pass a third parameter to ttcn3_start
The name of the parameters is a little misleading, since the second
parameter could just be
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6292
to look at the new patch set (#2).
deps: Ensure that branches are updated on make update as well
Don't just force-checkout the local master branch again, but reset to
origin/master
Review at https://gerrit.osmocom.org/6302
BSSMAP_Emulation: Parameter to skip seq no patching
This is needed to check that duplicated messages will actually be thrown
away by the MSC.
Change-Id: I0a6914067ec8daa8903f0ef0c877f178cfd61659
---
M library/BSSMAP_Emulation.ttcn
M
Review at https://gerrit.osmocom.org/6301
MSC_Tests: Add CC sequence no. test with DTMF
Change-Id: I9674343acc18187b9e016bd8e0be470d5424046f
---
M library/L3_Templates.ttcn
M msc/BSC_ConnectionHandler.ttcn
M msc/MSC_Tests.ttcn
3 files changed, 106 insertions(+), 0 deletions(-)
git pull
Harald Welte has submitted this change and it was merged.
Change subject: mgcp: fix use-after-free and add callback for endpoint cleanup
..
mgcp: fix use-after-free and add callback for endpoint cleanup
Since we will support
Harald Welte has submitted this change and it was merged.
Change subject: src/Makefile.am: fix osmo-gapk LDADD dependency
..
src/Makefile.am: fix osmo-gapk LDADD dependency
This change fixes parallel building problem, when
Harald Welte has submitted this change and it was merged.
Change subject: protocol: prohibit wildcarded requests for MDCX and DLCX
..
protocol: prohibit wildcarded requests for MDCX and DLCX
When a wildcarded request is made
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6260
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia77d44a6a86083e62338e5845b553e5cf13ebd10
Gerrit-PatchSet: 4
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6253
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fdd1731bd372bbb42fe57981e757386e8ede0f0
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6050/1/src/libmsc/vty_interface_layer3.c
File src/libmsc/vty_interface_layer3.c:
Line 120: default:
> We have no state in the gsm_trans struct, so what should I print here?
Ok, got it.
Anyway, it would be great to have an
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12234d37c66b83b8abd60f7511fa1d7837db1856
Gerrit-PatchSet: 7
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: vty: don't print "Bound IP / Port" if it isn't bound [yet]
..
vty: don't print "Bound IP / Port" if it isn't bound [yet]
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6284
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c931bff1f1723aa82bead9dfe548e4cc5b685e0
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6287
Cosmetic fixes for power ramping code.
Reduce a logic expression to less lines of code:
'if (foo) return 1; else return 0;' is equivalent to just 'return (foo);'
Fix typos in 2 comments.
Change-Id: I214bcc8b78446bfea450fe445fa9391898638905
---
M
Patch Set 1:
> I'd prefer to keep some log file by default - /tmp/osmocom.log for
> example. Or, at the very least, this should be explicitly described
> in readme as well as in the help for corresponding command-line
> option.
>From my experience, in most use cases the log file is
not
Patch Set 2:
(1 comment)
I am not sure if I can give a proper feedback here.
Probably, @tnt has more experience and may give more
detailed response.
https://gerrit.osmocom.org/#/c/5657/2/debian/control
File debian/control:
Line 18:python3
The commit message actually says 'Use
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6287
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I214bcc8b78446bfea450fe445fa9391898638905
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6288
Move IMSI into test parameters
This makes test routines more flexible and allows to easier re-use them
for tests with different IMSIs.
Change-Id: I74d46fdb7e87dc04c6b82a0b6f3ce6bef60bde58
Related: OS#2864
---
M tests/msc_vlr/msc_vlr_test_gsm_authen.c
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6286/1/include/osmocom/gsm/protocol/gsm_04_08.h
File include/osmocom/gsm/protocol/gsm_04_08.h:
Line 464: #define GSM48_RACH_CTRL_ACC15_BARRED 0x80
> That's rather odd location for defines. Can we place it outside of struct d
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/6238/2//COMMIT_MSG
Commit Message:
Line 7: Add support to set Rx/TxAntenna
I would prefer to see at least minimalistic commit
description here, i.e. what is RX/TX port? and any
advantages of using this port for the project
Review at https://gerrit.osmocom.org/6289
BSSMAP_Emulation: Send proper L3 N(SD) seuence numbers in MO
We have to make sure all mobile originated L3 messages carry
proper sequence numbers
Change-Id: Id8638673ad1a133f46893b2140970ec072022b3a
---
M library/BSSMAP_Emulation.ttcn
1 file changed,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6289
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8638673ad1a133f46893b2140970ec072022b3a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: BSSMAP_Emulation: Send proper L3 N(SD) seuence numbers in MO
..
BSSMAP_Emulation: Send proper L3 N(SD) seuence numbers in MO
We have to make sure all
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6287/1/src/common/tx_power.c
File src/common/tx_power.c:
Line 153: return (tpp->p_total_tgt_mdBm > tpp->p_total_cur_mdBm);
sorry, I really prefer the more verbose version, I think it is what we do in
Osmocom in other places, too.
Patch Set 1: Code-Review-1
I agree with max that this is not our usual coding style.
As the definitions are rather regular, I would prefer a macro like
GSM48_RACH_CTRL_ACC(N) or a related inline function.
also, we can remove the RACH_CTRL part from it, as access control classes are a
more
Review at https://gerrit.osmocom.org/6290
jobs/README.adoc: explain the usage of API Tokens instead of passwords
Change-Id: Ie96288913aae2fe97fa11266ffa9ed098044ccfd
---
M jobs/README.adoc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci
Harald Welte has submitted this change and it was merged.
Change subject: jobs/README.adoc: explain the usage of API Tokens instead of
passwords
..
jobs/README.adoc: explain the usage of API Tokens instead of passwords
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/6290
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie96288913aae2fe97fa11266ffa9ed098044ccfd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
85 matches
Mail list logo
