Review at https://gerrit.osmocom.org/6406
Add a test for OS#2714, "close RSL connections from unknown Unit ID"
Change-Id: I6a947d7411a016e4d7650031396cae3575756453
---
M bsc/BSC_Tests.ttcn
1 file changed, 42 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6407
SS7: return error on stream opening error
Previously we've just logged error but continued as is.
Let's treat it as a error to let upper layers decide on it.
Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9
---
M src/osmo_ss7.c
1 file changed, 1
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6377
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6bacadcf74d3aa25db1e1f41644f64aa19cf92
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Review at https://gerrit.osmocom.org/6405
emu: use libosmocore definitions
Change-Id: I4eade528faeb3841549ad7a6c78e8c1357909614
---
M tests/emu/openbsc_clone.h
1 file changed, 1 insertion(+), 29 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/6405/1
diff
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6405
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4eade528faeb3841549ad7a6c78e8c1357909614
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: emu: use libosmocore definitions
..
emu: use libosmocore definitions
Change-Id: I4eade528faeb3841549ad7a6c78e8c1357909614
---
M
Patch Set 1:
N. B: this is RFC - I'm not sure if skipping the error was intentional in here
so I'd appreciate feedback on it. If it is than we should at least add comment
clarifying why this is necessary.
--
To view, visit https://gerrit.osmocom.org/6407
To unsubscribe, visit
Patch Set 1:
Yeah, removed that. I also added the test to control so it is executed
automatically
--
To view, visit https://gerrit.osmocom.org/6301
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review-1
(1 comment)
You should either remove the remaining m4 file or add it as !pattern to
gitignore.
https://gerrit.osmocom.org/#/c/6389/1/.gitignore
File .gitignore:
Line 24: m4/lt~obsolete.m4
> Agreed.
That'd be wrong:
git ls-files m4
m4/ax_check_compile_flag.m4
--
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6301
to look at the new patch set (#2).
MSC_Tests: Add CC sequence no. test with DTMF
Change-Id: I9674343acc18187b9e016bd8e0be470d5424046f
---
M library/L3_Templates.ttcn
M
Patch Set 1:
> (1 comment)
>
> You should either remove the remaining m4 file or add it as
> !pattern to gitignore.
Max is right here. This was I would follow the way of libosmocore:
m4/*.m4
!m4/ax_*.m4
--
To view, visit https://gerrit.osmocom.org/6389
To unsubscribe, visit
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: log: Use sys._getframe() to avoid stat(2) calls
..
log: Use sys._getframe() to avoid stat(2) calls
The Osmo MS driver is launching many many
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/6377/1/src/osmo_gsm_tester/log.py
File src/osmo_gsm_tester/log.py:
Line 278: # Poke into internal to avoid hitting the linecache which will
make one or
> According to [1], _getframe() can have a depth parameter, which if I unders
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6377
to look at the new patch set (#2).
log: Use sys._getframe() to avoid stat(2) calls
The Osmo MS driver is launching many many processes and I would
like to use the
Patch Set 2:
(6 comments)
https://gerrit.osmocom.org/#/c/5753/2/src/common/msg_utils.c
File src/common/msg_utils.c:
Line 484: if (lchan->tch_mode != GSM48_CMODE_SPEECH_AMR) {
Moreover, I would recommend to use a switch here:
switch (lchan->tch_mode) ...
Line 487: else {
Review at https://gerrit.osmocom.org/6409
modem: deactivate_context: Fix dbg message
Change-Id: I9aea339fb08c20e1b66a0d24c76d855bf665a4cd
---
M src/osmo_gsm_tester/modem.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Review at https://gerrit.osmocom.org/6408
IPA: log remote address
Wrap IPA logging to always print peer's address to simplify
troubleshooting.
Change-Id: I19ebaea45812aad6b3d3480cac0f1f833daf428d
---
M src/input/ipa.c
1 file changed, 20 insertions(+), 18 deletions(-)
git pull
Patch Set 1:
ping. Minh-Quang do you plan to submit a new version soon? seems like a few
minutes job but it's been waiting for over a month.
--
To view, visit https://gerrit.osmocom.org/5753
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1:
> ping. Minh-Quang do you plan to submit a new version soon? seems
> like a few minutes job but it's been waiting for over a month.
Hi Paul,
I am sorry for the delay. I think that we can simply replace the static const
by const declaration in msg_util.h.
--
To view, visit
Patch Set 1:
Do we need the same fix for sysmoBTS as well?
--
To view, visit https://gerrit.osmocom.org/5753
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 3: Code-Review-1
And finally, regarding to the commit message: we usually follow
a shorter line length in description, so I would be happy if you
limit it as other contributers do. But this is cosmetics...
-1 due to some code warnings...
--
To view, visit
Hello Vadim Yanitskiy, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5753
to look at the new patch set (#2).
LC15: Fix missing fill frame and GSM 05.08 mandatory frame
Problem:
We have noticed that the LC15 BTS does not send L2 fill frame
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6406
to look at the new patch set (#2).
Add tests for OS#2714, "close RSL connections from unknown Unit ID".
This adds two new tests: One for RSL, and a second one which performs
the same
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6286
to look at the new patch set (#2).
Add helper functions for ACC bit flags in rach control IE.
Add inline functions to manipulate and query ACC flag bits
in the
Patch Set 1:
> ping. Minh-Quang do you plan to submit a new version soon? seems
> like a few minutes job but it's been waiting for over a month.
Unfortunately, my local branch of this topic has been lost... is there anyway
to pull this topic to my local BTS repository?
--
To view, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6406
to look at the new patch set (#3).
Add tests for OS#2714, "close RSL connections from unknown Unit ID".
This adds two new tests: One for RSL, and a second one which performs
the same
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/5753/3//COMMIT_MSG
Commit Message:
Line 13: Related issue: https://osmocom.org/issues/1950
Please move close to the change-id and change to:
Related: OS#1950
--
To view, visit https://gerrit.osmocom.org/5753
To unsubscribe, visit
Patch Set 1:
> > ping. Minh-Quang do you plan to submit a new version soon? seems
> > like a few minutes job but it's been waiting for over a month.
>
> Unfortunately, my local branch of this topic has been lost... is
> there anyway to pull this topic to my local BTS repository?
Just
Patch Set 2:
> Uploaded patch set 2.
This new patch set should address the above review comments. This new changeset
also aligns better with how the ACC ramping implementation turned out, i.e.
these new inline functions could be used as drop-in replacements for local
functions written for
Harald Welte has submitted this change and it was merged.
Change subject: Make RSL connection attempts time out.
..
Make RSL connection attempts time out.
If a BTS/TRX does not respond to the "IPA RSL Connect" command,
pretend
Harald Welte has submitted this change and it was merged.
Change subject: Add helper functions for ACC bit flags in rach control IE.
..
Add helper functions for ACC bit flags in rach control IE.
Add inline functions to
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6386
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia72b65a0f15f47dcb8a6f944f6c3695a4a64b923
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6386
to look at the new patch set (#2).
Make RSL connection attempts time out.
If a BTS/TRX does not respond to the "IPA RSL Connect" command,
pretend that the BTS has sent a NACK for the
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/6406/3/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:
Line 1244: testcase TC_rsl_unknown_unit_id() runs on test_CT {
I think it makes sense t owrap those two into one function and call that
function from both test cases? It seems at first
Patch Set 1: Code-Review+1
i think this should be tested with a real BTS setup before merging
--
To view, visit https://gerrit.osmocom.org/6387
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b76ae6b00043e706dddc78209311e00ace85bb7
Patch Set 1:
> (1 comment)
Thanks for your comments. I will refactor the codes to make them cleaner at
some point.
--
To view, visit https://gerrit.osmocom.org/5753
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/6409
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aea339fb08c20e1b66a0d24c76d855bf665a4cd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6389
to look at the new patch set (#2).
.gitignore: Add m4 files
Existing m4/ax_check_compile_flag.m4 is skipped from the list of ignored
files.
Change-Id:
Review at https://gerrit.osmocom.org/6410
modem: deactivate_context: Fix dbg message
Change-Id: Ib3cb72ebcbfbf53693a2d76ca1592ef7d394dd87
---
M src/osmo_gsm_tester/modem.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: modem: deactivate_context: Fix dbg message
..
modem: deactivate_context: Fix dbg message
Change-Id: Ib3cb72ebcbfbf53693a2d76ca1592ef7d394dd87
---
M
Pau Espin Pedrol has abandoned this change.
Change subject: modem: deactivate_context: Fix dbg message
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/6409
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6410
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3cb72ebcbfbf53693a2d76ca1592ef7d394dd87
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Review at https://gerrit.osmocom.org/6418
osmo-bts: Add talloc context introspection via VTY
This requires libosmocore with Change-Id
I43fc42880b22294d83c565ae600ac65e4f38b30d or later.
Change-Id: Ieed87b8109e0095a3d99c30f0b042aa3ee4b6384
---
M src/common/main.c
M src/common/vty.c
2 files
Review at https://gerrit.osmocom.org/6420
osmo-bsc: Add talloc context introspection via VTY
This requires libosmocore with Change-Id
I43fc42880b22294d83c565ae600ac65e4f38b30d or later.
Change-Id: I1245b6818eb54f5c0c8adddcd3a01ecc7363fb42
---
M src/libbsc/bsc_vty.c
M
Review at https://gerrit.osmocom.org/6419
vty: Permit codec-list containing both full-rate and half-rate codecs
Once upon a time, in the old osmo-bsc-sccplite, there was a restriction
of not being able to handle configurations with both TCH/F and TCH/H
type codecs. This time is long gone, so
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/6388/1/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
Line 3718: conn->vsub = vlr_subscr_get(vsub);
a NULL return is only possible if 'vsub' is NULL. I don't think this is valid
here. Read the comment above the
Harald Welte has submitted this change and it was merged.
Change subject: WIP: Prepare MSC_Tests for ability to emulate two BSCs
..
WIP: Prepare MSC_Tests for ability to emulate two BSCs
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6398
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47e639a7c8640c736c84a44780fc8e111a64b52
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: bsc: Add VTY module to BSC_Tests
..
bsc: Add VTY module to BSC_Tests
Change-Id: Ia78f1231f56fc5f3b003bccc850ea109ed4ed2d8
---
M bsc/BSC_Tests.cfg
M
Harald Welte has submitted this change and it was merged.
Change subject: MSC_ConnectionHdlr: Add telnet to VTY to each ConnHdlr
..
MSC_ConnectionHdlr: Add telnet to VTY to each ConnHdlr
This allows each ConnHandler to issue
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6393
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe3ae6ed4181c6ba7501f5443b4f22e3c8abeb3e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Emulation: Add second RSL/RSL_PROC port for hand-over cases
..
RSL_Emulation: Add second RSL/RSL_PROC port for hand-over cases
Also, extend
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6396
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef65f87d0d481accbc0e019874dd43b3f9a5dbc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: MNCC: Copy bearer_cap from MNCC to gsm_trans
..
MNCC: Copy bearer_cap from MNCC to gsm_trans
When we receive bearer capabilities from MNCC and encode
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6414
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa41d22db81120572d4cd2c0c4c75d258947a42f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6413
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89157c446d66e11adbe3cad587eb34ec40271c12
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: MT Calls: Copy bearer capabilities from NNCC primitive to trans
..
MT Calls: Copy bearer capabilities from NNCC primitive to trans
When we receive a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6412
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I332aa8697c98a0d7b3db65f98711275da3d381d7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6411
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I417e23ec53323ddd8e1e5d18952566fe8fd6ac24
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: .gitignore: Add m4 files
..
.gitignore: Add m4 files
Existing m4/ax_check_compile_flag.m4 is skipped from the list of ignored
files.
Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6389
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6415
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f39e706477aaf42051877b52d4b3ae1c5f138e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6416
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0897c47388e49ba7886b55acc728a6f7d213fe
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: sgsn_libgtp.c: Fix typos and whitespace
..
sgsn_libgtp.c: Fix typos and whitespace
Change-Id: Ic223cf378a83051603f58dacf087cc59d9f03890
---
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6417
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I825e659da529257e5edec94d9d59f0e10c1b4c63
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: remove bsc_api.h and all users - they're all dead code
..
remove bsc_api.h and all users - they're all dead code
Related: OS#2528
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: dead code removal
..
dead code removal
Related: OS#2528
Change-Id: I89157c446d66e11adbe3cad587eb34ec40271c12
---
M include/osmocom/msc/gsm_04_08.h
M
Review at https://gerrit.osmocom.org/6421
osmo-hlr: Add talloc context introspection via VTY
This requires libosmocore with Change-Id
I43fc42880b22294d83c565ae600ac65e4f38b30d or later.
Change-Id: Ibc2c333b83f85fa69a364e3e342f12f50dbc2f70
---
M src/hlr.c
M src/hlr_vty.c
2 files changed, 3
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts: Add talloc context introspection via VTY
..
osmo-bts: Add talloc context introspection via VTY
This requires libosmocore with Change-Id
Harald Welte has submitted this change and it was merged.
Change subject: remove unused dyn_ts_allow_tch_f VTY option
..
remove unused dyn_ts_allow_tch_f VTY option
This belongs into the BSC and has no relevance in the MSC, as
Harald Welte has submitted this change and it was merged.
Change subject: gsm_data: remove unused gsm_subscriber_connection members
..
gsm_data: remove unused gsm_subscriber_connection members
The mncc_rtp_create_pending and
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6418
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed87b8109e0095a3d99c30f0b042aa3ee4b6384
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: IPA: log remote address
..
IPA: log remote address
Wrap IPA logging to always print peer's address to simplify
troubleshooting.
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6408
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19ebaea45812aad6b3d3480cac0f1f833daf428d
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6425
Add talloc context introspection via VTY
This requires libosmocore with Change-Id
I43fc42880b22294d83c565ae600ac65e4f38b30d or later.
Change-Id: I460efff3a3dfa2c7d955871aca78b37552a29aff
---
M ggsn/ggsn.c
1 file changed, 3 insertions(+), 0
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6424
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50eb1c5a28efbe4542e177ce3d0a236e75eecdd0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6425
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I460efff3a3dfa2c7d955871aca78b37552a29aff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6411
gsm_data: remove unused gsm_subscriber_connection members
The mncc_rtp_create_pending and mncc_rtp_connect_pending members
were unused, let's remove them.
Related: OS#2528
Change-Id: I417e23ec53323ddd8e1e5d18952566fe8fd6ac24
---
M
Review at https://gerrit.osmocom.org/6415
remove unused VTY command "location updating reject cause"
OsmoMSC is using whatever reject cause is apropriate in the given
situation. This user-configurable reject cause only had relevance
in OsmoNITB, and hence it is an unused parameter that can be
Review at https://gerrit.osmocom.org/6416
remove unused "authorized-regexp" VTY command
This is another left-over VTY command from the OsmoNITB days.
If such functionality is desired, it must be implemented in OsmoHLR,
but not here.
Related: OS#2528
Change-Id:
Review at https://gerrit.osmocom.org/6417
remove unused "auth policy" VTY command
This is yet another unsused bit from the OsmoNITB legacy.
Related: OS#2528
Change-Id: I825e659da529257e5edec94d9d59f0e10c1b4c63
---
M include/osmocom/msc/gsm_data.h
M src/libcommon-cs/common_cs_vty.c
M
Review at https://gerrit.osmocom.org/6414
remove unused dyn_ts_allow_tch_f VTY option
This belongs into the BSC and has no relevance in the MSC, as the MSC
has no clue about dynamic timeslots.
Related: OS#2528
Change-Id: Iaa41d22db81120572d4cd2c0c4c75d258947a42f
---
M
Review at https://gerrit.osmocom.org/6412
remove bsc_api.h and all users - they're all dead code
Related: OS#2528
Change-Id: I332aa8697c98a0d7b3db65f98711275da3d381d7
---
M include/osmocom/msc/Makefile.am
D include/osmocom/msc/bsc_api.h
M include/osmocom/msc/gsm_data.h
M
Review at https://gerrit.osmocom.org/6413
dead code removal
Related: OS#2528
Change-Id: I89157c446d66e11adbe3cad587eb34ec40271c12
---
M include/osmocom/msc/gsm_04_08.h
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/gsm_data_shared.h
M src/libmsc/vty_interface_layer3.c
4 files changed,
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6415
to look at the new patch set (#2).
remove unused VTY command "location updating reject cause"
OsmoMSC is using whatever reject cause is apropriate in the given
situation. This
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6416
to look at the new patch set (#2).
remove unused "authorized-regexp" VTY command
This is another left-over VTY command from the OsmoNITB days.
If such functionality is desired, it
Review at https://gerrit.osmocom.org/6422
osmo-msc: Add talloc context introspection via VTY
This requires libosmocore with Change-Id
I43fc42880b22294d83c565ae600ac65e4f38b30d or later.
Change-Id: I575500bd911f9792ab5ca76eebb1d2682ee34fa3
---
M src/osmo-msc/msc_main.c
1 file changed, 3
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6417
to look at the new patch set (#2).
remove unused "auth policy" VTY command
This is yet another unsused bit from the OsmoNITB legacy.
Related: OS#2528
Change-Id:
Review at https://gerrit.osmocom.org/6423
remove dead code (gsm_parse_reg)
Change-Id: I47b0260561a9c2bad65c50c8164873e4c23d61b7
---
M include/osmocom/msc/gsm_data_shared.h
M src/libcommon/gsm_data.c
2 files changed, 0 insertions(+), 32 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6424
Add talloc context introspection via VTY
This requires libosmocore with Change-Id
I43fc42880b22294d83c565ae600ac65e4f38b30d or later.
Change-Id: I50eb1c5a28efbe4542e177ce3d0a236e75eecdd0
---
M src/gprs/gb_proxy_main.c
M src/gprs/gtphub_main.c
M
Review at https://gerrit.osmocom.org/6426
talloc_ctx_vty: Fix help strings (missing \n at end of line)
This was causing build failures in applications using this library
feature:
Documentation error (missing docs):
Documentation error (missing docs):
Documentation error
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6426
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I785c852e3313d20eade79746a7cd485d2d5908ea
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review-2
we are asking osmo_stream_cli_open2() to do re-connects, so a one-time negative
result is just an intermediate notification, and not a final outcome.
libosmo-netif will continue to retry to connect.
--
To view, visit https://gerrit.osmocom.org/6407
To unsubscribe,
Harald Welte has submitted this change and it was merged.
Change subject: WIP: Intra-BSC handover testing
..
WIP: Intra-BSC handover testing
Change-Id: Ic47e639a7c8640c736c84a44780fc8e111a64b52
---
M bsc/BSC_Tests.ttcn
M
Patch Set 3: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/6376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98976c0ff16a69b2508a79259ed1aeaec51e7549
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Emulation: Add procedure calls to suspend/resume dchan
handling
..
RSL_Emulation: Add procedure calls to suspend/resume dchan handling
We introduce
Harald Welte has submitted this change and it was merged.
Change subject: gsmtap.h: define TETRA DMO mode channels
..
gsmtap.h: define TETRA DMO mode channels
Change-Id: I98976c0ff16a69b2508a79259ed1aeaec51e7549
---
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6385
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd58450548b3a47cb933d70a2e3166c067552b2c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: sgsnemu: fix: no outgoing GTP-U in "createif" mode
..
sgsnemu: fix: no outgoing GTP-U in "createif" mode
in "createif" mode uplink traffic not
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6392
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e563522173a82b265e93b1ef9dc93ced40fefa2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
1 - 100 of 151 matches
Mail list logo
