osmo-bts[master]: scheduler_trx.c: remove ToA (Time of Arrival) hack

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7077 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied0fcfcf58b93efdc6de9666fbbf8fea104e2543 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7079 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3983b1a3ced148ced101584cbc0267f059fe7f6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: common/l1sap.c: clean up RACH ToA (Timing of Arrival) check

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+1 Those checks could actually move above l1sap, in which case we don't need four copies of it, I think? -- To view, visit https://gerrit.osmocom.org/7078 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-bts[master]: common/l1sap.c: clean up RACH ToA (Timing of Arrival) check

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7078 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfe1256cba117a5735107a25bf7cdb47479454ee Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] libosmocore[master]: features: define osmo_bts_*_feature() as static inline

2018-03-05 Thread dexter
Review at https://gerrit.osmocom.org/7084 features: define osmo_bts_*_feature() as static inline The functions osmo_bts_set_feature() and osmo_bts_has_feature() are currently defined as inline. Since inline is a hinting, the compiler might choose not to inline the function. This eventually

[MERGED] libosmocore[master]: fix osmo_mnc_from_str(): don't try to parse NULL

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix osmo_mnc_from_str(): don't try to parse NULL .. fix osmo_mnc_from_str(): don't try to parse NULL In osmo_mnc_from_str() do not try to return some

[MERGED] libosmocore[master]: gsm23003: add osmo_mcc_from_str()

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm23003: add osmo_mcc_from_str() .. gsm23003: add osmo_mcc_from_str() I found myself often using osmo_mnc_from_str() to also decode an MCC and be

osmo-bsc[master]: gsm_data: use feature list from libosmocore

2018-03-05 Thread Harald Welte
Patch Set 4: Code-Review+2 Sorry, missed the depends-on -- To view, visit https://gerrit.osmocom.org/6993 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e80517539cc5d0e5d8189d434a5e3cc0fdea1a0 Gerrit-PatchSet: 4 Gerrit-Project:

libosmocore[master]: features: define osmo_bts_*_feature() as static inline

2018-03-05 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7084 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddd97415a17b06b69f69ddca2e2e296eb2f23a89 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-bts[master]: common/l1sap.c: clean up RACH ToA (Timing of Arrival) check

2018-03-05 Thread Vadim Yanitskiy
Patch Set 1: Hi, > Those checks could actually move above l1sap, in which case we > don't need four copies of it, I think? Do you mean both RACH and ToA checks? Does it make sense to move them into a separate function? -- To view, visit https://gerrit.osmocom.org/7078 To unsubscribe, visit

[MERGED] osmo-bsc[master]: ctrl_test_runner: add tests for 3-digit MNC

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ctrl_test_runner: add tests for 3-digit MNC .. ctrl_test_runner: add tests for 3-digit MNC Expand MCC-MNC test cases: show that the CTRL interface

[MERGED] osmo-bsc[master]: add test for abis_nm_ipaccess_cgi()

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add test for abis_nm_ipaccess_cgi() .. add test for abis_nm_ipaccess_cgi() Change-Id: I90fefd5073ee07fc975a810859a32142b8b27904 --- M

[MERGED] osmo-bsc[master]: add test for gsm48_ra_id_by_bts()

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add test for gsm48_ra_id_by_bts() .. add test for gsm48_ra_id_by_bts() Change-Id: I7bd55126848ed2c246d64cf672e1e6772da64be7 --- M

osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-05 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7020 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dcf2a6fa2991cb73b4807f8a10d251f3dca77dd Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-bsc[master]: add test for gsm48_ra_id_by_bts()

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7075 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bd55126848ed2c246d64cf672e1e6772da64be7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: ctrl_test_runner: add tests for 3-digit MNC

2018-03-05 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7081 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b097dbb6329f284e3b4914a744d5c3ad628f715 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: add test for abis_nm_ipaccess_cgi()

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7076 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90fefd5073ee07fc975a810859a32142b8b27904 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: pcu_if: implement support for 3-digit MNC

2018-03-05 Thread Harald Welte
Patch Set 7: Code-Review+1 Must sync this with corresponding osmo-pcu change. -- To view, visit https://gerrit.osmocom.org/6669 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78f30aef7aa224b2e9db54c3a844d8f520b3aee0 Gerrit-PatchSet: 7

osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-03-05 Thread Pau Espin Pedrol
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/7019/1/jobs/osmo-gsm-tester.yml File jobs/osmo-gsm-tester.yml: Line 36: reverse-job: 'master-{repos}' Apparently, the default value is broken. Jobs like osmo-nitb show a correct "Build Triggers" value in Jenkins web UI.

osmo-bsc[master]: bsc_vty: display bts features in show bts

2018-03-05 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6994 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I650133563436349d4ce55f292ea683dbb2ae68d7 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bts[master]: scheduler_trx.c: remove ToA (Time of Arrival) hack

2018-03-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. Change subject: scheduler_trx.c: remove ToA (Time of Arrival) hack .. scheduler_trx.c: remove ToA (Time of Arrival) hack This was useful for software simulation of

libosmocore[master]: gsm23003: add osmo_mcc_from_str()

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7083 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I020a4f11791c61742a3d795f782805f7b7e8733e Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: fix osmo_mnc_from_str(): don't try to parse NULL

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7082 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaaa128ac60b941a015a31134eb52aef56bc6e22 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-bts[master]: common/l1sap.c: clean up RACH ToA (Timing of Arrival) check

2018-03-05 Thread Vadim Yanitskiy
Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/7078/1/src/common/l1sap.c File src/common/l1sap.c: Line 1200: if (rach_ind->ber10k > btsb->max_ber10k_rach) { Why don't we increase the BTS_CTR_RACH_DROP here? Line 1207: btsb->load.rach.access++; And why this increment

osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-05 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7022/1/jobs/osmo-gsm-tester.yml File jobs/osmo-gsm-tester.yml: Line 238: only-if-success: 'true' We want to store artifacts if it fails, to be able to spot issues from them. -- To view, visit https://gerrit.osmocom.org/7022

osmo-msc[master]: msc_vlr_tests: add test_a5_3_not_supported

2018-03-05 Thread Harald Welte
Patch Set 2: Why are we adding more tests like this with hardcoded byte arrays that no human will ever understand again while reading the code? What's the rationale? Unit tests are nice for testing simple functions. But if you're testing external protocols, why not use ttcn3? It's not a

osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-03-05 Thread Pau Espin Pedrol
Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/7019/1/jobs/osmo-gsm-tester.yml File jobs/osmo-gsm-tester.yml: Line 9: name: osmo-gsm-testers Extra s -> osmo-gsm-tester Line 35: name: builders Extra s? builder Line 50: defaults: builders Again, extra s? Line 54:

osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-05 Thread Pau Espin Pedrol
Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/7021/1/jobs/osmo-gsm-tester.yml File jobs/osmo-gsm-tester.yml: Line 119: clean: true Not sure if we really require another scm (the difference with the other one is clean true/false right?). Do you see any reason to keep 2 of

[PATCH] osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

2018-03-05 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7089 common/l1sap.c: limit the minimal ToA for RACH bursts In general, RACH bursts should not arrive with negative offset. Let's limit early signal arrival up to 2 symbols, otherwise it is most likely noise, interference or a ghost. Change-Id:

[PATCH] osmo-bts[master]: common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER c...

2018-03-05 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7085 common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER check The BTS_CTR_RACH_DROP counter is being increased in case if a RACH request is ignored due to exceeding ToA value, but remains untouched in case of exceeding BER (Bit Error Rate). Let's

[PATCH] osmo-bts[master]: common/l1sap.c: perform noise / ghost filtering for handover...

2018-03-05 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7088 common/l1sap.c: perform noise / ghost filtering for handover RACH For some reason, the noise / ghost filtering was performed for normal RACH requests, but not for handover RACH requests. There are also ghost RACH, interference and noise possible, so

[PATCH] osmo-bts[master]: common/l1sap.c: increment valid RACH counter after all checks

2018-03-05 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7086 common/l1sap.c: increment valid RACH counter after all checks Previously, the number of RACH slots with valid non-handover RACH burst was incremented between both BER (Bit Error Rate) and ToA (Timing of Arrival) checks. So, if a RACH burst passed the

[PATCH] osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

2018-03-05 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6668 to look at the new patch set (#10). implement support for 3-digit MNC with leading zeros Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout the

[MERGED] osmo-bsc[master]: cosmetic: bsc_network_init(): imply default 001-01 PLMN

2018-03-05 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: cosmetic: bsc_network_init(): imply default 001-01 PLMN .. cosmetic: bsc_network_init(): imply default 001-01 PLMN All callers pass mcc=1, mnc=1, so

[MERGED] osmo-bsc[master]: gsm48_ra_id_by_bts(): struct gsm48_ra_id* instead of buf

2018-03-05 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: gsm48_ra_id_by_bts(): struct gsm48_ra_id* instead of buf .. gsm48_ra_id_by_bts(): struct gsm48_ra_id* instead of buf Move from using deprecated

osmo-gsm-tester[master]: ms: Create template for the osmocom-bb mobile application

2018-03-05 Thread Pau Espin Pedrol
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6916 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9296f42edfab57762f8dd317d63231298cda5430 Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: ms: Add lua script support utilities

2018-03-05 Thread Pau Espin Pedrol
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6915 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43ae84a944c7f33e41d5de0880d4aaab3378809b Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: ms: Create an event server to handle Unix datagram messages

2018-03-05 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6914 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida97c570e8e741410f2dba4a231a8058ca96da25 Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: ms: Lua part of location update testing

2018-03-05 Thread Pau Espin Pedrol
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6232 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica5aa0c2f86d0e5d8a2bc4dc0652de18762dd156 Gerrit-PatchSet: 6 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: ms: Create a starter for virtphy and mobile application

2018-03-05 Thread Pau Espin Pedrol
Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py File src/osmo_ms_driver/starter.py: Line 58: import time What about moving the import to the top with the other ones? Line 88: Extra line, can be removed Line 107: def

[ABANDON] osmo-bts[master]: common/l1sap.c: also check BER and ToA for handover RACH

2018-03-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has abandoned this change. Change subject: common/l1sap.c: also check BER and ToA for handover RACH .. Abandoned -- To view, visit https://gerrit.osmocom.org/7080 To unsubscribe, visit

[ABANDON] osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

2018-03-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has abandoned this change. Change subject: common/l1sap.c: limit the minimal ToA for RACH bursts .. Abandoned -- To view, visit https://gerrit.osmocom.org/7079 To unsubscribe, visit

osmo-gsm-tester[master]: ms: Create a simple epoll (or kqueue) based event loop

2018-03-05 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6913 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea06f33870cab9f21e9a1a1feb9758467343dd29 Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-03-05 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6230 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3064f4c3c4c7af5d3491f850090516e541f4d3 Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: ms: Add a main function to start all of it

2018-03-05 Thread Pau Espin Pedrol
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6919 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58c938500a067eebb213750e56d8bf4d8af43df2 Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

2018-03-05 Thread Neels Hofmeyr
Patch Set 9: > Build Successful finally! -- To view, visit https://gerrit.osmocom.org/6668 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa Gerrit-PatchSet: 9 Gerrit-Project: osmo-bsc

[PATCH] osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

2018-03-05 Thread Vadim Yanitskiy
common/l1sap.c: limit the minimal ToA for RACH bursts In general, RACH bursts should not arrive with negative offset. Let's limit early signal arrival up to 2 symbols, otherwise it is most likely noise, interference or a ghost. Change-Id: I662294fe3136cf7a259be13816a3e63f7db9a948 --- M

osmo-gsm-tester[master]: ms: Add a first test to use all parts of the system

2018-03-05 Thread Pau Espin Pedrol
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6918 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3277ed0f0f9ee734569bedd4752564eb68c9cfd Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[PATCH] osmo-msc[master]: VLR: fix potential NULL dereference

2018-03-05 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6388 to look at the new patch set (#3). VLR: fix potential NULL dereference The vlr_subscr_get() can return NULL if its argument is NULL (which isn't checked for) so before

[PATCH] osmo-ttcn3-hacks[master]: bts/BTS_Tests.ttcn: update TC_rach_max_ta test case

2018-03-05 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7090 bts/BTS_Tests.ttcn: update TC_rach_max_ta test case Since the I662294fe3136cf7a259be13816a3e63f7db9a948, OsmoBTS should pass RACH requests with ToA > -2 symbol periods only. We do allow early signal arrival up to 2 symbols, otherwise it is most likely

osmo-trx[master]: vty: Implement VTY cfg parsing for current parameters

2018-03-05 Thread Vadim Yanitskiy
Patch Set 5: Code-Review-1 Please add the configuration example(s) before this change. At the moment, the "osmo-trx-limesdr.cfg" looks unrelated. -- To view, visit https://gerrit.osmocom.org/6650 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_build-trigger-all

2018-03-05 Thread lynxis lazus
Hello Pau Espin Pedrol, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7020 to look at the new patch set (#2). jenkins: add job osmo-gsm-tester_build-trigger-all osmo-gsm-tester_build-trigger-all triggers a new build of all osmo-gsm-tester build jobs.

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester_run-{prod,rnd}

2018-03-05 Thread lynxis lazus
jenkins: add osmo-gsm-tester_run-{prod,rnd} Both jobs doing the actual test run on the prod or rnd tester. Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0 --- M jobs/osmo-gsm-tester.yml A jobs/osmo-gsm-tester_run-prod.sh A jobs/osmo-gsm-tester_run-rnd.sh 3 files changed, 150 insertions(+),

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-03-05 Thread lynxis lazus
Hello Pau Espin Pedrol, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7019 to look at the new patch set (#3). jenkins: add osmo-gsm-tester-build jobs The build jobs building all osmocom components which will be used by the osmo-gsm-tester. A .tgz archive

[PATCH] libosmocore[master]: osmo-release.sh: Set correct version when generating the cha...

2018-03-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7094 osmo-release.sh: Set correct version when generating the changelog Otherwise, while updating osmo-trx 0.2.0->0.3.0, the version printed in the changelog by gbp dch is 0.2.1 Change-Id: I744adb23b4602e5e47f80a012286578d1e59de88 --- M osmo-release.sh 1

[PATCH] osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-03-05 Thread lynxis lazus
Hello Pau Espin Pedrol, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7019 to look at the new patch set (#2). jenkins: add osmo-gsm-tester-build jobs The build jobs building all osmocom components which will be used by the osmo-gsm-tester. A .tgz archive

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-05 Thread lynxis lazus
jenkins: add job osmo-gsm-tester_gerrit The job verifies the gerrit patchset. Change-Id: If661675528059bc8a95d39a6489a5a9381f52677 --- M jobs/osmo-gsm-tester.yml A jobs/osmo-gsm-tester_gerrit.sh 2 files changed, 63 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

2018-03-05 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7089 to look at the new patch set (#3). common/l1sap.c: limit the minimal ToA for RACH bursts In general, RACH bursts should not arrive with negative offset. Let's limit early signal

[PATCH] osmo-trx[rel-0.3.0]: Bump version: 0.2.0 → 0.3.0

2018-03-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7093 Bump version: 0.2.0 → 0.3.0 Change-Id: I4dad76ed95dc585acfbd52d7eed4f2e6f9f5fd1f --- M debian/changelog 1 file changed, 68 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/93/7093/1 diff --git

[PATCH] osmo-trx[rel-0.3.0]: Fix USRP1 build with support for setting Rx/TxAntenna

2018-03-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7091 Fix USRP1 build with support for setting Rx/TxAntenna The USRP1 build was broken by commit 77ce99ac6720896f504a0581a5c57b2929a13cef. Commit 77ce99ac6720896f504a0581a5c57b2929a13cef broke the USRP1 build Change-Id:

[PATCH] osmo-trx[rel-0.3.0]: jenkins.sh: fix the download url if the qemu image wasn't setup

2018-03-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7092 jenkins.sh: fix the download url if the qemu image wasn't setup Download the image from yesterday because linuxcontainers only contains the images of the last 3 days. Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f (cherry picked from commit

osmo-bts[master]: common/l1sap.c: increment valid RACH counter after all checks

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7086 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31594a8c5dce1f42226ced5b2dc8778152b3d829 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER c...

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7085 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia02e781d6c47d9d8012a4c8846fe4b731aab74d7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-ttcn3-hacks[master]: bts/BTS_Tests.ttcn: update TC_rach_max_ta test case

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7090 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88545ed3aabd6da28a40599a8a77d1de477d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: bts/BTS_Tests.ttcn: update TC_rach_max_ta test case

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts/BTS_Tests.ttcn: update TC_rach_max_ta test case .. bts/BTS_Tests.ttcn: update TC_rach_max_ta test case Since the

[MERGED] osmo-bts[master]: l1_tch: remove dead code

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: l1_tch: remove dead code .. l1_tch: remove dead code the file l1_tch.c in the octphy spcific code has its root in the tch.c file of sysmobts. It

[MERGED] osmo-ci[master]: osmo-clean-workspace: fix force checkout of a subdirectory

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-clean-workspace: fix force checkout of a subdirectory .. osmo-clean-workspace: fix force checkout of a subdirectory Instead of the subdirectory,

osmo-bts[master]: l1_tch: remove dead code

2018-03-05 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7029 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33f3e0fd293ca8387fddf5ed20f642621e9680de Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

libosmocore[master]: features: define osmo_bts_*_feature() as static inline

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7084 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddd97415a17b06b69f69ddca2e2e296eb2f23a89 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] osmo-ci[master]: jenkins: add job osmo-gsm-tester_gerrit

2018-03-05 Thread lynxis lazus
jenkins: add job osmo-gsm-tester_gerrit The job verifies the gerrit patchset. Change-Id: If661675528059bc8a95d39a6489a5a9381f52677 --- M jobs/osmo-gsm-tester.yml A jobs/osmo-gsm-tester_gerrit.sh 2 files changed, 63 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

osmo-bts[master]: common/l1sap.c: perform noise / ghost filtering for handover...

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7088 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94fc15835280d624780200dadc4418210bf565ff Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: common/l1sap.c: clean up noise / ghost RACH filtering

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7087 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ddda238d5212a88a3dd5c4fc5dfcfea018151bd Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

2018-03-05 Thread Harald Welte
Patch Set 10: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: PS10, Line 1280: ; :lai = (struct osmo_location_area_id) why not simply have the '=' one line above, no typecast and no

osmo-ci[master]: osmo-clean-workspace: fix force checkout of a subdirectory

2018-03-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/6964 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If23e89872edf48dc5b751b3c069faf585bd6a3ef Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] libosmocore[master]: features: define osmo_bts_*_feature() as static inline

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: features: define osmo_bts_*_feature() as static inline .. features: define osmo_bts_*_feature() as static inline The functions osmo_bts_set_feature()

osmo-trx[rel-0.3.0]: jenkins.sh: fix the download url if the qemu image wasn't setup

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7092 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: rel-0.3.0

osmo-trx[rel-0.3.0]: Bump version: 0.2.0 → 0.3.0

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7093 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dad76ed95dc585acfbd52d7eed4f2e6f9f5fd1f Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: rel-0.3.0

osmo-trx[rel-0.3.0]: Fix USRP1 build with support for setting Rx/TxAntenna

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7091 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28585947d5662cdd580a814cce54a5d9aa30eeb8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: rel-0.3.0

[MERGED] libosmocore[master]: osmo-release.sh: Set correct version when generating the cha...

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-release.sh: Set correct version when generating the changelog .. osmo-release.sh: Set correct version when generating the changelog Otherwise,

libosmocore[master]: osmo-release.sh: Set correct version when generating the cha...

2018-03-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7094 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I744adb23b4602e5e47f80a012286578d1e59de88 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] osmo-bts[master]: common/l1sap.c: increment valid RACH counter after all checks

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: common/l1sap.c: increment valid RACH counter after all checks .. common/l1sap.c: increment valid RACH counter after all checks Previously, the number of

osmo-gsm-tester[master]: ms: Add a main function to start all of it

2018-03-05 Thread Pau Espin Pedrol
Patch Set 5: Holger you need to rebase all your patches on top of latest osmo-gsm-tester master to have jenkins verifying correctly the patches. -- To view, visit https://gerrit.osmocom.org/6919 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[MERGED] osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: common/l1sap.c: limit the minimal ToA for RACH bursts .. common/l1sap.c: limit the minimal ToA for RACH bursts In general, RACH bursts should not arrive

[MERGED] osmo-bts[master]: common/l1sap.c: perform noise / ghost filtering for handover...

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: common/l1sap.c: perform noise / ghost filtering for handover RACH .. common/l1sap.c: perform noise / ghost filtering for handover RACH For some reason,

[MERGED] osmo-bts[master]: common/l1sap.c: clean up noise / ghost RACH filtering

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: common/l1sap.c: clean up noise / ghost RACH filtering .. common/l1sap.c: clean up noise / ghost RACH filtering It makes sense to combine both existing

[MERGED] osmo-bts[master]: common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER c...

2018-03-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER check .. common/l1sap.c: increase the BTS_CTR_RACH_DROP in RACH BER check The

osmo-bts[master]: common/l1sap.c: limit the minimal ToA for RACH bursts

2018-03-05 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7089 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I662294fe3136cf7a259be13816a3e63f7db9a948 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-msc[master]: VLR: fix potential NULL dereference

2018-03-05 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6388 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-trx[rel-0.3.0]: Bump version: 0.2.0 → 0.3.0

2018-03-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: Bump version: 0.2.0 → 0.3.0 .. Bump version: 0.2.0 → 0.3.0 Change-Id: I4dad76ed95dc585acfbd52d7eed4f2e6f9f5fd1f --- M debian/changelog 1 file

[PATCH] osmo-trx[master]: vty: Implement VTY cfg parsing for current parameters

2018-03-05 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6650 to look at the new patch set (#6). vty: Implement VTY cfg parsing for current parameters At this stage, osmo-trx still uses the cmdline parameters top run the device,

[PATCH] osmo-trx[master]: osmo-trx: Use VTY cfg structures while still allowing cmd li...

2018-03-05 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6651 to look at the new patch set (#6). osmo-trx: Use VTY cfg structures while still allowing cmd line options Existing cmd line options are kept for a while to give people some time to

[PATCH] osmo-trx[master]: osmo-trx.cpp: Move trx start and stop to helper functions

2018-03-05 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6648 to look at the new patch set (#6). osmo-trx.cpp: Move trx start and stop to helper functions Make main() smaller, and make it easier to replace cmdline parameters in

[PATCH] osmo-trx[master]: doc: Add sample cfg file for LimeSDR

2018-03-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7095 doc: Add sample cfg file for LimeSDR Change-Id: I16de70eac0fd79107b8317af37201e6da834c169 --- A doc/examples/osmo-trx-limesdr.cfg 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx

[PATCH] libosmo-netif[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7101 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I739f4562a96b7b6031075d47d94f46af7a37b4b4 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif

[PATCH] libosmo-sccp[master]: configure: add --enable-werror

2018-03-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7102 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set.

[PATCH] libasn1c[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7097 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I4791c6a32d983869692df36172f93adee819debb --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c

[PATCH] libosmo-abis[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7099 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I487ab6f2e391aa57404725de2c8ab5447ca9f725 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis

[PATCH] libosmo-netif[master]: configure: add --enable-werror

2018-03-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set.

[PATCH] libasn1c[master]: configure: add --enable-werror

2018-03-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7096 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set.

[PATCH] libosmo-abis[master]: configure: add --enable-werror

2018-03-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7098 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set.

  1   2   >