Pau Espin Pedrol has submitted this change and it was merged.
Change subject: contrib: build-osmo-bsc: Add aibsip-find and ipaccess-config
binaries to archive
..
contrib: build-osmo-bsc: Add aibsip-find and ipaccess-config
Review at https://gerrit.osmocom.org/7184
sysinfo.c: SI1 is optional; Send SI2 at TC=0 if no SI1 exists
SI1 is only required if frequency hopping is used or if NCH is used. So it's
optional.
If OsmoBTS has no SI1 configured, it will transmit the empty SI1 buffer
at TC=0, and as a result no
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7182
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a1918971388afad41308629c1851614d1381f25
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: contrib: build-osmo-bts: Remove dropped dependency openbsc
..
contrib: build-osmo-bts: Remove dropped dependency openbsc
Since osmo-bts
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7183
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0e003f74603c3146aa76d581ab493f960f73ab5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7176
to look at the new patch set (#3).
fix: clear vlr_subscr->msc_conn_ref when the conn is discarded
Before this, it was for example possible to crash the MSC by the vty 'show
subscriber'
Review at https://gerrit.osmocom.org/7191
msc_vlr_test_umts_authen: test response with too long RES
Change-Id: Ie5473f06fc2d04c6a9f343da5764ec95b292a5f9
---
M tests/msc_vlr/msc_vlr_test_umts_authen.c
M tests/msc_vlr/msc_vlr_test_umts_authen.err
2 files changed, 289 insertions(+), 0
Review at https://gerrit.osmocom.org/7186
msc_vlr_test_gsm_ciph: add test for GSM AKA in UMTS environment
Even on an R99 capable UE with a UMTS AKA capable USIM, the ME may still choose
to only perform GSM AKA, as long as the bearer is GERAN. In that case, we must
make sure to send the GSM AKA
Review at https://gerrit.osmocom.org/7190
msc_vlr_test_umts_authen: test response with too short RES
Change-Id: Ia1bc57b3dc1f3c3c654ba2d907b16ba925cd03e8
---
M tests/msc_vlr/msc_vlr_test_umts_authen.c
M tests/msc_vlr/msc_vlr_test_umts_authen.err
2 files changed, 290 insertions(+), 0
Review at https://gerrit.osmocom.org/7194
cosmetic: vlr_auth_fsm: log RAN and size along with SRES/RES
Change-Id: Ib0f9f573ffac2302fbd3ee28f48ccd8fce5fe286
---
M src/libvlr/vlr_auth_fsm.c
M tests/msc_vlr/msc_vlr_test_authen_reuse.err
M tests/msc_vlr/msc_vlr_test_call.err
M
Review at https://gerrit.osmocom.org/7189
gsm48_rx_mm_auth_resp(): pass is_r99 from classmark, not response size
Do not interpret the SRES/RES length returned in the auth response as the R99
capability bit, instead determine it from the actual Classmark information
associated with the conn.
Review at https://gerrit.osmocom.org/7188
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, actually feed invalid auth response
data to vlr_subscr_rc_auth_resp() in order to trigger all the actions we want
to see with a failed authentication:
- a
Review at https://gerrit.osmocom.org/7192
msc_vlr_test_umts_authen: test response with only SRES half of RES
Change-Id: I0e9099625bd9d3de3db5ee29fbf81b2d8a30071d
---
M tests/msc_vlr/msc_vlr_test_umts_authen.c
M tests/msc_vlr/msc_vlr_test_umts_authen.err
2 files changed, 294 insertions(+), 0
Review at https://gerrit.osmocom.org/7187
vlr: fix GSM AKA in a UMTS AKA capable environment
Switch by vsub->sec_ctx to use the proper Kc for ciphering.
Even on an R99 capable UE with a UMTS AKA capable USIM, the ME may still choose
to only perform GSM AKA, as long as the bearer is GERAN. The
Review at https://gerrit.osmocom.org/7193
cosmetic: vlr_auth_fsm: clarify decision on UMTS AKA or GSM AKA
The code deciding on whether UMTS AKA is used was cascaded and convoluted. By
flattening the decisions, they become easier to read and possibly catch more
weird corner cases / log
Review at https://gerrit.osmocom.org/7185
msc_vlr_tests: clearly separate Ciph Mode from Security Mode checking
Clearly distinguish between Ciphering Mode Command on GERAN and Security Mode
Control on UTRAN.
Cosmetic: explicitly verify the key strings in the testing code (not only in
the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7189
to look at the new patch set (#3).
gsm48_rx_mm_auth_resp(): pass is_r99 from classmark, not response size
Do not interpret the SRES/RES length returned in the auth response as the R99
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7188
to look at the new patch set (#3).
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, signal auth failure to the VLR in
order to trigger
Review at https://gerrit.osmocom.org/7195
cosmetic: gsm48_rx_mm_auth_resp(): log 'UMTS AKA', not 'R99 AKA'
Change-Id: Iba43c685cbe238d96175267e9cc954b2f2f3e7fc
---
M src/libmsc/gsm_04_08.c
M tests/msc_vlr/msc_vlr_test_authen_reuse.err
M tests/msc_vlr/msc_vlr_test_call.err
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7190
to look at the new patch set (#3).
msc_vlr_test_umts_authen: test response with too short RES
Change-Id: Ia1bc57b3dc1f3c3c654ba2d907b16ba925cd03e8
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7193
to look at the new patch set (#3).
cosmetic: vlr_auth_fsm: clarify decision on UMTS AKA or GSM AKA
The code deciding on whether UMTS AKA is used was cascaded and convoluted. By
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7194
to look at the new patch set (#3).
cosmetic: vlr_auth_fsm: log RAN and size along with SRES/RES
Change-Id: Ib0f9f573ffac2302fbd3ee28f48ccd8fce5fe286
---
M src/libvlr/vlr_auth_fsm.c
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7191
to look at the new patch set (#3).
msc_vlr_test_umts_authen: test response with too long RES
Change-Id: Ie5473f06fc2d04c6a9f343da5764ec95b292a5f9
---
M
msc_vlr_test_gsm_ciph: add test for GSM AKA in UMTS environment
Even on an R99 capable MS with a UMTS AKA capable USIM, the MS may still choose
to only perform GSM AKA, as long as the bearer is GERAN. In that case, we must
make sure to send the GSM AKA Kc for ciphering.
Add
vlr: fix GSM AKA in a UMTS AKA capable environment
Switch by vsub->sec_ctx to use the proper Kc for ciphering.
Even on an R99 capable MS with a UMTS AKA capable USIM, the MS may still choose
to only perform GSM AKA, as long as the bearer is GERAN. The VLR already stores
whether the MS replied
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7188/3/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
Line 978: return vlr_subscr_rx_auth_fail(conn->vsub, NULL);
hmm, this is actually meant for the MM Authentication Failure message from the
MS, which also is capable
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7193
to look at the new patch set (#2).
cosmetic: vlr_auth_fsm: clarify decision on UMTS AKA or GSM AKA
The code deciding on whether UMTS AKA is used was cascaded and convoluted. By
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7194
to look at the new patch set (#2).
cosmetic: vlr_auth_fsm: log RAN and size along with SRES/RES
Change-Id: Ib0f9f573ffac2302fbd3ee28f48ccd8fce5fe286
---
M src/libvlr/vlr_auth_fsm.c
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7192
to look at the new patch set (#2).
msc_vlr_test_umts_authen: test response with only SRES half of RES
Change-Id: I0e9099625bd9d3de3db5ee29fbf81b2d8a30071d
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7191
to look at the new patch set (#2).
msc_vlr_test_umts_authen: test response with too long RES
Change-Id: Ie5473f06fc2d04c6a9f343da5764ec95b292a5f9
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7190
to look at the new patch set (#2).
msc_vlr_test_umts_authen: test response with too short RES
Change-Id: Ia1bc57b3dc1f3c3c654ba2d907b16ba925cd03e8
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7189
to look at the new patch set (#2).
gsm48_rx_mm_auth_resp(): pass is_r99 from classmark, not response size
Do not interpret the SRES/RES length returned in the auth response as the R99
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7188
to look at the new patch set (#2).
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, actually feed invalid auth response
data to
Harald Welte has submitted this change and it was merged.
Change subject: fix handover: handle_ph_ra_ind(): evaluate ra_ind before
msgb_trim()
..
fix handover: handle_ph_ra_ind(): evaluate ra_ind before msgb_trim()
Commit
Patch Set 2:
merge this now, we can still improve further upon it later
--
To view, visit https://gerrit.osmocom.org/7169
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I203021ee57f49cb963679ba8bec5943e2abb67fb
Gerrit-PatchSet: 2
Patch Set 1:
> So clearly =pragma is wrong
Ah, you meant, not suppress #pragma, but use #pragma instead of #warning. Ok,
possible, but with -Wno-error=cpp we can also keep the #warnings :)
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit
Patch Set 1:
well, as nobody is proposign any feasible alternative, I'm inclined to say "go
ahead mark all of those as +2 and merge it'. I still don't like it, but I
don't have time for a counter-proposal either.
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit
Harald Welte has submitted this change and it was merged.
Change subject: src/msgb.c: print an error if msgb allocation failed
..
src/msgb.c: print an error if msgb allocation failed
Printing an error message when msgb
Harald Welte has submitted this change and it was merged.
Change subject: src/msgb.c: remove dead includes from OpenBSC
..
src/msgb.c: remove dead includes from OpenBSC
The MSGB API is not a part of OpenBSC anymore, so let's
Harald Welte has submitted this change and it was merged.
Change subject: src/msgb.c: cosmetic: fix spelling mistakes
..
src/msgb.c: cosmetic: fix spelling mistakes
Change-Id: I6b473aadaa22d95f2a8cc87580c638ccd7e531a4
---
M
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7165
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1080c9071e997944cc0f9fc3716129e9395437ad
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: src/msgb.c: avoid using internal talloc API
..
src/msgb.c: avoid using internal talloc API
An internal symbol '_talloc_zero' of talloc library was used
Patch Set 1:
It would be nice if somebody with better knowledge on how the debian packages
are being generated can have a look at this and test it.
--
To view, visit https://gerrit.osmocom.org/7175
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Review at https://gerrit.osmocom.org/7175
debian: Move abisip-find from osmo-bsc to its own package
In some scenarios osmo-bsc is not required, only abisip-find to do the
initial set-up of the BTS, so no need to install osmo-bsc with it.
Change-Id: If3d476a1bd67abcb9cff241ab5989db923873986
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7169
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I203021ee57f49cb963679ba8bec5943e2abb67fb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7170
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ffb03b9e7b642f45732ba5938977bca271f1c7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/7172/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
Line 672: size_t cmd_len = strlen(cmd);
as the string of cmd is known at compile time, better pass cmd_len as param and
use eg.
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7171
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f413f33156c38a853efc5a8cdc66fbfb0ca6af
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7173
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If69a478121a31aa7df945548cc17271c476d6a6b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
> Regarding deprecated, I think it's good that it fails when using a
> deprecated symbol, this way it forces us to fix it.
That part is good, yes, but the pattern that has emerged recently is: our
jenkins builds use -Werror. That means as soon as we create some foo2() and
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/7172/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
Line 672: size_t cmd_len = strlen(cmd);
> as the string of cmd is known at compile time, better pass cmd_len as param
Thanks!
> mark it as static and let the
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7172
to look at the new patch set (#2).
Transceiver.cpp: use pointer arithmetics for CMD parsing
It looks like the author of control command parsing code was not
familar
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7174
to look at the new patch set (#2).
Transceiver.cpp: prevent out-of-range array access
There was no a simple range check for both (NO)HANDOVER commands,
so an
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7172/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:
Line 672: size_t cmd_len = strlen(cmd);
> Thanks!
You can add a macro:
#define MATCH_CMD(buf, cmd, params) match_cmd(buf, cmd, sizeof(cmd) - 1, params)
You can
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7168
to look at the new patch set (#2).
WIP: Introduce ip.access nanobts support
Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
---
M example/resources.conf
A
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7158
to look at the new patch set (#2).
Create Pcu abstract class and make OsmoPcu inherit from it
This base class will be used to describe the required accessors for all
PCU
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7160
to look at the new patch set (#2).
Create Bts abstract class and make OsmoBts inherit from it
This base class will be used to describe the required accessors for all
BTS
Review at https://gerrit.osmocom.org/7183
contrib: build-osmo-bsc: Add aibsip-find and ipaccess-config binaries to archive
They will be required by Nanobts class.
Change-Id: Ib0e003f74603c3146aa76d581ab493f960f73ab5
---
M contrib/jenkins-build-osmo-bsc.sh
1 file changed, 1 insertion(+), 1
Review at https://gerrit.osmocom.org/7182
contrib: build-osmo-bts: Remove dropped dependency openbsc
Since osmo-bts ec33b0397f5d71248c5834513d4be7b9b0e46366, it doesn't
require openbsc anymore to build.
Change-Id: I8a1918971388afad41308629c1851614d1381f25
---
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7167
to look at the new patch set (#2).
Introduce PowerSupply interface and PowerSupplySispm
File powersupply.py defines the interface to be used by child classes
implementing
Review at https://gerrit.osmocom.org/7176
fix: clear vlr_subscr->msc_conn_ref when the conn is discarded
Change-Id: Ia4105d9f135ba3216ad3c86157be7658b1d568fb
---
M src/libmsc/osmo_msc.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Review at https://gerrit.osmocom.org/7181
silent call: clarify rc and error messages logged on vty
In gsm_silent_call_{start,stop}(), return meaningful error codes and interpret
them on the VTY to clearly indicate the result.
Change-Id: Id5abb8f2ba901689e03040af8e51483b6c618e7f
---
M
Review at https://gerrit.osmocom.org/7180
msc_main: do not say 'osmo-nitb' in the usage
Change-Id: I2090097dc0d7e0251c116b95b802076df3419455
---
M src/osmo-msc/msc_main.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/80/7180/1
Review at https://gerrit.osmocom.org/7179
vty: add 'subscriber ... paging' cmd
Allow issuing an empty paging from the VTY, for debugging purposes.
Change-Id: I403904cb789ece699f14b4cbd52c336eb02d45e4
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 26 insertions(+), 0 deletions(-)
Review at https://gerrit.osmocom.org/7177
vty: drop unused commands
Change-Id: I76d6777ebe9105b8abf37993b86c3749a7e18008
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 0 insertions(+), 30 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/77/7177/1
diff
fix: clear vlr_subscr->msc_conn_ref when the conn is discarded
Before this, it was for example possible to crash the MSC by the vty 'show
subscriber' command, which would dereference a potentially stale
vsub->msc_conn_ref pointer.
Related: OS#3050
Change-Id:
Review at https://gerrit.osmocom.org/7178
vty: add 'msisdn' as alias for 'extension'
Rationale: in the HLR, it is called 'msisdn' after the database column, so a
user going back and forth between osmo-hlr and osmo-msc would appreciate being
able to type 'msisdn' in the MSC's vty as well.
67 matches
Mail list logo
