Review at https://gerrit.osmocom.org/7197
sysmobts: Compatibility with older firmware versions
When using a firmware version < 3.6, the call to l1if_mute_rf()
returned an error, which caused an OML CHG ADM STATE NACK.
Let's check if the l1if_mute_rf() call is an un-mute for all
timeslots (whic
Review at https://gerrit.osmocom.org/7196
[sysmobts] HACK: Log L1C/NOTICE message for every RACH received
Change-Id: I68d7584c198540c01b83ea8d12e7a61792b01ee7
---
M src/osmo-bts-sysmo/femtobts.c
M src/osmo-bts-sysmo/femtobts.h
M src/osmo-bts-sysmo/l1_if.c
3 files changed, 21 insertions(+), 0 de
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7197
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a29c1031d96e65a0111bc812a90f2dbaf2a5aa3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has abandoned this change.
Change subject: [sysmobts] HACK: Log L1C/NOTICE message for every RACH received
..
Abandoned
never intended to push this one
--
To view, visit https://gerrit.osmocom.org/7196
To unsubsc
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7177
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d6777ebe9105b8abf37993b86c3749a7e18008
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7178
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b46f9736421e8edd8a95ae89e025ebe486fde4c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7179
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I403904cb789ece699f14b4cbd52c336eb02d45e4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7176
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4105d9f135ba3216ad3c86157be7658b1d568fb
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7180
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2090097dc0d7e0251c116b95b802076df3419455
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7181
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5abb8f2ba901689e03040af8e51483b6c618e7f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: msc_main: do not say 'osmo-nitb' in the usage
..
msc_main: do not say 'osmo-nitb' in the usage
Change-Id: I2090097dc0d7e0251c116b95b802076df3419455
---
M
Harald Welte has submitted this change and it was merged.
Change subject: vty: add 'subscriber ... paging' cmd
..
vty: add 'subscriber ... paging' cmd
Allow issuing an empty paging from the VTY, for debugging purposes.
Change-
Harald Welte has submitted this change and it was merged.
Change subject: vty: drop unused commands
..
vty: drop unused commands
Change-Id: I76d6777ebe9105b8abf37993b86c3749a7e18008
---
M src/libmsc/vty_interface_layer3.c
1 fil
Harald Welte has submitted this change and it was merged.
Change subject: fix: clear vlr_subscr->msc_conn_ref when the conn is discarded
..
fix: clear vlr_subscr->msc_conn_ref when the conn is discarded
Before this, it was for
Harald Welte has submitted this change and it was merged.
Change subject: silent call: clarify rc and error messages logged on vty
..
silent call: clarify rc and error messages logged on vty
In gsm_silent_call_{start,stop}(), r
Harald Welte has submitted this change and it was merged.
Change subject: vty: add 'msisdn' as alias for 'extension'
..
vty: add 'msisdn' as alias for 'extension'
Rationale: in the HLR, it is called 'msisdn' after the database
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7185
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica93ed06c4c63dc6768736d25231de8068001114
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7186
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85f12a20dcd701e671188e56811ec7b58d84da82
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/7186
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85f12a20dcd701e671188e56811ec7b58d84da82
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Ow
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/7187
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42ce51ae979f42d173a45ae69273071c426bf97c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: ma
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7188/3/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
Line 978: return vlr_subscr_rx_auth_fail(conn->vsub, NULL);
> hmm, this is actually meant for the MM Authentication Failure message from
I think zero R
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7195
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba43c685cbe238d96175267e9cc954b2f2f3e7fc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7192
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9099625bd9d3de3db5ee29fbf81b2d8a30071d
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7190
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bc57b3dc1f3c3c654ba2d907b16ba925cd03e8
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7191
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5473f06fc2d04c6a9f343da5764ec95b292a5f9
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7189
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f7d89a8b9455d2c022d53d74328fa7488577f4
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+1
Similar to other patches before: Why are we doing this here and not in TTCN-3,
particularly if it's about entire new tests? I've asked the question before,
but you didn't answer and instead keep senidng the patches. Please at least
let me know what the reasons are.
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7194
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f9f573ffac2302fbd3ee28f48ccd8fce5fe286
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7184
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41ab885c00e943199b2e939e98f30e267ecffbee
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7193
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43f7f301ea85e518bac91f707391a53182e54fab
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: sysinfo.c: SI1 is optional; Send SI2 at TC=0 if no SI1 exists
..
sysinfo.c: SI1 is optional; Send SI2 at TC=0 if no SI1 exists
SI1 is only required if fr
Harald Welte has submitted this change and it was merged.
Change subject: sysmobts: Compatibility with older firmware versions
..
sysmobts: Compatibility with older firmware versions
When using a firmware version < 3.6, the cal
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7167
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I981c260eca1a61657147e6d83b4226618088223c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7158
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3fd4551d1f2932362f99f7d44d65f8ae4fd1979
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7168
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/7175/1/debian/control
File debian/control:
PS1, Line 43: ip.access compatible
Abis/IP BTS
--
To view, visit https://gerrit.osmocom.org/7175
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: com
Harald Welte has submitted this change and it was merged.
Change subject: debian: Move abisip-find from osmo-bsc to its own package
..
debian: Move abisip-find from osmo-bsc to its own package
In some scenarios osmo-bsc is not
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_9.0/i586
Package network:osmocom:latest/openbsc failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:latest openbsc
Last lines of build log:
[ 159s] Mak
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_9.0/x86_64
Package network:osmocom:latest/openbsc failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest openbsc
Last lines of build log:
[ 163s]
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_9.0/aarch64
Package network:osmocom:latest/openbsc failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:latest openbsc
Last lines of build log:
[ 743
Neels Hofmeyr has submitted this change and it was merged.
Change subject: vlr: fix GSM AKA in a UMTS AKA capable environment
..
vlr: fix GSM AKA in a UMTS AKA capable environment
Switch by vsub->sec_ctx to use the proper Kc fo
Neels Hofmeyr has submitted this change and it was merged.
Change subject: msc_vlr_tests: clearly separate Ciph Mode from Security Mode
checking
..
msc_vlr_tests: clearly separate Ciph Mode from Security Mode checking
Clearly
Neels Hofmeyr has submitted this change and it was merged.
Change subject: msc_vlr_test_gsm_ciph: add test for GSM AKA in UMTS environment
..
msc_vlr_test_gsm_ciph: add test for GSM AKA in UMTS environment
Even on an R99 capabl
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7189
to look at the new patch set (#4).
gsm48_rx_mm_auth_resp(): pass is_r99 from classmark, not response size
Do not interpret the SRES/RES length returned in the auth respons
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7193
to look at the new patch set (#4).
cosmetic: vlr_auth_fsm: clarify decision on UMTS AKA or GSM AKA
The code deciding on whether UMTS AKA is used was cascaded and convolute
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7188
to look at the new patch set (#4).
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, actually feed invalid auth response
data
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7194
to look at the new patch set (#4).
cosmetic: vlr_auth_fsm: log RAN and size along with SRES/RES
Change-Id: Ib0f9f573ffac2302fbd3ee28f48ccd8fce5fe286
---
M src/libvlr/vlr_a
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7195
to look at the new patch set (#2).
cosmetic: gsm48_rx_mm_auth_resp(): log 'UMTS AUTH', not 'R99 AUTH'
Change-Id: Iba43c685cbe238d96175267e9cc954b2f2f3e7fc
---
M src/libmsc
Patch Set 4: Code-Review+2
(resurrect previous +2, lost due to trivial merge conflict resolution)
--
To view, visit https://gerrit.osmocom.org/7189
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7f7d89a8b9455d2c022d53d74328fa7488577f4
Patch Set 4: Code-Review+2
(resurrect previous +2, lost due to trivial merge conflict resolution)
--
To view, visit https://gerrit.osmocom.org/7193
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43f7f301ea85e518bac91f707391a53182e54fab
Patch Set 4:
> Similar to other patches before: Why are we doing this here and not
> in TTCN-3, particularly if it's about entire new tests? I've asked
> the question before, but you didn't answer and instead keep senidng
> the patches. Please at least let me know what the reasons are...
Hm
Patch Set 4: Code-Review+2
(resurrect previous +2, lost due to trivial merge conflict resolution)
--
To view, visit https://gerrit.osmocom.org/7194
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f9f573ffac2302fbd3ee28f48ccd8fce5fe286
Patch Set 2: Code-Review+2
(resurrect previous +2, lost due to trivial merge conflict resolution)
--
To view, visit https://gerrit.osmocom.org/7195
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba43c685cbe238d96175267e9cc954b2f2f3e7fc
Patch Set 4:
ok, now we're back to patch set 2, passing a zero res to trigger failure.
--
To view, visit https://gerrit.osmocom.org/7188
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4179a290069ac61d0662de4ec7ca3edb76988899
Gerrit-Patc
Patch Set 2:
> if you're testing external protocols, why not use ttcn3?
I answered at length in https://gerrit.osmocom.org/7190 -- the short answer
here is that I wrote this test to analyse the failure, because it was by far
the fastest way for me to find a fix. Now that the test exists, why n
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7058
to look at the new patch set (#3).
msc_vlr_tests: add test_a5_3_not_supported
See also change-id I72a1dbb30e0a39dbf4b81c7e378d5607b62e10d3 in
osmo-ttcn3-hacks.git, which adds a similar
Patch Set 1:
Right now I can't seem to reproduce the problem in the first place. If I
basically pipe 'git status' to .gitignore, it ignores the files fine. That's
with git versions 2.15.1 and 2.11.0. I wonder which setup made me conclude that
I could not add the symlinks to .gitignore effectiv
Review at https://gerrit.osmocom.org/7198
gitignore symlinks
Change-Id: I5f9fe17c20e2dd72b654fb6d919e7ec1289b4f88
---
M .gitignore
1 file changed, 610 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/98/7198/1
diff --git a/.gitignore b/.g
Review at https://gerrit.osmocom.org/7199
gitignore 'make compile' generated files
Change-Id: I6e4b9b4526d6e0af0f5325e2df97b0ec7c93d9ae
---
M .gitignore
1 file changed, 897 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/99/7199/1
diff -
Review at https://gerrit.osmocom.org/7200
gitignore final 'make' generated files
Change-Id: If38aea67a45b4e5fe22d5fac301f06239e2265a2
---
M .gitignore
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/00/7200/1
diff --gi
Neels Hofmeyr has abandoned this change.
Change subject: .gitignore: aggressively ignore everything
..
Abandoned
the other topic:gitignore patches actually work well for me now, no idea why I
couldn't get symlinks ignored befo
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6665
to look at the new patch set (#4).
implement support for 3-digit MNC with leading zeros
Record the mnc_3_digits flag from SI and pass on via the PCU interface.
Instead of
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/
to look at the new patch set (#3).
implement support for 3-digit MNC with leading zeros
Receive the mnc_3_digits flag from the PCU interface.
Bump the PCU interface to 9.
This is one p
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6669
to look at the new patch set (#8).
pcu_if: implement support for 3-digit MNC
Add the mnc_3_digits member to the info_ind.
Instead of changing to e.g. osmo_plmn_id, add th
Patch Set 4: -Code-Review Verified+1
verified to work on sysmoBTS, accompanied by the osmo-pcu patch
--
To view, visit https://gerrit.osmocom.org/6665
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49cd762c3c9d7ee6a82451bdf3ffa2a0607679
Patch Set 3: -Code-Review Verified+1
verified to work on a sysmoBST, accompanied by osmo-bts and osmo-sgsn patches.
NOTE: In order to get a reliable test environment, I also applied the reverts
as listed in https://osmocom.org/issues/3013#note-2
--
To view, visit https://gerrit.osmocom.org/66
Patch Set 8:
I have verified the pcuif_proto.h changes to work when osmo-bts and osmo-pcu
communicate (on a sysmobts), and this pcuif_proto.h patch matches the bts and
pcu ones exactly.
--
To view, visit https://gerrit.osmocom.org/6669
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/7206
trxcon/scheduler: transmit dummy frames on CBTX lchans
If at the moment of transmission there are no frames in TX buffer,
then either a dummy LAPDm frame (0x01, 0x03, 0x01, 0x2b ...) or a
silence frame (depending on a codec in use) shall be transmitted.
Review at https://gerrit.osmocom.org/7201
trxcon/configure.ac: add --enable-sanitize option
Change-Id: I099de726f9d67213c56d996039b4207f80a727c6
---
M src/host/trxcon/configure.ac
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/change
Review at https://gerrit.osmocom.org/7204
trxcon/sched_trx.h: clarify lchan flags meaning
Change-Id: I51b663dd16e46a4523488c3d3000922a7c3640d1
---
M src/host/trxcon/sched_trx.h
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/04/
Review at https://gerrit.osmocom.org/7205
trxcon/scheduler: introduce a new CBTX lchan flag
This new flag is intended to indicate that continuous burst
transmission is assumed on particular logical channel. In other
words, if a logical channel has this flag, but there is nothing
to transmit in
Review at https://gerrit.osmocom.org/7203
trxcon/sched_trx.c: fix: omit inactive logical channels
The sched_frame_clck_cb() is responsible for UL burst transmission.
Iterating over each timeslot, it chooses a proper lchan handler
according to a current frame number and a multiframe layout in us
Review at https://gerrit.osmocom.org/7202
trxcon/sched_trx.c: fix: properly deallocate lchans
The llist_for_each_entry_safe() should be used instead of the
llist_for_each_entry(), because it's safe against removal
of llist entry.
Found using Valgrind's memcheck tool.
Change-Id: I65234971ec152
73 matches
Mail list logo
