Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7472
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77cd4b9142510c6914298b720d9c19ab68f9ebef
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: trxcon/scheduler: share lchan link identifiers
..
trxcon/scheduler: share lchan link identifiers
Change-Id: Ie1632f274b2ae6147a8e918ebfea60eeeb6a234c
Harald Welte has submitted this change and it was merged.
Change subject: trxcon/sched_prim.c: fix: correct the first padding byte
..
trxcon/sched_prim.c: fix: correct the first padding byte
According to TS 144.006, section
Patch Set 1:
Please look at jolly branches, he had implemented measurement reporting and
handover with real l1 some years back
--
To view, visit https://gerrit.osmocom.org/7470
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7467
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f0304bf84613a2dc07cb78aff0cb8bb4c5adf6c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7469
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fc90d4732433f221c628058c9812815edf9c8cb
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: trxcon/scheduler: add CHAN_IS_SACCH macro
..
trxcon/scheduler: add CHAN_IS_SACCH macro
Change-Id: I2fc90d4732433f221c628058c9812815edf9c8cb
---
M
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7464
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ef24b5b82a5c100e056adadd26e69b968b9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7475
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce78883995e0d484368046b69db5afb2b4adc97
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7473
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I973835c54a90fefe50d2b3581324d12556715f58
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7474
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I763b18d2922701ad97382269747ff0cbb7bd657b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: sip: Add SIP_Emulation and first osmo-sip-connector test case
..
sip: Add SIP_Emulation and first osmo-sip-connector test case
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Emulation: Introduce LastActTable
..
RSL_Emulation: Introduce LastActTable
The LastActTable stores a copy of the decoded RSL CHAN_ACT for
each
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7463
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I629d66e27cbe4c8b02e704a7181b3bff843e9aa4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has abandoned this change.
Change subject: WIP: SIP progress
..
Abandoned
Pushed by accident
--
To view, visit https://gerrit.osmocom.org/7466
To unsubscribe, visit https://gerrit.osmocom.org/settings
Harald Welte has submitted this change and it was merged.
Change subject: bsc: TC_assignment_codec_*: Verify RSL side codec/mode
..
bsc: TC_assignment_codec_*: Verify RSL side codec/mode
Let's not only match if the BSSMAP
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7465
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd47b0d48c609b4a678ea47aa7f89f5c12e6c0d2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7468
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1632f274b2ae6147a8e918ebfea60eeeb6a234c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7458
to look at the new patch set (#2).
gsm_08_08: correct speech codec defaults
The speech codec defaults are not correct. The defaults recommended
in 3GPP TS 28.062, Table 7.11.3.1.3-2
Patch Set 1:
> I'm not sure this is the right solution. The structures we are
> using (like struct gsm0808_speech_codec) are parsed , host data
> structures and not on-wire data structures. So as a user, I would
> expect the bits to be in host byte order. If I want to enable e.g.
> S11,
Review at https://gerrit.osmocom.org/7488
VTY: Don't welcome the user to the "control" interface, if it's VTY
This is quite confusing, I'm surprised that it has not been flagged
before...
Change-Id: I3dc07290579949891e481675d493e5a2ea6d0aed
---
M src/vty/vty.c
1 file changed, 1 insertion(+),
Patch Set 1: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/7489/1/src/mncc.c
File src/mncc.c:
Line 150: /* Send a MNCC_RTP_CONNET to the MSC for the given call legs */
"CONNECT"
Line 463: * \param conn MNCC socket/connection
(I don't mind much, but at some point I think we
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/7462/1/src/input/ipaccess.c
File src/input/ipaccess.c:
Line 197: memcpy(>list, >list,
sizeof(newbfd->list));
why not just
newbfd->list = bdf->list;
--
To view, visit
Patch Set 1: Code-Review+1
(8 comments)
https://gerrit.osmocom.org/#/c/7487/1//COMMIT_MSG
Commit Message:
Line 10: file relase from OCTSDR-2G-02.10.00-B1837-ALPHA as there are
it's almost like "relase" should be an actual word, sounds like "re-heat with a
laser"
Line 22: Patch by Octasic
Review at https://gerrit.osmocom.org/7491
Call the program "OsmoSIPcon" (also in vty)
It's confusing to access the telnet interface and then see a prompt
that's not like the program name
Change-Id: Iba20c1c90e528d08bd362be39d86317569c253e6
---
M src/main.c
M src/vty.c
2 files changed, 2
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7490
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide24feb536c04fe7ef08c62b4498fdd95605b58c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sip-connector
Gerrit-Branch:
Patch Set 1: Code-Review+2
lol
--
To view, visit https://gerrit.osmocom.org/7488
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dc07290579949891e481675d493e5a2ea6d0aed
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch:
Review at https://gerrit.osmocom.org/7490
mncc: use 'const' to denote read-only input buffer/message
We normally use the 'const' modifier whenever using read-only input
data, let's do so in the mncc parser/handler, too.
Change-Id: Ide24feb536c04fe7ef08c62b4498fdd95605b58c
---
M src/mncc.c
1
Review at https://gerrit.osmocom.org/7489
comments
Change-Id: Icf0e9211a4e93eb1b05b5a5d68f9ba766982da8d
---
M src/mncc.c
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector
refs/changes/89/7489/1
diff --git a/src/mncc.c b/src/mncc.c
Patch Set 1:
I'd have thought OsmoSIPconn or strictly OsmoSIPConn (like OsmoGSMTester)
--
To view, visit https://gerrit.osmocom.org/7491
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba20c1c90e528d08bd362be39d86317569c253e6
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7406/2/jobs/gerrit-verifications.yml
File jobs/gerrit-verifications.yml:
Line 192: make deps; make clean; make compile
> Maybe you want to chain them all with && instead of semicolons, to ensure t
I'd argue for
Patch Set 1:
+1 for using osmo_auth_c3() instead of code dup'ing.
SQN: in milenage, we mostly handle it as an integer value in a uint64_t, but
see in milenage_gen_vec(), we use
osmo_store64be_ext(next_sqn, sqn, 6);
Likely this should do the same here.
--
To view, visit
Patch Set 1: Code-Review-1
(1 comment)
approved, except the comment doesn't fit
https://gerrit.osmocom.org/#/c/7428/1/src/osmo-bsc/osmo_bsc_msc.c
File src/osmo-bsc/osmo_bsc_msc.c:
Line 56: * to 1 by default. */
sounds like rather osmo_bsc_filter.c should query the proper places for
Patch Set 4: Code-Review-1
(5 comments)
I wish I had thought of this before I started with the .gitignore patches. I
approve, just some details up for nitpick:
https://gerrit.osmocom.org/#/c/7405/4/bsc/regen_makefile.sh
File bsc/regen_makefile.sh:
Line 14: ln -s build/BSC_Tests ../BSC_Tests
Patch Set 1:
> (5 comments)
>
> And in general, do we have any expected values, that
> could be used to make basic test coverage?
In osmo-hlr, we have some tests based on the TS 55.205 test sets. Maybe you can
find something similar for XOR? (then again, I guess XOR should be rather
Patch Set 2:
ah, here was another patch like this. dexter has since submitted
https://gerrit.osmocom.org/7460 and https://gerrit.osmocom.org/7461 which we
already merged. Those patches were considerably smaller -- are there remaining
changes in here that we should keep?
--
To view, visit
Patch Set 7: Code-Review+1
(2 comments)
I'm not sure I overlook the bigger picture, but do go ahead.
https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_driver/__init__.py
File src/osmo_ms_driver/__init__.py:
Line 5: # Authors: D. Lazlo Sitzer
> That's not how copyright
Patch Set 1:
as discussed in https://gerrit.osmocom.org/6503 I think the proper fix would be
me revisiting the subscr conn fsm and waterproof it against any of these
leakages
--
To view, visit https://gerrit.osmocom.org/7376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7458
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c3a34d39a375d71c4128fd38f06629e8b98b100
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: show failure in gsm0808_enc_cell_id_list2() in gsm0808_test
..
show failure in gsm0808_enc_cell_id_list2() in gsm0808_test
Change-Id:
Review at https://gerrit.osmocom.org/7476
cosmetic: remove dead code
Change-Id: I22f92541982489a0948bd1dedc008439981fb33e
Related: OS#3102
---
D src/osmo-bsc/osmo_bsc_reset.c
1 file changed, 0 insertions(+), 190 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Harald Welte has submitted this change and it was merged.
Change subject: gsm_08_08: correct speech codec defaults
..
gsm_08_08: correct speech codec defaults
The speech codec defaults are not correct. The defaults recommended
Harald Welte has submitted this change and it was merged.
Change subject: gsm0808_test: cosmetic: re-arrange struct init; print hexdump
on failure
..
gsm0808_test: cosmetic: re-arrange struct init; print hexdump on failure
I
cosmetic: remove dead code: osmo_bsc_reset.c
Change-Id: I22f92541982489a0948bd1dedc008439981fb33e
Related: OS#3102
---
D src/osmo-bsc/osmo_bsc_reset.c
1 file changed, 0 insertions(+), 190 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/7476/2
diff --git
Harald Welte has submitted this change and it was merged.
Change subject: gsm0808_test: cosmetic: test non-hex MCC
..
gsm0808_test: cosmetic: test non-hex MCC
The test currently sets the MCC by a hex value, which is a weird
Review at https://gerrit.osmocom.org/7479
contrib: osmo-msc.service: Depend on osmo-mgw.service
Change-Id: Ia50eb02843bf6d145040fbe5032071a3be7b0794
---
M contrib/systemd/osmo-msc.service
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Review at https://gerrit.osmocom.org/7478
contrib: osmo-bsc.service: Fix osmo-mgw.service dependency
Since a while ago, osmo-bsc works only with osmo-mgw.
Change-Id: If95d20db4d379b9632342f7e552237066124ac40
---
M contrib/systemd/osmo-bsc.service
1 file changed, 1 insertion(+), 1 deletion(-)
Review at https://gerrit.osmocom.org/7477
contrib: osmo-bsc.service: Update description
Change-Id: I99d02bd8bd5842580518b34865dd0cbd0433bf27
---
M contrib/systemd/osmo-bsc.service
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7482
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85d8c77589eae511f47b8b9b7439a2c47fe350d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review-1
the fact we're not using this most likely is a sign that we are never
logging/vty-printing an important value that we should
--
To view, visit https://gerrit.osmocom.org/7480
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7481
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbec00ec63950b785dcb71e3b9d70541e70be536
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7483
debian: Move meas related binaries into new package osmo-bsc-meas-utils
Only meas_json is added so far, since the other related ones are
conditionally built.
Change-Id: I35ba3c19fcdfb5663691a67c9876537765963c5d
---
M debian/control
A
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7480
to look at the new patch set (#2).
cosmetic: remove dead code
Patch by Octasic inc.
Change-Id: I40ff0b95349308693bec5f4ae56ec7f2f14202e5
---
M
Patch Set 2:
> the fact we're not using this most likely is a sign that we are
> never logging/vty-printing an important value that we should
It was probably never used. Octasic also removed it from its latest header
release.
--
To view, visit https://gerrit.osmocom.org/7480
To unsubscribe,
Patch Set 1:
I didn't test to build the debian package as I don't have the setup in my
archlinux to do so. If somebody can take the opportunity before merging it
would be great. Also, I'm not sure how to handle the conditionally built
binaries.
--
To view, visit
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/7483
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35ba3c19fcdfb5663691a67c9876537765963c5d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7485
osmo-bsc: Split abisip-find into its own package
Change-Id: I9de9b676502370c2dcd0fb9d54b25884d4110af5
---
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/7484
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dfa9489af56a4c580a63906e950568849333c2b
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch:
Review at https://gerrit.osmocom.org/7486
osmo-bsc: Split meas-utils into its own package
Additionally, libpcap dependency is added to have osmo-meas-pcap2db
available.
Change-Id: Ia6b33dbdf882394fa14270c34306dccf46b724e4
---
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
1 file changed, 8
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/7485
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9de9b676502370c2dcd0fb9d54b25884d4110af5
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch:
Review at https://gerrit.osmocom.org/7484
osmo-bsc: Split bs11-utils into its own package
Change-Id: I9dfa9489af56a4c580a63906e950568849333c2b
---
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/7486
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6b33dbdf882394fa14270c34306dccf46b724e4
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7484
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dfa9489af56a4c580a63906e950568849333c2b
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7485
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9de9b676502370c2dcd0fb9d54b25884d4110af5
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bsc: Split meas-utils into its own package
..
osmo-bsc: Split meas-utils into its own package
Additionally, libpcap dependency is added to have
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7486
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6b33dbdf882394fa14270c34306dccf46b724e4
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bsc: Split bs11-utils into its own package
..
osmo-bsc: Split bs11-utils into its own package
Change-Id: I9dfa9489af56a4c580a63906e950568849333c2b
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bsc: Split abisip-find into its own package
..
osmo-bsc: Split abisip-find into its own package
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove dead code
..
cosmetic: remove dead code
Patch by Octasic inc.
Change-Id: I40ff0b95349308693bec5f4ae56ec7f2f14202e5
---
M
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7480
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40ff0b95349308693bec5f4ae56ec7f2f14202e5
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7482
cosmetic: remove unused variable in osmo-bts-omldummy/main.c
Change-Id: I85d8c77589eae511f47b8b9b7439a2c47fe350d8
---
M src/osmo-bts-omldummy/main.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts
Harald Welte has submitted this change and it was merged.
Change subject: bsc: Fix tons of TTCN3 compiler warnings
..
bsc: Fix tons of TTCN3 compiler warnings
Change-Id: I60dc054d19a249d46d44585c17626746c34f4b09
---
M
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix gsm0808_enc_cell_id_list2 for leading-zero MNC
..
fix gsm0808_enc_cell_id_list2 for leading-zero MNC
Use non-deprecated API to decode encode in
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: remove dead code: osmo_bsc_reset.c
..
cosmetic: remove dead code: osmo_bsc_reset.c
Change-Id: I22f92541982489a0948bd1dedc008439981fb33e
Patch Set 2: Code-Review+2 Verified+1
also setting V+1 because jenkins did succeed, yet it doesn't show as a vote for
some reason.
--
To view, visit https://gerrit.osmocom.org/7476
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: contrib: osmo-bsc.service: Fix osmo-mgw.service dependency
..
contrib: osmo-bsc.service: Fix osmo-mgw.service dependency
Since a while ago, osmo-bsc
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7478
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If95d20db4d379b9632342f7e552237066124ac40
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: contrib: osmo-bsc.service: Update description
..
contrib: osmo-bsc.service: Update description
Change-Id: I99d02bd8bd5842580518b34865dd0cbd0433bf27
---
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7477
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99d02bd8bd5842580518b34865dd0cbd0433bf27
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7479
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50eb02843bf6d145040fbe5032071a3be7b0794
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: contrib: osmo-msc.service: Depend on osmo-mgw.service
..
contrib: osmo-msc.service: Depend on osmo-mgw.service
Change-Id:
Review at https://gerrit.osmocom.org/7481
cosmetic: remove unused variable
Change-Id: Icbec00ec63950b785dcb71e3b9d70541e70be536
---
M src/osmo-bts-octphy/l1_if.c
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/81/7481/1
diff
Review at https://gerrit.osmocom.org/7480
cosmetic: remove dead code
Change-Id: I40ff0b95349308693bec5f4ae56ec7f2f14202e5
---
M src/osmo-bts-octphy/octphy_hw_api.c
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/80/7480/1
diff
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7481
to look at the new patch set (#2).
cosmetic: remove unused variable
Change-Id: Icbec00ec63950b785dcb71e3b9d70541e70be536
---
M src/osmo-bts-octphy/l1_if.c
1 file changed,
Review at https://gerrit.osmocom.org/7487
octphy: integrate octasics latest header release
At the moment osmo-bts does not compile with the latest header
file relase from OCTSDR-2G-02.10.00-B1837-ALPHA as there are
struct members removed and new ones added. The changes do not
affect actual
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7482
to look at the new patch set (#2).
cosmetic: remove unused variable in osmo-bts-omldummy/main.c
Change-Id: I85d8c77589eae511f47b8b9b7439a2c47fe350d8
---
M
Review at https://gerrit.osmocom.org/7492
WIP.. see what is executed? Where is cdf_test
Change-Id: Ib9cd27c9d2628ad1d001ec57f6c80c3690df9a86
---
M selftest/Makefile
M selftest/all_tests.py
2 files changed, 11 insertions(+), 0 deletions(-)
git pull
87 matches
Mail list logo