Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): do not count PCH filling messages

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683 ) Change subject: BTS: fix as_l1_count_paging(): do not count PCH filling messages .. Patch Set 2: Code-Review+1 -- To view,

Change in libosmocore[master]: tests/coding: check return value of encoding / decoding functions

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17670 ) Change subject: tests/coding: check return value of encoding / decoding functions .. Patch Set 2: Code-Review+1 -- To view,

Change in osmo-gsm-tester[master]: srsenb: No need to generates values dict for every template file

2020-03-31 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17686 ) Change subject: srsenb: No need to generates values dict for every template file .. srsenb: No need to generates values dict

Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): do not count PCH filling messages

2020-03-31 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683 to look at the new patch set (#2). Change subject: BTS: fix as_l1_count_paging(): do not count PCH filling messages

Change in osmo-gsm-tester[master]: srsenb: start_locally(): Fix missing class name in attribute access

2020-03-31 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17685 ) Change subject: srsenb: start_locally(): Fix missing class name in attribute access .. srsenb: start_locally(): Fix missing class name

Change in osmo-gsm-tester[master]: srsenb: No need to generates values dict for every template file

2020-03-31 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17686 ) Change subject: srsenb: No need to generates values dict for every template file .. srsenb: No need to generates values dict for every

Change in osmo-gsm-tester[master]: srsenb: No need to generates values dict for every template file

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17686 ) Change subject: srsenb: No need to generates values dict for every template file .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-gsm-tester[master]: Introduce initial Amarisoft ENB support

2020-03-31 Thread srs_andre
srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681 ) Change subject: Introduce initial Amarisoft ENB support .. Patch Set 3: (2 comments) ah, just found that here. I know it

Change in osmo-gsm-tester[master]: iperf3: add modifier to adjust the duration of the iperf run

2020-03-31 Thread srs_andre
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 to look at the new patch set (#5). Change subject: iperf3: add modifier to adjust the duration of the iperf run

Change in osmo-gsm-tester[master]: iperf3: add modifier to adjust the duration of the iperf run

2020-03-31 Thread srs_andre
srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 ) Change subject: iperf3: add modifier to adjust the duration of the iperf run .. Patch Set 4: (1 comment)

Change in libosmocore[master]: coding: fix documentation of PDTCH encoding functions

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17672 ) Change subject: coding: fix documentation of PDTCH encoding functions .. Patch Set 3: Code-Review+1 -- To view, visit

Change in libosmocore[master]: tests/coding: cosmetic: use ARRAY_SIZE() macro from utils.h

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17684 ) Change subject: tests/coding: cosmetic: use ARRAY_SIZE() macro from utils.h .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: srsenb: start_locally(): Fix missing class name in attribute access

2020-03-31 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17685 ) Change subject: srsenb: start_locally(): Fix missing class name in attribute access .. srsenb: start_locally(): Fix missing

Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): do not count PCH filling messages

2020-03-31 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683 ) Change subject: BTS: fix as_l1_count_paging(): do not count PCH filling messages .. BTS: fix as_l1_count_paging(): do not

Change in libosmocore[master]: logging: use LOGL_NOTICE when not loglevel is set

2020-03-31 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when not loglevel is set .. Patch Set 2: (2 comments)

Change in osmo-gsm-tester[master]: srsenb: start_locally(): Fix missing class name in attribute access

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17685 ) Change subject: srsenb: start_locally(): Fix missing class name in attribute access .. Patch Set 1: Code-Review+2 -- To

Change in osmo-gsm-tester[master]: Introduce initial Amarisoft ENB support

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681 ) Change subject: Introduce initial Amarisoft ENB support .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: iperf3: add modifier to adjust the duration of the iperf run

2020-03-31 Thread srs_andre
srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 ) Change subject: iperf3: add modifier to adjust the duration of the iperf run .. Patch Set 3: (4 comments) Below is the

Change in osmo-gsm-tester[master]: srs_{ue, enb}: change UHD stream args and buffer size as function of c...

2020-03-31 Thread srs_andre
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17650 to look at the new patch set (#3). Change subject: srs_{ue,enb}: change UHD stream args and buffer size as function of cell width

Change in osmo-gsm-tester[master]: srs_{ue, enb}: adding modifier to pass arbitrary cmd line arguments

2020-03-31 Thread srs_andre
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17611 to look at the new patch set (#2). Change subject: srs_{ue,enb}: adding modifier to pass arbitrary cmd line arguments

Change in osmo-gsm-tester[master]: srs_{ue, enb}: change UHD stream args and buffer size as function of c...

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17650 ) Change subject: srs_{ue,enb}: change UHD stream args and buffer size as function of cell width .. Patch Set 3: (1 comment)

Change in libosmocore[master]: tests/coding: cosmetic: use ARRAY_SIZE() macro from utils.h

2020-03-31 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17684 ) Change subject: tests/coding: cosmetic: use ARRAY_SIZE() macro from utils.h .. tests/coding: cosmetic: use ARRAY_SIZE() macro

Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): do not count PCH filling messages

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683 ) Change subject: BTS: fix as_l1_count_paging(): do not count PCH filling messages .. Patch Set 1: (1 comment)

Change in libosmocore[master]: coding: fix documentation of PDTCH encoding functions

2020-03-31 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17672 ) Change subject: coding: fix documentation of PDTCH encoding functions .. Patch Set 1: (1 comment)

Change in libosmocore[master]: coding: fix documentation of PDTCH encoding functions

2020-03-31 Thread fixeria
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/17672 to look at the new patch set (#2). Change subject: coding: fix documentation of PDTCH encoding functions

Change in libosmocore[master]: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests

2020-03-31 Thread fixeria
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/17671 to look at the new patch set (#2). Change subject: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests

Change in libosmocore[master]: tests/coding: check return value of encoding / decoding functions

2020-03-31 Thread fixeria
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/17670 to look at the new patch set (#2). Change subject: tests/coding: check return value of encoding / decoding functions

Change in osmo-gsm-tester[master]: {srs, amarisoft}enb:Move shared code to parent generic class eNodeB

2020-03-31 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17688 ) Change subject: {srs,amarisoft}enb:Move shared code to parent generic class eNodeB .. {srs,amarisoft}enb:Move shared code to

Change in libosmocore[master]: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17671 ) Change subject: tests/coding: reduce verbosity of 8-bit / 11-bit RACH coding tests .. Patch Set 2: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): do not count PCH filling messages

2020-03-31 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683 ) Change subject: BTS: fix as_l1_count_paging(): do not count PCH filling messages .. Patch Set 1: (1 comment)

Change in osmo-gsm-tester[master]: srsue: start_locally(): Fix missing class name in attribute access

2020-03-31 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17687 ) Change subject: srsue: start_locally(): Fix missing class name in attribute access .. srsue: start_locally(): Fix missing

Change in osmo-gsm-tester[master]: amarisoft_enb: Drop unused lib variable

2020-03-31 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17689 ) Change subject: amarisoft_enb: Drop unused lib variable .. amarisoft_enb: Drop unused lib variable Change-Id:

Change in osmo-gsm-tester[master]: {srs, amarisoft}enb:Move shared code to parent generic class eNodeB

2020-03-31 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17688 ) Change subject: {srs,amarisoft}enb:Move shared code to parent generic class eNodeB .. {srs,amarisoft}enb:Move shared code to parent

Change in osmo-gsm-tester[master]: amarisoft_enb: Drop unused lib variable

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17689 ) Change subject: amarisoft_enb: Drop unused lib variable .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: srsue: start_locally(): Fix missing class name in attribute access

2020-03-31 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17687 ) Change subject: srsue: start_locally(): Fix missing class name in attribute access .. srsue: start_locally(): Fix missing class name in

Change in osmo-gsm-tester[master]: srsue: start_locally(): Fix missing class name in attribute access

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17687 ) Change subject: srsue: start_locally(): Fix missing class name in attribute access .. Patch Set 1: Code-Review+2 -- To

Change in osmo-gsm-tester[master]: iperf3: add config to adjust the duration of the iperf run

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 ) Change subject: iperf3: add config to adjust the duration of the iperf run .. Patch Set 6: Code-Review-1 (2 comments)

Change in osmo-gsm-tester[master]: srs_{ue, enb}: change UHD stream args and buffer size as function of c...

2020-03-31 Thread srs_andre
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17650 to look at the new patch set (#4). Change subject: srs_{ue,enb}: change UHD stream args and buffer size as function of cell width

Change in osmo-gsm-tester[master]: iperf3: add config to adjust the duration of the iperf run

2020-03-31 Thread srs_andre
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 to look at the new patch set (#6). Change subject: iperf3: add config to adjust the duration of the iperf run

Change in osmo-gsm-tester[master]: srs_{ue, enb}: change UHD stream args and buffer size as function of c...

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17650 ) Change subject: srs_{ue,enb}: change UHD stream args and buffer size as function of cell width .. Patch Set 4: Please also

Change in osmo-gsm-tester[master]: amarisoft_enb: Drop unused lib variable

2020-03-31 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17689 ) Change subject: amarisoft_enb: Drop unused lib variable .. amarisoft_enb: Drop unused lib variable Change-Id:

Change in osmo-gsm-tester[master]: {srs, amarisoft}enb:Move shared code to parent generic class eNodeB

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17688 ) Change subject: {srs,amarisoft}enb:Move shared code to parent generic class eNodeB .. Patch Set 1: Code-Review+2 -- To

Change in osmo-gsm-tester[master]: Introduce support for AmarisoftEPC

2020-03-31 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17690 ) Change subject: Introduce support for AmarisoftEPC .. Introduce support for AmarisoftEPC * A new abstract generic base class

Change in docker-playground[master]: osmo-gsm-tester: Require debian-stretch-jenkins as Dockerfile suggests

2020-03-31 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/17691 ) Change subject: osmo-gsm-tester: Require debian-stretch-jenkins as Dockerfile suggests .. osmo-gsm-tester: Require

Change in libosmocore[master]: tests/coding: add 11-bit Access Burst samples from a real phone

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17692 ) Change subject: tests/coding: add 11-bit Access Burst samples from a real phone .. Patch Set 1: Code-Review+1 (1 comment)

Change in libosmocore[master]: coding: fix bit ordering in 11-bit RACH coding functions

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17693 ) Change subject: coding: fix bit ordering in 11-bit RACH coding functions .. Patch Set 2: Code-Review+1 -- To view, visit

Change in libosmocore[master]: tests/coding: add 11-bit Access Burst samples from a real phone

2020-03-31 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17692 ) Change subject: tests/coding: add 11-bit Access Burst samples from a real phone .. Patch Set 1: (1 comment)

Change in libosmocore[master]: coding: fix bit ordering in 11-bit RACH coding functions

2020-03-31 Thread fixeria
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/17693 to look at the new patch set (#3). Change subject: coding: fix bit ordering in 11-bit RACH coding functions

Change in libosmocore[master]: coding: fix bit ordering in 11-bit RACH coding functions

2020-03-31 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17693 ) Change subject: coding: fix bit ordering in 11-bit RACH coding functions .. Patch Set 3: Code-Review+1 -- To view, visit

Change in libosmocore[master]: coding: fix bit ordering in 11-bit RACH coding functions

2020-03-31 Thread fixeria
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/17693 ) Change subject: coding: fix bit ordering in 11-bit RACH coding functions .. coding: fix bit ordering in 11-bit RACH coding

Change in osmo-bts[master]: l1sap: fix gsmtap_ph_rach(): properly pack 8-bit and 11-bit RA

2020-03-31 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17653 ) Change subject: l1sap: fix gsmtap_ph_rach(): properly pack 8-bit and 11-bit RA .. Patch Set 2: This change is ready for review.

Change in libosmocore[master]: coding: fix bit ordering in 11-bit RACH coding functions

2020-03-31 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17693 ) Change subject: coding: fix bit ordering in 11-bit RACH coding functions .. coding: fix bit ordering in 11-bit RACH coding

Change in libosmocore[master]: tests/coding: add 11-bit Access Burst samples from a real phone

2020-03-31 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17692 ) Change subject: tests/coding: add 11-bit Access Burst samples from a real phone .. tests/coding: add 11-bit Access Burst samples