Change in osmo-bsc[master]: bssap: Handle BSSMAP CONFUSION message.

2020-05-12 Thread ipse
ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18232 ) Change subject: bssap: Handle BSSMAP CONFUSION message. .. bssap: Handle BSSMAP CONFUSION message. We decode the mesage and print it

Change in libosmocore[master]: gsm0808_utils: Fix gsm0808_cause_class() function

2020-05-12 Thread ipse
ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18230 ) Change subject: gsm0808_utils: Fix gsm0808_cause_class() function .. gsm0808_utils: Fix gsm0808_cause_class() function Cause class

Change in libosmocore[master]: gsm0808: Implement helper functions for CONFUSION BSSMAP message deco...

2020-05-12 Thread ipse
ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18231 ) Change subject: gsm0808: Implement helper functions for CONFUSION BSSMAP message decoding. .. gsm0808: Implement helper functions

Change in libosmocore[master]: gsm0808: Make a function to extract Cause IE publicly available.

2020-05-12 Thread ipse
ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18229 ) Change subject: gsm0808: Make a function to extract Cause IE publicly available. .. gsm0808: Make a function to extract Cause IE

Change in osmo-pcu[master]: bts: Drop specific functions to add values to stats

2020-05-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18228 ) Change subject: bts: Drop specific functions to add values to stats .. bts: Drop specific functions to add values to stats

Change in osmo-bsc[master]: bssap: Handle BSSMAP CONFUSION message.

2020-05-12 Thread ipse
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18232 ) Change subject: bssap: Handle BSSMAP CONFUSION message. .. Patch Set 1: I guess this will fail until the libosmocore changes hit the

Change in libosmocore[master]: gsm_04_08.h: fix big endian structs

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18210 ) Change subject: gsm_04_08.h: fix big endian structs .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-12 Thread ipse
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 ) Change subject: stats: Add counters and gauges for BORKEN lchans/TS .. Patch Set 3: Thank you for +2. Please give us another day or

Change in pysim[master]: Add option to specify MNC length in non-batch programming scnearios

2020-05-12 Thread herlesupreeth
herlesupreeth has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/18070 ) Change subject: Add option to specify MNC length in non-batch programming scnearios .. Add option to specify MNC length in non-batch

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-12 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 ) Change subject: stats: Add counters and gauges for BORKEN lchans/TS .. Patch Set 3: (1 comment) (or we can start a contest of

Change in osmo-bsc[master]: VTY: make configurable: X23002, X23005, X23006

2020-05-12 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17973 ) Change subject: VTY: make configurable: X23002, X23005, X23006 .. Patch Set 5: I'd rather pick saner numbers, mentioned in

Change in osmo-ci[master]: osmo-gsm-tester: Point config parameter to file instead of its dirname

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18202 ) Change subject: osmo-gsm-tester: Point config parameter to file instead of its dirname .. osmo-gsm-tester: Point config parameter to file

Change in docker-playground[master]: osmo-gsm-tester: Point config parameter to file instead of its dirname

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18203 ) Change subject: osmo-gsm-tester: Point config parameter to file instead of its dirname .. Patch Set 1: Verified+1

Change in osmo-gsm-tester[master]: Cmdline arg -c sets main configuration file (old paths.conf) instead ...

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18204 ) Change subject: Cmdline arg -c sets main configuration file (old paths.conf) instead of dir containing it .. Cmdline arg -c sets main

Change in osmo-gsm-tester[master]: doc/manuals: Swap order of schemas and config files

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18215 ) Change subject: doc/manuals: Swap order of schemas and config files .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: Cmdline arg -c sets main configuration file (old paths.conf) instead ...

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18204 ) Change subject: Cmdline arg -c sets main configuration file (old paths.conf) instead of dir containing it .. Patch Set 4:

Change in osmo-gsm-tester[master]: doc/manuals: Swap order of schemas and config files

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18215 ) Change subject: doc/manuals: Swap order of schemas and config files .. doc/manuals: Swap order of schemas and config files First

Change in osmo-gsm-tester[master]: Move check_dependencies.py to contrib/

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18216 ) Change subject: Move check_dependencies.py to contrib/ .. Move check_dependencies.py to contrib/ Change-Id:

Change in osmo-ci[master]: osmo-gsm-tester: Point config parameter to file instead of its dirname

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18202 ) Change subject: osmo-gsm-tester: Point config parameter to file instead of its dirname .. Patch Set 1: Verified+1 Code-Review+2 --

Change in osmo-gsm-tester[master]: Move update_version.sh to contrib/

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18217 ) Change subject: Move update_version.sh to contrib/ .. Patch Set 2: Code-Review+2 -- To view, visit

Change in docker-playground[master]: osmo-gsm-tester: Point config parameter to file instead of its dirname

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18203 ) Change subject: osmo-gsm-tester: Point config parameter to file instead of its dirname .. osmo-gsm-tester: Point config parameter to

Change in osmo-gsm-tester[master]: Move check_dependencies.py to contrib/

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18216 ) Change subject: Move check_dependencies.py to contrib/ .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: logging: use LOGL_NOTICE when not loglevel is set

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when not loglevel is set .. Patch Set 6: (2 comments)

Change in libosmocore[master]: logging: use LOGL_NOTICE when no loglevel is set

2020-05-12 Thread dexter
Hello fixeria, pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/17604 to look at the new patch set (#7). Change subject: logging: use LOGL_NOTICE when no loglevel is set

Change in osmo-gsm-tester[master]: Move check_dependencies.py to contrib/

2020-05-12 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18216 to look at the new patch set (#2). Change subject: Move check_dependencies.py to contrib/ ..

Change in osmo-gsm-tester[master]: doc/manuals: Swap order of schemas and config files

2020-05-12 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18215 to look at the new patch set (#2). Change subject: doc/manuals: Swap order of schemas and config files

Change in osmo-gsm-tester[master]: Move update_version.sh to contrib/

2020-05-12 Thread pespin
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18217 ) Change subject: Move update_version.sh to contrib/ .. Move update_version.sh to contrib/ Change-Id:

Change in osmo-gsm-tester[master]: Cmdline arg -c sets main configuration file (old paths.conf) instead ...

2020-05-12 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18204 to look at the new patch set (#4). Change subject: Cmdline arg -c sets main configuration file (old paths.conf) instead of dir containing it

Change in osmo-bts[master]: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers

2020-05-12 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18218 ) Change subject: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers .. osmo-bts-trx/scheduler: remove a left-over from

Change in osmo-gsm-tester[master]: Move update_version.sh to contrib/

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18217 ) Change subject: Move update_version.sh to contrib/ .. Move update_version.sh to contrib/ Change-Id:

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-12 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 ) Change subject: stats: Add counters and gauges for BORKEN lchans/TS .. Patch Set 3: Code-Review-1 (1 comment) I regret keeping the

Change in osmo-gsm-tester[master]: config: Allow setting trial directory in main.conf

2020-05-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18219 ) Change subject: config: Allow setting trial directory in main.conf .. config: Allow setting trial directory in main.conf

Change in osmo-hlr[master]: doc: do not use loglevel info for log category ss

2020-05-12 Thread dexter
Hello fixeria, pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/17600 to look at the new patch set (#4). Change subject: doc: do not use loglevel info for log category ss

Change in osmo-gsm-tester[master]: doc/manuals: Swap order of schemas and config files

2020-05-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18215 ) Change subject: doc/manuals: Swap order of schemas and config files .. doc/manuals: Swap order of schemas and config files

Change in osmo-gsm-tester[master]: Cmdline arg -c sets main configuration file (old paths.conf) instead ...

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18204 ) Change subject: Cmdline arg -c sets main configuration file (old paths.conf) instead of dir containing it .. Patch Set 3:

Change in libosmocore[master]: logging: use LOGL_NOTICE when not loglevel is set

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when not loglevel is set .. Patch Set 6: Code-Review-1 (4 comments)

Change in libosmocore[master]: exec: osmo_system_nowait2: initalize *pw pointer with NULL

2020-05-12 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17884 ) Change subject: exec: osmo_system_nowait2: initalize *pw pointer with NULL .. exec: osmo_system_nowait2: initalize *pw pointer with NULL

Change in libosmocore[master]: logging: use LOGL_NOTICE when not loglevel is set

2020-05-12 Thread dexter
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/17604 to look at the new patch set (#6). Change subject: logging: use LOGL_NOTICE when not loglevel is set

Change in osmo-hlr[master]: doc: do not use loglevel info for log category ss

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/17600 ) Change subject: doc: do not use loglevel info for log category ss .. Patch Set 4: Code-Review+1 -- To view, visit

Change in libosmocore[master]: gsm_04_08.h: fix big endian structs

2020-05-12 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18210 ) Change subject: gsm_04_08.h: fix big endian structs .. gsm_04_08.h: fix big endian structs Affected: - struct gsm48_range_1024 - struct

Change in osmo-pcu[master]: gprs_debug: Use only LOGL_NOTICE as default loglevel

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17609 ) Change subject: gprs_debug: Use only LOGL_NOTICE as default loglevel .. Patch Set 4: Code-Review+1 -- To view, visit

Change in osmo-gsm-tester[master]: Move update_version.sh to contrib/

2020-05-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18217 ) Change subject: Move update_version.sh to contrib/ .. Move update_version.sh to contrib/ Change-Id:

Change in libosmocore[master]: gsm0505_amr_dtx: add missing value strings

2020-05-12 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/17931 to look at the new patch set (#3). Change subject: gsm0505_amr_dtx: add missing value strings ..

Change in osmo-gsm-tester[master]: Move check_dependencies.py to contrib/

2020-05-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18216 ) Change subject: Move check_dependencies.py to contrib/ .. Move check_dependencies.py to contrib/ Change-Id:

Change in osmo-ggsn[master]: debug: use LOGL_NOTICE instead of LOGL_DEBUG

2020-05-12 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17607 ) Change subject: debug: use LOGL_NOTICE instead of LOGL_DEBUG .. debug: use LOGL_NOTICE instead of LOGL_DEBUG In debug.c the log category

Change in osmo-ggsn[master]: debug: use LOGL_NOTICE instead of LOGL_DEBUG

2020-05-12 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17607 ) Change subject: debug: use LOGL_NOTICE instead of LOGL_DEBUG .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: doc: make sure all log categories are set to level notice

2020-05-12 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/17597 ) Change subject: doc: make sure all log categories are set to level notice .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: doc: make sure all log categories are set to level notice

2020-05-12 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/17597 ) Change subject: doc: make sure all log categories are set to level notice .. doc: make sure all log categories are set to level notice

Change in osmo-sgsn[master]: gsup: send RAT type on LU

2020-05-12 Thread neels
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/16745 to look at the new patch set (#3). Change subject: gsup: send RAT type on LU .. gsup: send

Change in osmo-gsm-tester[master]: config: Allow setting trial directory in main.conf

2020-05-12 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18219 to look at the new patch set (#2). Change subject: config: Allow setting trial directory in main.conf

Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_dl_tbf()

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18134 ) Change subject: Expect ms object to exist before calling tbf_alloc_dl_tbf() .. Patch Set 1: Code-Review+2 (3 comments)

Change in libosmocore[master]: logging: use LOGL_NOTICE when no loglevel is set

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when no loglevel is set .. Patch Set 8: Code-Review+2 -- To view, visit

Change in libosmocore[master]: logging: use LOGL_NOTICE when no loglevel is set

2020-05-12 Thread dexter
Hello fixeria, pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/17604 to look at the new patch set (#8). Change subject: logging: use LOGL_NOTICE when no loglevel is set

Change in libosmocore[master]: logging: do not allow multiple calls of log_init()

2020-05-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18222 ) Change subject: logging: do not allow multiple calls of log_init() .. logging: do not allow multiple calls of log_init() calling

Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_ul_tbf()

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18133 ) Change subject: Expect ms object to exist before calling tbf_alloc_ul_tbf() .. Patch Set 1: Code-Review+2 (1 comment) I am

Change in libosmocore[master]: logging: use LOGL_NOTICE when no loglevel is set

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when no loglevel is set .. Patch Set 7: Code-Review+1 (2 comments)

Change in docker-playground[master]: osmo-gsm-tester: Fix typo in path in jenkins.sh

2020-05-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/18220 ) Change subject: osmo-gsm-tester: Fix typo in path in jenkins.sh .. osmo-gsm-tester: Fix typo in path in jenkins.sh

Change in docker-playground[master]: osmo-gsm-tester: Fix typo in path in jenkins.sh

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18220 ) Change subject: osmo-gsm-tester: Fix typo in path in jenkins.sh .. osmo-gsm-tester: Fix typo in path in jenkins.sh Change-Id:

Change in pysim[master]: pySim-prog, pySim-read, do not echo reader id

2020-05-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/18221 ) Change subject: pySim-prog, pySim-read, do not echo reader id .. pySim-prog, pySim-read, do not echo reader id pySim-prog and

Change in libosmocore[master]: logging: use LOGL_NOTICE when no loglevel is set

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when no loglevel is set .. Patch Set 7: Code-Review+1 (1 comment)

Change in osmo-gsm-tester[master]: config: Allow setting trial directory in main.conf

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18219 ) Change subject: config: Allow setting trial directory in main.conf .. config: Allow setting trial directory in main.conf Change-Id:

Change in osmo-gsm-tester[master]: config: Allow setting trial directory in main.conf

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18219 ) Change subject: config: Allow setting trial directory in main.conf .. Patch Set 2: Code-Review+2 -- To view, visit

Change in docker-playground[master]: osmo-gsm-tester: Fix typo in path in jenkins.sh

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18220 ) Change subject: osmo-gsm-tester: Fix typo in path in jenkins.sh .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

Change in libosmocore[master]: logging: do not allow multiple calls of log_init()

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18222 ) Change subject: logging: do not allow multiple calls of log_init() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_dl_tbf()

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18134 ) Change subject: Expect ms object to exist before calling tbf_alloc_dl_tbf() .. Patch Set 1: (2 comments)

Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_ul_tbf()

2020-05-12 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18133 ) Change subject: Expect ms object to exist before calling tbf_alloc_ul_tbf() .. Expect ms object to exist before calling tbf_alloc_ul_tbf()

Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_dl_tbf()

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18134 ) Change subject: Expect ms object to exist before calling tbf_alloc_dl_tbf() .. Patch Set 2: Code-Review+2 REadding +2 after adding

Change in pysim[master]: pySim-prog, pySim-read, do not echo reader id

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18221 ) Change subject: pySim-prog, pySim-read, do not echo reader id .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Drop unneeded arg 'ta' in tbf_alloc_ul()

2020-05-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18224 ) Change subject: Drop unneeded arg 'ta' in tbf_alloc_ul() .. Drop unneeded arg 'ta' in tbf_alloc_ul() The function is simply setting

Change in osmo-pcu[master]: pdch: rcv_resource_request(): Clarify tbf_free only needed if MS used...

2020-05-12 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18223 ) Change subject: pdch: rcv_resource_request(): Clarify tbf_free only needed if MS used to exist beforehand .. pdch:

Change in osmo-bts[master]: measurement: expect at least 1 SUB frame for AMR

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17929 ) Change subject: measurement: expect at least 1 SUB frame for AMR .. Patch Set 5: (1 comment)

Change in osmo-pcu[master]: pdch: rcv_resource_request(): Clarify tbf_free only needed if MS used...

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18223 ) Change subject: pdch: rcv_resource_request(): Clarify tbf_free only needed if MS used to exist beforehand .. Patch Set 1:

Change in osmo-pcu[master]: Drop unneeded arg 'ta' in tbf_alloc_ul()

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18224 ) Change subject: Drop unneeded arg 'ta' in tbf_alloc_ul() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in pysim[master]: cards: reset uninitalized EF.AD

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18206 ) Change subject: cards: reset uninitalized EF.AD .. Patch Set 3: Code-Review+1 (1 comment)

Change in pysim[master]: pysim-prog: move ADM sanitation to utils.py

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18207 ) Change subject: pysim-prog: move ADM sanitation to utils.py .. Patch Set 3: Code-Review+2 -- To view, visit

Change in pysim[master]: cards: remove len calculation

2020-05-12 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/18205 ) Change subject: cards: remove len calculation .. cards: remove len calculation The method update_ad() caluclates the size of the data it had

Change in pysim[master]: utils: do not crash when all bytes of EF.IMSI are 0xFF

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18208 ) Change subject: utils: do not crash when all bytes of EF.IMSI are 0xFF .. Patch Set 3: Code-Review+1 (1 comment)

Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_ul_tbf()

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18133 ) Change subject: Expect ms object to exist before calling tbf_alloc_ul_tbf() .. Patch Set 1: > Patch Set 1: Code-Review+2 > > (1

Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_dl_tbf()

2020-05-12 Thread pespin
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/18134 to look at the new patch set (#2). Change subject: Expect ms object to exist before calling tbf_alloc_dl_tbf()

Change in osmo-bts[master]: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18218 ) Change subject: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers .. Patch Set 1: Code-Review+1 Wait,

Change in osmo-bts[master]: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers

2020-05-12 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18218 ) Change subject: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: cards: remove len calculation

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18205 ) Change subject: cards: remove len calculation .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/17997 ) Change subject: amr: Fix OA<->BWE conversion. .. Patch Set 7: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers

2020-05-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18218 ) Change subject: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers .. Patch Set 1: > Patch Set 1: Code-Review+1 > >

Change in pysim[master]: commands: add method to determine size of a non record oriented file

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18209 ) Change subject: commands: add method to determine size of a non record oriented file .. Patch Set 3: Code-Review+2 -- To view, visit

Change in pysim[master]: commands: add features to verify data written to files

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18211 ) Change subject: commands: add features to verify data written to files .. Patch Set 2: Code-Review+1 -- To view, visit

Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-12 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Treat MCC and MNC as strings, not integers A MNC of 02 and 002 are

Build failure of network:osmocom:nightly/osmo-uecups in Debian_9.0/armv7l

2020-05-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-uecups/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-uecups failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-uecups Last lines of

Change in osmo-bts[master]: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers

2020-05-12 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18218 ) Change subject: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers .. osmo-bts-trx/scheduler: remove a left-over from UL TCH

Change in osmo-bts[master]: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18218 ) Change subject: osmo-bts-trx/scheduler: remove a left-over from UL TCH handlers .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: gsup: send RAT type on LU

2020-05-12 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16745 ) Change subject: gsup: send RAT type on LU .. gsup: send RAT type on LU At 36c3, osmo-hlr was run with a patch that records the RAN type of

Change in osmo-sgsn[master]: gsup: send RAT type on LU

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16745 ) Change subject: gsup: send RAT type on LU .. Patch Set 3: Code-Review+2 -- To view, visit

Change in pysim[master]: pySim-prog, pySim-read, do not echo reader id

2020-05-12 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/18221 ) Change subject: pySim-prog, pySim-read, do not echo reader id .. pySim-prog, pySim-read, do not echo reader id pySim-prog and pySim-read

Change in pysim[master]: pySim-prog, pySim-read, do not echo reader id

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18221 ) Change subject: pySim-prog, pySim-read, do not echo reader id .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: logging: do not allow multiple calls of log_init()

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18222 ) Change subject: logging: do not allow multiple calls of log_init() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: logging: use LOGL_NOTICE when no loglevel is set

2020-05-12 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when no loglevel is set .. logging: use LOGL_NOTICE when no loglevel is set when the API user of

Change in libosmocore[master]: logging: do not allow multiple calls of log_init()

2020-05-12 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18222 ) Change subject: logging: do not allow multiple calls of log_init() .. logging: do not allow multiple calls of log_init() calling

Change in libosmocore[master]: logging: use LOGL_NOTICE when no loglevel is set

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17604 ) Change subject: logging: use LOGL_NOTICE when no loglevel is set .. Patch Set 8: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm0505_amr_dtx: add missing value strings

2020-05-12 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17931 ) Change subject: gsm0505_amr_dtx: add missing value strings .. gsm0505_amr_dtx: add missing value strings The value string array that

Change in libosmocore[master]: gsm0505_amr_dtx: add missing value strings

2020-05-12 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17931 ) Change subject: gsm0505_amr_dtx: add missing value strings .. Patch Set 3: Code-Review+2 -- To view, visit

  1   2   >