Change in libosmo-sccp[master]: comment: explain xua_msg free in m3ua_rx_xfer()
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/9958 ) Change subject: comment: explain xua_msg free in m3ua_rx_xfer() .. comment: explain xua_msg free in m3ua_rx_xfer() Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 --- M src/m3ua.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/m3ua.c b/src/m3ua.c index f1fe3f1..d7ede40 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -584,6 +584,7 @@ xua_msg_free_tag(xua, M3UA_IEI_ROUTE_CTX); return m3ua_hmdc_rx_from_l2(asp->inst, xua); + /* xua will be freed by caller m3ua_rx_msg() */ } static int m3ua_rx_mgmt_err(struct osmo_ss7_asp *asp, struct xua_msg *xua) -- To view, visit https://gerrit.osmocom.org/9958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 Gerrit-Change-Number: 9958 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
Change in libosmo-sccp[master]: comment: explain xua_msg free in m3ua_rx_xfer()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9958 ) Change subject: comment: explain xua_msg free in m3ua_rx_xfer() .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 Gerrit-Change-Number: 9958 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 12 Jul 2018 18:55:00 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmo-sccp[master]: comment: explain xua_msg free in m3ua_rx_xfer()
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9958 to look at the new patch set (#3). Change subject: comment: explain xua_msg free in m3ua_rx_xfer() .. comment: explain xua_msg free in m3ua_rx_xfer() Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 --- M src/m3ua.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/58/9958/3 -- To view, visit https://gerrit.osmocom.org/9958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 Gerrit-Change-Number: 9958 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
Change in libosmo-sccp[master]: comment: explain xua_msg free in m3ua_rx_xfer()
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9958 ) Change subject: comment: explain xua_msg free in m3ua_rx_xfer() .. Patch Set 2: And this particular patch was actually wrong. -- To view, visit https://gerrit.osmocom.org/9958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 Gerrit-Change-Number: 9958 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 11 Jul 2018 14:44:11 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmo-sccp[master]: comment: explain xua_msg free in m3ua_rx_xfer()
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9958 ) Change subject: comment: explain xua_msg free in m3ua_rx_xfer() .. Patch Set 2: re free policy: with struct xua_msg, throughout the code, the function that creates the struct xua_msg also frees it. (with a few exceptions that seem erratic and are being fixed by these patches.) If the lower layers had to free the xua_msg, each and every error handling code path would need an explicit xua_msg_free(). The xua_msg is never enqueued anywhere, it merely exists to pass a message down a code path. -- To view, visit https://gerrit.osmocom.org/9958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 Gerrit-Change-Number: 9958 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 11 Jul 2018 14:43:57 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmo-sccp[master]: comment: explain xua_msg free in m3ua_rx_xfer()
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9958 to look at the new patch set (#2). Change subject: comment: explain xua_msg free in m3ua_rx_xfer() .. comment: explain xua_msg free in m3ua_rx_xfer() Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 --- M src/m3ua.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/58/9958/2 -- To view, visit https://gerrit.osmocom.org/9958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 Gerrit-Change-Number: 9958 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol
