Change in osmo-bsc[master]: add osmo-bsc -X: dump VTY ref XML to stdout

2020-05-21 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/18347 )

Change subject: add osmo-bsc -X: dump VTY ref XML to stdout
..


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18347/4/src/osmo-bsc/osmo_bsc_main.c
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18347/4/src/osmo-bsc/osmo_bsc_main.c@113
PS4, Line 113: -X
Are you sure '-X' is not used anywhere else in osmo-* projects? Maybe 
introducing only the long option ('--vty-ref-xml') would be enough?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
Gerrit-Change-Number: 18347
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 21 May 2020 17:28:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: add osmo-bsc -X: dump VTY ref XML to stdout

2020-05-19 Thread neels 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/18347

to look at the new patch set (#4).

Change subject: add osmo-bsc -X: dump VTY ref XML to stdout
..

add osmo-bsc -X: dump VTY ref XML to stdout

Depends: Ic74bbdb6dc5ea05f03c791cc70184861e39cd492 (libosmocore)
Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/18347/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
Gerrit-Change-Number: 18347
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: add osmo-bsc -X: dump VTY ref XML to stdout

2020-05-19 Thread neels 
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/18347 )

Change subject: add osmo-bsc -X: dump VTY ref XML to stdout
..


Patch Set 3:

(1 comment)

> Patch Set 2:
>
> (1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18347/2/src/osmo-bsc/osmo_bsc_main.c
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18347/2/src/osmo-bsc/osmo_bsc_main.c@866
PS2, Line 866: exit
> The first thing we do after handle_options() is to check the variable set in 
> handle_options, and the […]
indeed much nicer



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
Gerrit-Change-Number: 18347
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Tue, 19 May 2020 20:56:54 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: add osmo-bsc -X: dump VTY ref XML to stdout

2020-05-19 Thread neels 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/18347

to look at the new patch set (#3).

Change subject: add osmo-bsc -X: dump VTY ref XML to stdout
..

add osmo-bsc -X: dump VTY ref XML to stdout

Depends: Ic74bbdb6dc5ea05f03c791cc70184861e39cd492 (libosmocore)
Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/18347/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
Gerrit-Change-Number: 18347
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: add osmo-bsc -X: dump VTY ref XML to stdout

2020-05-19 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/18347 )

Change subject: add osmo-bsc -X: dump VTY ref XML to stdout
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18347/2/src/osmo-bsc/osmo_bsc_main.c
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18347/2/src/osmo-bsc/osmo_bsc_main.c@866
PS2, Line 866: exit
The first thing we do after handle_options() is to check the variable set in 
handle_options, and then call vty_dump_xml_ref(stdout).  So why not simply 
avoid introducing a new global variable and put the vty_dump_xml_ref() call 
inside handle_options?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
Gerrit-Change-Number: 18347
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-Comment-Date: Tue, 19 May 2020 20:30:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bsc[master]: add osmo-bsc -X: dump VTY ref XML to stdout

2020-05-18 Thread neels 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/18347

to look at the new patch set (#2).

Change subject: add osmo-bsc -X: dump VTY ref XML to stdout
..

add osmo-bsc -X: dump VTY ref XML to stdout

This allows generating the XML reference on the fly during build, or to verify
in a verification job that the VTY reference is indeed up-to-date.

Depends: Ic74bbdb6dc5ea05f03c791cc70184861e39cd492 (libosmocore)
Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/18347/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
Gerrit-Change-Number: 18347
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: add osmo-bsc -X: dump VTY ref XML to stdout

2020-05-18 Thread neels 
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/18347 )


Change subject: add osmo-bsc -X: dump VTY ref XML to stdout
..

add osmo-bsc -X: dump VTY ref XML to stdout

Depends: Ic74bbdb6dc5ea05f03c791cc70184861e39cd492 (libosmocore)
Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 12 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/18347/1

diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index ad5a3a9..b2af904 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -84,6 +84,7 @@
 static const char *config_file = "osmo-bsc.cfg";
 static const char *rf_ctrl = NULL;
 static int daemonize = 0;
+static bool vty_ref_xml = false;
 static LLIST_HEAD(access_lists);

 struct llist_head *bsc_access_lists(void)
@@ -110,6 +111,7 @@
printf("  -e --log-level number Set a global loglevel.\n");
printf("  -r --rf-ctl NAME  A unix domain socket to listen 
for cmds.\n");
printf("  -t --testmode A special mode to provoke 
failures at the MSC.\n");
+   printf("  -X --vty-ref-xml  Generate the VTY reference xml 
output and exit.\n");
 }

 static void handle_options(int argc, char **argv)
@@ -128,10 +130,11 @@
{"log-level", 1, 0, 'e'},
{"rf-ctl", 1, 0, 'r'},
{"testmode", 0, 0, 't'},
+   {"vty-ref-xml", 0, 0, 'X'},
{0, 0, 0, 0}
};

-   c = getopt_long(argc, argv, "hd:DsTVc:e:r:t",
+   c = getopt_long(argc, argv, "hd:DsTVc:e:r:tX",
long_options, _index);
if (c == -1)
break;
@@ -166,6 +169,9 @@
case 'r':
rf_ctrl = optarg;
break;
+   case 'X':
+   vty_ref_xml = true;
+   break;
default:
/* ignore */
break;
@@ -855,6 +861,11 @@
/* parse options */
handle_options(argc, argv);

+   if (vty_ref_xml) {
+   vty_dump_xml_ref(stdout);
+   exit(0);
+   }
+
/* seed the PRNG */
srand(time(NULL));


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7
Gerrit-Change-Number: 18347
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange