Change in osmo-gsm-tester[master]: Introduce initial Amarisoft ENB support

2020-03-31 Thread srs_andre
srs_andre has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681 )

Change subject: Introduce initial Amarisoft ENB support
..


Patch Set 3:

(2 comments)

ah, just found that here. I know it has been merged already ;-)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681/2/example/defaults.conf
File example/defaults.conf:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681/2/example/defaults.conf@113
PS2, Line 113:   license_server_addr: 10.12.1.139
not sure if it makes sense to provide a default value here. It's like wrong.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681/2/src/osmo_gsm_tester/amarisoft_enb.py
File src/osmo_gsm_tester/amarisoft_enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681/2/src/osmo_gsm_tester/amarisoft_enb.py@216
PS2, Line 216: def ue_max_rate(self, downlink=True):
seeing that 1:1 again, I think it makes sense to add a eNB base class, a 
Ericsson eNB will have the same max rates.

ah, just saw you added one, so let's move the max_rate() to this class



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I1ddf4962ea6438ad977382ab201b724028ca46b3
Gerrit-Change-Number: 17681
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: srs_andre 
Gerrit-Comment-Date: Tue, 31 Mar 2020 10:06:16 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: Introduce initial Amarisoft ENB support

2020-03-31 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681 )

Change subject: Introduce initial Amarisoft ENB support
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I1ddf4962ea6438ad977382ab201b724028ca46b3
Gerrit-Change-Number: 17681
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 31 Mar 2020 08:22:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: Introduce initial Amarisoft ENB support

2020-03-30 Thread pespin
pespin has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681 )

Change subject: Introduce initial Amarisoft ENB support
..

Introduce initial Amarisoft ENB support

* object class expects the amarisoft software to be placed in directory
  provided by env var AMARISOFT_PATH_ENB. On local runs, it will run the
  software from there. On remote runs it will copy over that directory to
  the slave.
* Configuration provided works with 6 PRBs, but probably won't work for
  other values (yet).
* ZMQ support not yet available, only UHD.

One can select the Amarisoft ENB by declaring it in resources.conf:
"""
- label: AmarisoftENB-B200
  type: amarisoftenb
  rf_dev_type: uhd
  rf_dev_args: 
"type=b200,serial=317B9FE,recv_frame_size=9232,send_frame_size=9232"
  remote_user: jenkins
  addr: 10.12.1.206
"""

And running:
"""
$ export AMARISOFT_PATH_ENB=/path/to/binaries
$ osmo-gsm-tester.py ... -s 
4g:amarisoftenb-rftype@uhd+srsue-rftype@UHD+mod-enb-nprb@6 -t ping
"""

Change-Id: I1ddf4962ea6438ad977382ab201b724028ca46b3
---
M example/defaults.conf
A example/scenarios/amarisoftenb-rftype@.conf
A src/osmo_gsm_tester/amarisoft_enb.py
A src/osmo_gsm_tester/enb.py
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/srs_enb.py
A src/osmo_gsm_tester/templates/amarisoft_drb.cfg.tmpl
A src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
A src/osmo_gsm_tester/templates/amarisoft_rf_driver.cfg.tmpl
A src/osmo_gsm_tester/templates/amarisoft_sib1.asn.tmpl
A src/osmo_gsm_tester/templates/amarisoft_sib23.asn.tmpl
M suites/4g/suite.conf
12 files changed, 1,064 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/81/17681/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17681
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I1ddf4962ea6438ad977382ab201b724028ca46b3
Gerrit-Change-Number: 17681
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-MessageType: newpatchset