Change in osmo-trx[master]: doc: do not set the base-port of the trx
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17595 ) Change subject: doc: do not set the base-port of the trx .. doc: do not set the base-port of the trx In current config files a base port for osmo-trx is set. Lets remove this setting so that compiled-in default (which is the same value) is used. Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4 --- M doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 4 files changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg index e2c67d6..16c68da 100644 --- a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg @@ -12,7 +12,6 @@ trx bind-ip 127.0.0.1 remote-ip 127.0.0.1 - base-port 5700 egprs disable tx-sps 4 rx-sps 4 diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg index e2c67d6..16c68da 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg @@ -12,7 +12,6 @@ trx bind-ip 127.0.0.1 remote-ip 127.0.0.1 - base-port 5700 egprs disable tx-sps 4 rx-sps 4 diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg index 1b15b47..d930da4 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg @@ -12,7 +12,6 @@ trx bind-ip 127.0.0.1 remote-ip 127.0.0.1 - base-port 5700 dev-args addr=192.168.10.2,pa=NONE,pa_power_max_dbm=23,fifo_ctrl_window=0,status_port=12345 egprs disable tx-sps 4 diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg index 7d02506..b851211 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg @@ -12,7 +12,6 @@ trx bind-ip 127.0.0.1 remote-ip 127.0.0.1 - base-port 5700 egprs disable tx-sps 4 rx-sps 4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4 Gerrit-Change-Number: 17595 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-trx[master]: doc: do not set the base-port of the trx
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17595 ) Change subject: doc: do not set the base-port of the trx .. Patch Set 2: Code-Review+2 > Patch Set 1: Code-Review-1 > > I am sorry, but what's the point of this change? I believe the configuration > examples should contain all available options, so there is no need to refer > documentation / source code every time you need to remember position / format > of some option. Look at configuration examples of srsLTE - everything is > listed and documented there, so you don't have to leave your text editor at > all. But this is exactly not how we deal with configuration in osmocom. * we do have compile-time default * even a 'write file' doesn't save all values, only those that differ from default * we do not rely on text editing of config files but have the VTY to interactively change it Yes, this has it's problems and it can be debated. But then please start a related issue or mailing list thread for the discussion, and at the end of that we change all of the codebase. This specific issue is bringing the config file example in-line with the existing practice. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4 Gerrit-Change-Number: 17595 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 27 Mar 2020 09:26:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: do not set the base-port of the trx
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17595 ) Change subject: doc: do not set the base-port of the trx .. Removed Code-Review-1 by fixeria -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4 Gerrit-Change-Number: 17595 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: deleteVote
Change in osmo-trx[master]: doc: do not set the base-port of the trx
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17595 ) Change subject: doc: do not set the base-port of the trx .. Patch Set 1: Code-Review-1 I am sorry, but what's the point of this change? I believe the configuration examples should contain all available options, so there is no need to refer documentation / source code every time you need to remember position / format of some option. Look at configuration examples of srsLTE - everything is listed and documented there, so you don't have to leave your text editor at all. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4 Gerrit-Change-Number: 17595 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 25 Mar 2020 07:46:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: do not set the base-port of the trx
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17595 ) Change subject: doc: do not set the base-port of the trx .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4 Gerrit-Change-Number: 17595 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 24 Mar 2020 22:08:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: do not set the base-port of the trx
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/17595 ) Change subject: doc: do not set the base-port of the trx .. doc: do not set the base-port of the trx In current config files a base port for osmo-trx is set. Lets remove this setting so that compiled-in default (which is the same value) is used. Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4 --- M doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/95/17595/1 diff --git a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg index 58b27fb..6d787f6 100644 --- a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg @@ -12,7 +12,6 @@ trx bind-ip 127.0.0.1 remote-ip 127.0.0.1 - base-port 5700 egprs disable tx-sps 4 rx-sps 4 diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg index 58b27fb..6d787f6 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg @@ -12,7 +12,6 @@ trx bind-ip 127.0.0.1 remote-ip 127.0.0.1 - base-port 5700 egprs disable tx-sps 4 rx-sps 4 diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg index 3a99491..2e45da9 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg @@ -12,7 +12,6 @@ trx bind-ip 127.0.0.1 remote-ip 127.0.0.1 - base-port 5700 dev-args addr=192.168.10.2,pa=NONE,pa_power_max_dbm=23,fifo_ctrl_window=0,status_port=12345 egprs disable tx-sps 4 diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg index a0c5078..e47d183 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg @@ -12,7 +12,6 @@ trx bind-ip 127.0.0.1 remote-ip 127.0.0.1 - base-port 5700 egprs disable tx-sps 4 rx-sps 4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4 Gerrit-Change-Number: 17595 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
