Harald Welte has submitted this change and it was merged.
Change subject: ensure valid primary_pc in osmo_ss7_instance
..
ensure valid primary_pc in osmo_ss7_instance
Initialize osmo_ss7_instance.cfg.primary_pc = OSMO_SS7_PC_IN
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3355
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0f0c89b7335d9da24161bfac8234be214ca00c
Gerrit-PatchSet: 4
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Ge
Patch Set 4:
Now using 0x to mark invalid PC, this commit spread out into three:
adding the invalid value, ensuring set primary_pc, and then adjusting
osmo_sccp_user to use the same invalidity marking.
--
To view, visit https://gerrit.osmocom.org/3355
To unsubscribe, visit https://ger
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3355
to look at the new patch set (#4).
ensure valid primary_pc in osmo_ss7_instance
Initialize osmo_ss7_instance.cfg.primary_pc = OSMO_SS7_PC_INVALID.
Adjust all code paths using primary_pc
Patch Set 3:
It is likely we will at some point have secondary point codes. Hence, I would
prefer to either have a sub-structure that encapsulates the uint32_t and the
valid flag, so that type and related code/functions can be re-used (e.g.
something like is_pc_valid() inline function that the
Review at https://gerrit.osmocom.org/3355
ensure valid primary_pc in osmo_ss7_instance
Add osmo_ss7_instance.cfg.primary_pc_valid flag.
Adjust all code paths setting primary_pc to also set primary_pc_valid.
Adjust all code paths using primary_pc to ensure it is indeed valid.
Rationale:
It loo
