[MERGED] osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Harald Welte has submitted this change and it was merged. Change subject: ensure that acc_ramp_init() is only called once .. ensure that acc_ramp_init() is only called once There are plans to register signal handlers in acc_ram

osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7723 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25bff85d9e5c277da76bffa11d31972e9fdc323 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7723 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25bff85d9e5c277da76bffa11d31972e9fdc323 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/7723/1/src/libbsc/bsc_vty.c File src/libbsc/bsc_vty.c: Line 1918: acc_ramp_init(&bts->acc_ramp, bts); > I agree. It can be left for a later patch, no problem. Line 3278: acc_ramp_enable(&bts->acc_ramp); > I don't under

[PATCH] osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7723 to look at the new patch set (#2). ensure that acc_ramp_init() is only called once There are plans to register signal handlers in acc_ramp_init(). Once w

osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/7723/1/include/osmocom/bsc/acc_ramp.h File include/osmocom/bsc/acc_ramp.h: Line 145: void acc_ramp_disable(struct acc_ramp *acc_ramp); > I think it makes more sense to have it as one function, no need for two: Agreed. See next patch set.

osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Patch Set 1: Code-Review-1 Not a hard -1, but let's wait for answers before merging. -- To view, visit https://gerrit.osmocom.org/7723 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25bff85d9e5c277da76bffa11d31972e9fdc323 Gerrit-PatchS

osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/7723/1/include/osmocom/bsc/acc_ramp.h File include/osmocom/bsc/acc_ramp.h: Line 145: void acc_ramp_disable(struct acc_ramp *acc_ramp); I think it makes more sense to have it as one function, no need for two: acc_ramp_enabled_set(acc_ramp,

osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7723 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25bff85d9e5c277da76bffa11d31972e9fdc323 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

[PATCH] osmo-bsc[master]: ensure that acc_ramp_init() is only called once

Review at https://gerrit.osmocom.org/7723 ensure that acc_ramp_init() is only called once There are plans to register signal handlers in acc_ramp_init(). Once we do that, the acc_ramp_init() function should only be called once to avoid duplicate signal handlers on the handler list. However, th