Harald Welte has submitted this change and it was merged.
Change subject: gscon: fix assignment of signalling channels
..
gscon: fix assignment of signalling channels
On the assignmen of signalling channels, the voice related f
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7838
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I316ebcb1f27b668e17fe48fff028e047aac47f76
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7838
to look at the new patch set (#2).
gscon: fix assignment of signalling channels
On the assignmen of signalling channels, the voice related fields
do not play a role. Howev
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7838/1/src/libbsc/bsc_subscr_conn_fsm.c
File src/libbsc/bsc_subscr_conn_fsm.c:
Line 244: if (!voice) {
I think this is inverted logic here. "voice" parameter should indicate if it
is a voice assingment (true) or not (
Review at https://gerrit.osmocom.org/7838
gscon: fix assignment of signalling channels
On the assignmen of signalling channels, the voice related fields
do not play a role. However the function send_ass_compl() that
generates the assignment complete message is very strict about the
presence of
