Harald Welte has submitted this change and it was merged.
Change subject: msc_vlr_tests: add test_a5_3_not_supported
..
msc_vlr_tests: add test_a5_3_not_supported
See also change-id I72a1dbb30e0a39dbf4b81c7e378d5607b62e10d3 in
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7058
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba56556207cf6e79e6531b0e7dd3eaec28fb5eaa
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7058
to look at the new patch set (#3).
msc_vlr_tests: add test_a5_3_not_supported
See also change-id I72a1dbb30e0a39dbf4b81c7e378d5607b62e10d3 in
osmo-ttcn3-hacks.git, which adds a similar
Patch Set 2:
> if you're testing external protocols, why not use ttcn3?
I answered at length in https://gerrit.osmocom.org/7190 -- the short answer
here is that I wrote this test to analyse the failure, because it was by far
the fastest way for me to find a fix. Now that the test exists, why n
Patch Set 2:
Why are we adding more tests like this with hardcoded byte arrays that no human
will ever understand again while reading the code? What's the rationale? Unit
tests are nice for testing simple functions. But if you're testing external
protocols, why not use ttcn3? It's not a rhetor
Review at https://gerrit.osmocom.org/7058
msc_vlr_tests: add test_a5_3_not_supported
Related: OS#2947
Change-Id: Iba56556207cf6e79e6531b0e7dd3eaec28fb5eaa
---
M tests/msc_vlr/msc_vlr_test_gsm_ciph.c
M tests/msc_vlr/msc_vlr_test_gsm_ciph.err
2 files changed, 152 insertions(+), 0 deletions(-)
