Harald Welte has submitted this change and it was merged.
Change subject: vlr auth: gracefully reject malformed auth response
..
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, ac
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7188
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4179a290069ac61d0662de4ec7ca3edb76988899
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 4:
ok, now we're back to patch set 2, passing a zero res to trigger failure.
--
To view, visit https://gerrit.osmocom.org/7188
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4179a290069ac61d0662de4ec7ca3edb76988899
Gerrit-Patc
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7188
to look at the new patch set (#4).
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, actually feed invalid auth response
data
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7188/3/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
Line 978: return vlr_subscr_rx_auth_fail(conn->vsub, NULL);
> hmm, this is actually meant for the MM Authentication Failure message from
I think zero R
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7188/3/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
Line 978: return vlr_subscr_rx_auth_fail(conn->vsub, NULL);
hmm, this is actually meant for the MM Authentication Failure message from the
MS, which also is capable
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7188
to look at the new patch set (#3).
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, signal auth failure to the VLR in
order to trigger all
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7188
to look at the new patch set (#2).
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, actually feed invalid auth response
data to vlr_subscr
Review at https://gerrit.osmocom.org/7188
vlr auth: gracefully reject malformed auth response
Instead of just closing down the conn hard, actually feed invalid auth response
data to vlr_subscr_rc_auth_resp() in order to trigger all the actions we want
to see with a failed authentication:
- a GS
