Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6105
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0bef691e17e4331c7c4b491661e36173d85388a
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Use explicit type for pcu_lsb()
..
Use explicit type for pcu_lsb()
It's only used for byte-long input so we can specify input and output
types explicitly
Patch Set 3:
The sister function pcu_bitcount() is used on wider types (e.g. see
find_multi_slots() which uses it with unsigned int).
I think from an API point of view it makes more sense to keep both functions
consistent.
Is the goal to get rid of templates? In that case, why not use uint32_
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6105
to look at the new patch set (#2).
Use explicit type for pcu_lsb()
It's only used for byte-long input so we can specify input and output
types explicitly.
Change-Id: Id0bef691e17e4331c
Review at https://gerrit.osmocom.org/6105
Use explicit type for pcu_lsb()
It#s only used for byte-long input su we can specify input and output
types explicitly.
Change-Id: Id0bef691e17e4331c7c4b491661e36173d85388a
---
M src/pcu_utils.h
1 file changed, 1 insertion(+), 2 deletions(-)
git pu
