Re: [GHC DevOps Group] The future of Phabricator

2018-11-01 Thread Ben Gamari
Carter Schonwald writes: > For what it’s worth, I’ve never found phab / arc to be the bottle neck / > actual time consuming piece of doing anything for ghc > > It’s defintely the nicest code review substrate I’ve engaged with > > One question I have : how does the llvm org manage / handle their

Re: [GHC DevOps Group] The future of Phabricator

2018-11-01 Thread Carter Schonwald
For what it’s worth, I’ve never found phab / arc to be the bottle neck / actual time consuming piece of doing anything for ghc It’s defintely the nicest code review substrate I’ve engaged with One question I have : how does the llvm org manage / handle their phabricator instance and or ci

Re: [GHC DevOps Group] The future of Phabricator

2018-11-01 Thread Vladislav Zavialov
To put my 2¢ – I will be happy with whatever service provides the most reliable CI. In terms of workflow, I like Ben's suggestion: * Consider a PR to be a stack of differentials, with each commit being an atomic change in that stack. ___ ghc-devs

Re: [GHC DevOps Group] The future of Phabricator

2018-11-01 Thread Ben Gamari
Michal Terepeta writes: > Hope you don't mind if I add an opinion of a small/occasional > contributor to the thread. > > Personally, I would prefer a move to GitHub. Mostly due to familiarity > and network effect (pretty much everyone is on GitHub). > > But I would also consider a move to GitLab

Re: [GHC DevOps Group] The future of Phabricator

2018-11-01 Thread Ben Gamari
"Boespflug, Mathieu" writes: > Hi Ben, > > On Tue, 30 Oct 2018 at 18:47, Ben Gamari wrote: ... > > The important things are: reducing the maintenance burden (by > preferring hosted solutions) while still meeting developer > requirements and supporting a workflow that is familiar to most. >

RE: Hadrian build failed

2018-11-01 Thread Andrey Mokhov
Hello Yotam, Could you please report this as a bug on GHC Trac? https://ghc.haskell.org/trac/ghc/wiki/ReportABug I couldn’t quickly reproduce your issue, however, I run into another seemingly unrelated problem. P.S.: Note that build instructions in my blog post got slightly out of date after

Hadrian build failed

2018-11-01 Thread Yotam Ohad
Hi, I'm trying to build with hadrian ( https://blogs.ncl.ac.uk/andreymokhov/building-ghc-on-windows/) I get an error when running: stack exec hadrian -- --directory ".." -j --flavour=quickest --configure md5sum: 'standard input': no properly formatted MD5 checksum lines found ERROR:

Re: [GHC DevOps Group] The future of Phabricator

2018-11-01 Thread Michal Terepeta
Hope you don't mind if I add an opinion of a small/occasional contributor to the thread. Personally, I would prefer a move to GitHub. Mostly due to familiarity and network effect (pretty much everyone is on GitHub). But I would also consider a move to GitLab a big improvement over the current

Re: Validating with LLVM

2018-11-01 Thread Ben Gamari
Travis Whitaker writes: > Hello GHC Devs, > > I'm working on a very tiny patch for GHC. The patch concerns the LLVM code > generator, and I'd like to run the validate script. ./validate ignores mk/ > build.mk (which is probably correct) and it doesn't seem to be using the > LLVM backend. LLVM