Re: Marge has been stabilised

2019-02-13 Thread Matthew Pickering
Yes you have to literally edit the string. I know this is very confusing but many things about gitlab can't be explained with normal logic. Cheers, Matt On Wed, Feb 13, 2019 at 4:03 PM Simon Peyton Jones wrote: > > | As far as I can work out the WIP field is a part of the semantic model > |

RE: Marge has been stabilised

2019-02-13 Thread Simon Peyton Jones via ghc-devs
| As far as I can work out the WIP field is a part of the semantic model | but the only way it displays on the UI is in the title. If you want to change the status using the UI (not via a "quick action") do you literally edit the title? That is, the semantics is driven from the title string

Re: TTG: Handling Source Locations

2019-02-13 Thread Shayan Najd
* "About the latter, until #15247 is fixed" ---> "About the latter, until #15884 is fixed" On Wed, 13 Feb 2019 at 14:00, Shayan Najd wrote: > > >is there any plan to get rid of all those panics? > > There are two sorts of panics related to TTG: the ones due to #15247 > (i.e. unused extension

Re: TTG: Handling Source Locations

2019-02-13 Thread Shayan Najd
>is there any plan to get rid of all those panics? There are two sorts of panics related to TTG: the ones due to #15247 (i.e. unused extension constructors), and the ones due to #15884 (i.e. issues with view patterns). About the former, I believe we all agree. Moreover, using Solution A

Re: TTG: Handling Source Locations

2019-02-13 Thread Ryan Scott
Yes, I agree. This will require sprinkling the codebase with EmptyCase due to [1], but that's still a sight better than calling `panic`. After GHC 8.10 is released (and the minimum version of GHC that HEAD supports is 8.8), we can even remove these empty cases by making the empty data type fields

Re: TTG: Handling Source Locations

2019-02-13 Thread Ryan Scott
> Yes, I have reported it while back. I don't know of the progress in fixing this. Reported what? #15884? [1] You do realize that there is a very simple workaround for that issue, right? Instead of writing this, which is subject to the pattern-guard completeness issues observed in #15753: f

Re: Marge has been stabilised

2019-02-13 Thread Matthew Pickering
As far as I can work out the WIP field is a part of the semantic model but the only way it displays on the UI is in the title. Two other facets of the WIP state are: 1. WIP MRs can't be merged via the UI. (Marge also honours this) 2. The list of MRs can be filtered by the WIP status (which is