Re: [Gimp-developer] preview update problems

2007-01-09 Thread David Hodson
Sven Neumann wrote: You need to move the call to gimp_drawable_preview_draw_region() into the pixel region processing loop. This is because gimp_pixel_rgns_process() modifies the pixel regions it works on. The processed data is also already sent to the core when you are done with processing.

[Gimp-developer] HSL patch

2007-01-09 Thread Robert L Krawitz
Unfortunately, there's a little bug in the HSL compose patch, in gimp_hsl_to_rgb4 in the case of zero saturation. This fixes that. I'd like to have an option to use luminosity rather than value in curves and layers; I'm not sure how to do it without introducing additional complexity. ---

Re: [Gimp-developer] HSL patch

2007-01-09 Thread Sven Neumann
Hi, can you explain to me why your patch introduces new functions in libgimpcolor? Couldn't you just use the existing gimp_rgb_to_hsl() and gimp_hsl_to_rgb()? Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU