[Gimp-developer] Fixes for memory leaks

2009-11-17 Thread Nelson A. de Oliveira
Hi! While giving a look at bug #595605 (from Gimp Bugzilla), I have remembered about cppcheck. I have created a patch available at http://people.debian.org/~naoliv/misc/gimp-mememleak.diff fixing (I hope) some leakages inside the plug-ins dir. Can somebody review it, please? There are some

[Gimp-developer] Scope of variables

2009-11-17 Thread Nelson A. de Oliveira
Hi! Is it interesting to limit the scope of the variables to where they are only used? For example, i is not used inside only one if here in app/core/gimpimage-convert.c (and thus has been moved to where it's only necessary): --- app/core/gimpimage-convert.c.old2009-11-18 00:18:55.0

Re: [Gimp-developer] Scope of variables

2009-11-17 Thread Nelson A. de Oliveira
Hi again! On Wed, Nov 18, 2009 at 12:23 AM, Nelson A. de Oliveira nao...@gmail.com wrote: For example, i is not used inside only one if here in app/core/gimpimage-convert.c (and thus has been moved to where it's only necessary): I need to sleep. Read it as: For example, i is used inside only