Re: [Gimp-developer] scanfs without field width limits making Gimp crash

2011-01-24 Thread Simon Budig
Nelson A. de Oliveira (nao...@gmail.com) wrote: While testing gimp with cppcheck I saw a lot of warnings caused by the usage of scanf and fscanf without specifying a width limit. For Gimp itself there is a bug report on this issue at https://bugzilla.gnome.org/show_bug.cgi?id=639203 I guess

Re: [Gimp-developer] scanfs without field width limits making Gimp crash

2011-01-24 Thread jcupitt
On 24 January 2011 03:30, Christopher Curtis ccurt...@gmail.com wrote: If I add another '0' to the perl line I get a seg fault as well.  Must be a not-quite 64-bit limit. Off-topic, but could someone explain why this isn't a stdio bug? Or is it a known bug and this is the accepted workaround?

Re: [Gimp-developer] scanfs without field width limits making Gimp crash

2011-01-24 Thread Nelson A. de Oliveira
Hi! On Mon, Jan 24, 2011 at 8:26 AM, Simon Budig si...@budig.de wrote: For Gimp itself there is a bug report on this issue at https://bugzilla.gnome.org/show_bug.cgi?id=639203 I guess I'll commit the patch attached to the bugreport soon unless someone has a better suggestion. But here, for

Re: [Gimp-developer] scanfs without field width limits making Gimp crash

2011-01-24 Thread Simon Budig
Nelson A. de Oliveira (nao...@gmail.com) wrote: On Mon, Jan 24, 2011 at 8:26 AM, Simon Budig si...@budig.de wrote: For Gimp itself there is a bug report on this issue at https://bugzilla.gnome.org/show_bug.cgi?id=639203 I guess I'll commit the patch attached to the bugreport soon unless

Re: [Gimp-developer] scanfs without field width limits making Gimp crash

2011-01-24 Thread Nelson A. de Oliveira
Hi! On Mon, Jan 24, 2011 at 9:41 AM, Simon Budig si...@budig.de wrote: Ah sorry, should have mentioned that. The bug report is older than your mail to the list. We had a report on the %s conversion earlier which is what the patch attached to the bug attempts to fix. Here (also from your

Re: [Gimp-developer] scanfs without field width limits making Gimp crash

2011-01-24 Thread Christopher Curtis
On Mon, Jan 24, 2011 at 8:09 AM, Nelson A. de Oliveira nao...@gmail.com wrote: Here (also from your patch): snprintf (fmt_str, sizeof (fmt_str), %%%lds %%%lds %%%lds %%%lds,          sizeof (colorstr_r) - 1, sizeof (colorstr_g) - 1,          sizeof (colorstr_b) - 1, sizeof (colorstr_a) - 1);

Re: [Gimp-developer] Scale bars in 2.7

2011-01-24 Thread Cedric Sodhi
Hi, I think this is already being adressed for 2.8. You are not the only one who is bothered by this. Basing the rate of change upon the current zoom is a very good idea! It would definitly make sense to have the slider automatically cover a range between 1px and

[Gimp-developer] [PATCH] gimpcairo-utils.h missing parens around some macro arguments

2011-01-24 Thread Omari Stephens
The subject and patch are pretty self-explanatory. Ran into this while trying to do pointer arithmetic with these macros. --xsdg From 0ba4f676e3de80233b7ab184b11e527b61ab6158 Mon Sep 17 00:00:00 2001 From: Omari Stephens x...@xsdg.org Date: Mon, 24 Jan 2011 18:49:08 + Subject: [PATCH] Add

Re: [Gimp-developer] [PATCH] gimpcairo-utils.h missing parens around some macro arguments

2011-01-24 Thread Michael Natterer
On Mon, 2011-01-24 at 19:00 +, Omari Stephens wrote: The subject and patch are pretty self-explanatory. Ran into this while trying to do pointer arithmetic with these macros. Thanks, fix pushed. --mitch ___ Gimp-developer mailing list

[Gimp-developer] GSoC 2011 announced

2011-01-24 Thread Alexandre Prokoudine
Hello, teams :) Google has just announced GSoC2011. http://google-opensource.blogspot.com/2011/01/google-summer-of-code-announced-at-lca.html The timeline is here: http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/timeline /crossposting-is-evil Alexandre Prokoudine