Re: [Gimp-developer] [PATCH] Fix deprecated usage of gimp-free-select

Hi Martin! On Tue, Aug 23, 2011 at 1:44 AM, Martin Nordholts ense...@gmail.com wrote: There is already a patch that does this that no one have had time yet (due to priorities) to commit: https://bugzilla.gnome.org/show_bug.cgi?id=647834 Hummm... Next time I need to give a better look at the

[Gimp-developer] [PATCH] Fix deprecated usage of gimp-free-select

Hi! Can somebody review and commit it, please? http://people.debian.org/~naoliv/misc/0001-Fix-deprecated-usage-of-gimp-free-select.txt Thank you! Best regards, Nelson ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU

Re: [Gimp-developer] [PATCH] Fix some memleaks

Hi! On Wed, Aug 17, 2011 at 1:43 PM, Kevin Cozens ke...@ve3syb.ca wrote: After you make the above mentioned changes, send a link to the updated patch file. Updated patch available at http://people.debian.org/~naoliv/misc/0001-Fix-some-memleaks-2.txt Thank you! Best regards, Nelson

[Gimp-developer] [PATCH] Fix some errors and usage of deprecated procedures

procedures). Thank you! Best regards, Nelson From 957448bd30ca612b0a291aec722576ac363105f7 Mon Sep 17 00:00:00 2001 From: Nelson A. de Oliveira nao...@debian.org Date: Tue, 22 Feb 2011 08:42:18 -0300 Subject: [PATCH] Fix some errors and usage of deprecated procedures --- plug-ins/script-fu/scripts

Re: [Gimp-developer] [PATCH] Fix some errors and usage of deprecated procedures

Hi! On Tue, Feb 22, 2011 at 12:25 PM, Carol Spears ca...@gimp.org wrote: circuit.scm was repaired very recently (38 hours ago) in GIMP's git tree: http://git.gnome.org/browse/gimp/commit/?id=b19645db4954a8fc8db83817dc7cd2e45e840efb along with a few others. I saw it! :-) My patch only

[Gimp-developer] Wrong tools contour

Hi! I don't know if it's a know issue, but it seems that the contour from pencil, paintbrush and rubber are being wrongly drawn on the screen (using latest git version). A video is available at http://sites.google.com/site/naoliv/gimp demonstrating this issue. See that when using the pencil, the

[Gimp-developer] Icon for dynamics

Hi! I don't know if it's related to the GTK theme or something else, but having a button with ? on it, to choose the dynamics mode is somehow strange (see http://sites.google.com/site/naoliv/gimp/1.png). It looks something like a help button. If we look at the mode for pencil, for example

[Gimp-developer] Square brushes

And hi one more time! Couldn't we have a square (and square fuzzy) brush by default on Gimp or it's out of the scope/vision/something else of the product? Thanks again! Best regards, Nelson ___ Gimp-developer mailing list

Re: [Gimp-developer] Wrong tools contour

On Thu, Feb 3, 2011 at 2:32 PM, Alexia Death alexiade...@gmail.com wrote: On Thu, Feb 3, 2011 at 2:50 PM, Nelson A. de Oliveira nao...@gmail.com wrote: I don't know if it's a know issue, Im sorry, but I find this question a bit annoying. It's a big issue smack in the middle where you cant

Re: [Gimp-developer] scanfs without field width limits making Gimp crash

Hi! On Mon, Jan 24, 2011 at 8:26 AM, Simon Budig si...@budig.de wrote: For Gimp itself there is a bug report on this issue at https://bugzilla.gnome.org/show_bug.cgi?id=639203 I guess I'll commit the patch attached to the bugreport soon unless someone has a better suggestion. But here, for

Re: [Gimp-developer] scanfs without field width limits making Gimp crash

Hi! On Mon, Jan 24, 2011 at 9:41 AM, Simon Budig si...@budig.de wrote: Ah sorry, should have mentioned that. The bug report is older than your mail to the list. We had a report on the %s conversion earlier which is what the patch attached to the bug attempts to fix. Here (also from your

Re: [Gimp-developer] scanfs without field width limits making Gimp crash

Hi! On Mon, Jan 24, 2011 at 1:11 AM, Christopher Curtis ccurt...@gmail.com wrote: On Sat, Jan 22, 2011 at 2:04 AM, Nelson A. de Oliveira nao...@gmail.com wrote: To make it crash: perl -e 'print 5x210' | ./a.out I believe the unbounded '%s' is a legitimate bug, but is the '%i

[Gimp-developer] scanfs without field width limits making Gimp crash

Hi! While testing gimp with cppcheck I saw a lot of warnings caused by the usage of scanf and fscanf without specifying a width limit. One example: = [./app/gegl/gimpcurvesconfig.c:392]: (warning) scanf without field width limits can crash with huge input data. To fix this error message

[Gimp-developer] [PATCH] Fix for memory and file descriptor leaks

Hi! Can somebody review two patches that (hopefully) fix some memory and file descriptor leaks, please? The first one is basically g_free()s and fclose()s: http://people.debian.org/~naoliv/misc/gimp/patches/0001-Fix-memory-and-descriptor-leaks.patch For the second one, instead including a

Re: [Gimp-developer] GIMP 2.8 schedule

Hi! Can donations (money) to GIMP somehow speed up its development, please? Thank you! Best regards, Nelson ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: [Gimp-developer] Fixes for memory leaks

Hi! On Wed, Nov 18, 2009 at 4:23 AM, Martin Nordholts ense...@gmail.com wrote: Please generate the patch as a commit according to these instructions: http://gimp.org/bugs/howtos/submit-patch.html Patch available at http://people.debian.org/~naoliv/misc/0001-Fix-memleaks-in-plug-ins.patch A

Re: [Gimp-developer] Fixes for memory leaks

Hi again! I gave another look on the possible mem leaks and created another patch: http://people.debian.org/~naoliv/misc/0001-Fix-memory-leakages.patch Can somebody review them, please? There is both http://people.debian.org/~naoliv/misc/0001-Fix-memleaks-in-plug-ins.patch

[Gimp-developer] Fixes for memory leaks

Hi! While giving a look at bug #595605 (from Gimp Bugzilla), I have remembered about cppcheck. I have created a patch available at http://people.debian.org/~naoliv/misc/gimp-mememleak.diff fixing (I hope) some leakages inside the plug-ins dir. Can somebody review it, please? There are some

[Gimp-developer] Scope of variables

Hi! Is it interesting to limit the scope of the variables to where they are only used? For example, i is not used inside only one if here in app/core/gimpimage-convert.c (and thus has been moved to where it's only necessary): --- app/core/gimpimage-convert.c.old2009-11-18 00:18:55.0

Re: [Gimp-developer] Scope of variables

Hi again! On Wed, Nov 18, 2009 at 12:23 AM, Nelson A. de Oliveira nao...@gmail.com wrote: For example, i is not used inside only one if here in app/core/gimpimage-convert.c (and thus has been moved to where it's only necessary): I need to sleep. Read it as: For example, i is used inside only

Re: [Gimp-developer] Improved brush editing interface mock-up

Hi! On Sat, Jul 25, 2009 at 8:19 AM, SHIRAKAWA Akirashirakawa.ak...@gmail.com wrote: New interface and improvements mock-up link: http://i31.tinypic.com/2qjd55k.png This is something that I, as an user, would like to have. It also seems to save some screen space when editing on a notebook that

[Gimp-developer] RFC and some doubts about crop guide overlays

Hi! I would like to have some comments/suggestions/criticisms/etc about the quality and the implementation of the following crop guide overlays. This is related with http://bugzilla.gnome.org/show_bug.cgi?id=575911 Please, consider them as proof of concept; also, I am only including the relevant