Re: [Gimp-developer] layer modes - open questions

[David Gowers]

On Mon, Aug 16, 2010 at 4:46 AM, Rupert Weber  wrote:
> There are still some issues that I either blissfully ignored or took the
> least-cost route on:

> (3) paint-funcs layer modes
> Is the layer mode code in app/paint-funcs ever used?

grepping the entire codebase only lists paint-funcs.c as a user of
dissolve_pixels() and of layer_*_mode() [therefore *_pixels() are
dependencies too]

AFAICS the code in paint_funcs.c which depends on the layer-modes.c
code is used indirectly by:
 * the merge-down code [app/core/gimpimage-merge.c]
 * the projection code [app/core/gimplayer-project.c]
 * the fade code [app/core/gimpdrawable-combine.c]
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

[Gimp-developer] layer modes - open questions

[Rupert Weber]

There are still some issues that I either blissfully ignored or took the 
least-cost route on:

(1) enums and gimp-composite
While the values of legacy layer mode enums are preserved, 
gimp-composite.h has its own GIMP_COMPOSITE_* enums which append some 
modes to the layer mode list. (GIMP_COMPOSITE_BLEND, _SHADE, _SWAP,...).

Those additional enums have their values changed. Is that a problem? (I 
can't even find any place they are used)

(2) file import/export
For import of psp, psd and xjt I simply assumed the new modes would be 
more appropriate than the old ones.
For exporting, I just mapped the new modes along with the old ones.
But I don't know what would be correct for those file formats/programs.

(3) paint-funcs layer modes
Is the layer mode code in app/paint-funcs ever used? If so, the code 
would have to be amended accordingly. Right now, I just mapped the new 
modes to the old functions.

I think that's about it.

Regards

Rupert
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer