Re: incorrect mask handling in histogram calculation

2001-02-05 Thread Jay Cox
Roel Schroeven wrote: Austin Donnelly wrote: So, fixing this bug means that the Levels tool, the Threshold tool, and the Equalise tool will all also change their behaviour: currently they use a histogram of the entire layer, but restrict their changes to the current selection.

Re: incorrect mask handling in histogram calculation

2001-02-03 Thread Austin Donnelly
On Saturday, 3 Feb 2001, Roel Schroeven wrote: In gimphistogram.c there is a function to calculate the histogram for a subregion, declared as follows: gimp_histogram_calculate_sub_region (GimpHistogram *histogram, PixelRegion *region, PixelRegion

Re: incorrect mask handling in histogram calculation

2001-02-03 Thread Roel Schroeven
Austin Donnelly wrote: So, fixing this bug means that the Levels tool, the Threshold tool, and the Equalise tool will all also change their behaviour: currently they use a histogram of the entire layer, but restrict their changes to the current selection. Fixing the bug means that the

incorrect mask handling in histogram calculation

2001-02-02 Thread Roel Schroeven
I just downloaded (and installed and build) the 1.2.1. sources, and I was looking at the histogram code (because I wonder why the histogram always looks totally different than histograms from Photoshop or Paint Shop Pro) and I saw something (unrelated to what I was doing) that looks like a