Re: [Gimp-developer] refactor palette loading code

2013-09-20 Thread Warren Turkal
Thanks for letting me know. wt On Sep 17, 2013 4:44 PM, Michael Henning dra...@darkrefraction.com wrote: wt: Your new patch looks good, so I committed it. Thanks! As a side note, I modified the message slightly. We normally include the general area of the commit (often the top level

Re: [Gimp-developer] refactor palette loading code

2013-09-17 Thread Michael Henning
wt: Your new patch looks good, so I committed it. Thanks! As a side note, I modified the message slightly. We normally include the general area of the commit (often the top level directory) as a prefix to the commit message. Also, I removed the signed off by line because we don't really use that.

Re: [Gimp-developer] refactor palette loading code

2013-09-16 Thread Warren Turkal
I am willing to do whatever is needed to contribute. However, it would be nice if the mailing list wouldn't block patches. Has anyone taken a look at maybe using gerrit? It's actually a pretty reasonable way to handle code changes when using git. It has a pretty nice code review workflow.

Re: [Gimp-developer] refactor palette loading code

2013-09-16 Thread Michael Schumacher
Gesendet: Montag, 16. September 2013 um 09:34 Uhr Von: Warren Turkal w...@penguintechs.org I am willing to do whatever is needed to contribute. However, it would be nice if the mailing list wouldn't block patches. Please keep in mind that those file would be sent out to every subscriber of

Re: [Gimp-developer] refactor palette loading code

2013-09-15 Thread Warren Turkal
Sorry for taking so long to respond. I don't have a lot of time during normal work days to work on this. :) On Tue, Sep 10, 2013 at 6:10 PM, Michael Henning dra...@darkrefraction.comwrote: I made a few minor nitpicks on your commit on github. If you would fix those points, I'll commit your

Re: [Gimp-developer] refactor palette loading code

2013-09-15 Thread Warren Turkal
On Tue, Sep 10, 2013 at 6:54 PM, Jehan Pagès jehan.marmott...@gmail.comwrote: On Wed, Sep 11, 2013 at 1:10 PM, Michael Henning dra...@darkrefraction.com wrote: As a side note for the future, the fastest way to get a patch reviewed is normally if you post it to a pastebin and bother people

Re: [Gimp-developer] refactor palette loading code

2013-09-15 Thread Jehan Pagès
Hi, On Sun, Sep 15, 2013 at 8:32 PM, Warren Turkal w...@penguintechs.org wrote: On Tue, Sep 10, 2013 at 6:54 PM, Jehan Pagès jehan.marmott...@gmail.com wrote: On Wed, Sep 11, 2013 at 1:10 PM, Michael Henning dra...@darkrefraction.com wrote: As a side note for the future, the fastest way to

Re: [Gimp-developer] refactor palette loading code

2013-09-10 Thread Jehan Pagès
Hi, On Wed, Sep 11, 2013 at 1:10 PM, Michael Henning dra...@darkrefraction.com wrote: I made a few minor nitpicks on your commit on github. If you would fix those points, I'll commit your code to master. ok cool, someone reviewed the patch before me. :-D As a side note for the future, the

[Gimp-developer] refactor palette loading code

2013-09-08 Thread Warren Turkal
Hi again, Here's a linkhttps://github.com/wt/gimp/commit/d1e8c4c8543b18c6f5d95f6ab6b3bbbf8f80778bto a commit containing a refactor of the palette loading code. I have moved the file open/close logic to common code. This change actually removes more code than it adds. Here's a interesting

Re: [Gimp-developer] refactor palette loading code

2013-09-08 Thread Warren Turkal
Hey, I will get the format-patch as soon as I can. However, if you want to do it the git way and get it sooner, you can always add my remote to your git with the following command: git remote add wt g...@github.com:wt/gimp.git Note that wt can be whatever alias you want, but my commands below