Re: [Gimp-developer] difference between canvas_draw and draw_tool_draw functions

2004-09-30 Thread Sven Neumann
Hi, [EMAIL PROTECTED] (Olivier) writes: what is the difference between for example gimp_canvas_draw_rectangle and gimp_draw_tool_draw_rectangle? The GimpDrawTool API takes image coordinates while the (lowerlevel) GimpCanvas API takes display coordinates. when should one use which function?

Re: [Gimp-developer] difference between canvas_draw and draw_tool_draw functions

2004-09-30 Thread Olivier
On Thu, Sep 30, 2004 at 11:27:17AM +0200, Sven Neumann wrote: what is the difference between for example gimp_canvas_draw_rectangle and gimp_draw_tool_draw_rectangle? The GimpDrawTool API takes image coordinates while the (lowerlevel) GimpCanvas API takes display coordinates. the

Re: [Gimp-developer] difference between canvas_draw and draw_tool_draw functions

2004-09-30 Thread Sven Neumann
Hi, [EMAIL PROTECTED] (Olivier) writes: On Thu, Sep 30, 2004 at 11:27:17AM +0200, Sven Neumann wrote: what is the difference between for example gimp_canvas_draw_rectangle and gimp_draw_tool_draw_rectangle? The GimpDrawTool API takes image coordinates while the (lowerlevel) GimpCanvas

Re: [Gimp-developer] difference between canvas_draw and draw_tool_draw functions

2004-09-30 Thread Olivier
On Thu, Sep 30, 2004 at 12:46:02PM +0200, Sven Neumann wrote: the drawtool always paints using GIMP_CANVAS_STYLE_XOR, correct? I'm creating a patch to add an option to the crop tool to blind the region outside the crop area, so you can see how the image will look after cropping. I've not

Re: [Gimp-developer] difference between canvas_draw and draw_tool_draw functions

2004-09-30 Thread Sven Neumann
Hi, [EMAIL PROTECTED] (Olivier) writes: But black is a useful start, it can always be improved to a darkened image any later time. Well, a darkened image would need a completely different approach. I doubt that using black is a useful start and I am not sure if we should accept that change

Re: [Gimp-developer] difference between canvas_draw and draw_tool_draw functions

2004-09-30 Thread Sven Neumann
Hi, [EMAIL PROTECTED] (Olivier) writes: not start as in code, but start as in functionality we're talking about a feature request since 2002: http://bugzilla.gnome.org/show_bug.cgi?id=93360 Oh, this request is much older. It's been in the early TODOs, so it's probably around for six or

Re: [Gimp-developer] difference between canvas_draw and draw_tool_draw functions

2004-09-30 Thread Sven Neumann
Hi, [EMAIL PROTECTED] (Olivier) writes: I don't think I can do that on my second day of gimp hacking indeed I would like to note that you have choosen the by far most tricky part of the GIMP source code to hack on. Even though we have already put some work into this, the tools code is still a