Re: [Gimp-developer] EXIF in JPEGs and TIFFs
Lutz Müller wrote:
EXIF information in JPEGs using libexif. This patch never got into the
GIMP nor was updated to 1.3.x as
Did some 'sledgehammer hacking' to get the old exif patch to work under GIMP
1.3.12. It's attached as a text file. I assume absolutely no responsibility
for it. It's a Lutz's fault. ;-)
jas
--
Jason Van Patten
AOL IM: Jason VP
diff -BPcpr gimp-1.3.12/acclocal.h gimp-1.3.12-exif/acclocal.h
*** gimp-1.3.12/acclocal.h Wed Dec 31 19:00:00 1969
--- gimp-1.3.12-exif/acclocal.h Wed Mar 19 09:47:26 2003
***
*** 0
--- 1,2
+ #undef HAVE_EXIF
+
diff -BPcpr gimp-1.3.12/configure.in gimp-1.3.12-exif/configure.in
*** gimp-1.3.12/configure.inSat Feb 8 05:00:12 2003
--- gimp-1.3.12-exif/configure.in Wed Mar 19 09:47:21 2003
*** AC_SUBST(gimpplugindir)
*** 1073,1078
--- 1073,1108
AC_SUBST(gimpsysconfdir)
AC_SUBST(localedir)
+ dnl ---
+ dnl libexif-gtk: JPEG files can contain EXIF data. If libexif-gtk is installed
+ dnl on the system, gimp can use it to read this data from
+ dnl JPEG files and save it (if the file is saved again in
+ dnl the JPEG format). In addition, gimp can offer the user the
+ dnl possibility to edit (!) EXIF data.
+ dnl ---
+ exif_msg="no (http://www.sourceforge.net/projects/libexif)"
+ try_exif=true
+ AC_ARG_WITH(exif, [ --without-exif Don't use libexif],[
+if test x$withval = xno; then
+try_exif=false
+fi])
+ if $try_exif; then
+AC_PATH_PROG(PKG_CONFIG,pkg-config)
+if test -n "${PKG_CONFIG}"; then
+AC_MSG_CHECKING([for libexif-gtk])
+if ${PKG_CONFIG} --exists libexif-gtk > /dev/null 2>&1; then
+EXIF_CFLAGS=`$PKG_CONFIG --cflags libexif-gtk`
+EXIF_LIBS=`$PKG_CONFIG --libs libexif-gtk`
+exif_msg=yes
+AC_DEFINE(HAVE_EXIF,1,[Define EXIF])
+fi
+AC_MSG_RESULT($exif_msg)
+else
+AC_WARN([Not searching for libexif - pkg-config not found.])
+fi
+ fi
+ AC_SUBST(EXIF_CFLAGS)
+ AC_SUBST(EXIF_LIBS)
# Some defines for the build
diff -BPcpr gimp-1.3.12/plug-ins/common/Makefile.am
gimp-1.3.12-exif/plug-ins/common/Makefile.am
*** gimp-1.3.12/plug-ins/common/Makefile.am Wed Jan 29 05:26:48 2003
--- gimp-1.3.12-exif/plug-ins/common/Makefile.amWed Mar 19 09:47:35 2003
*** EXTRA_DIST = \
*** 15,20
--- 15,21
INCLUDES = \
-I$(top_srcdir) \
$(GTK_CFLAGS) \
+ $(EXIF_CFLAGS) \
$(X_CFLAGS) \
-I$(includedir)
*** jpeg_LDADD = \
*** 913,918
--- 914,920
$(top_builddir)/libgimpcolor/libgimpcolor-$(LT_RELEASE).la \
$(top_builddir)/libgimpbase/libgimpbase-$(LT_RELEASE).la\
$(LIBJPEG) \
+ $(EXIF_LIBS)\
$(GTK_LIBS) \
$(INTLLIBS)
diff -BPcpr gimp-1.3.12/plug-ins/common/jpeg.c gimp-1.3.12-exif/plug-ins/common/jpeg.c
*** gimp-1.3.12/plug-ins/common/jpeg.c Mon Feb 17 18:31:58 2003
--- gimp-1.3.12-exif/plug-ins/common/jpeg.c Wed Mar 19 09:47:42 2003
***
*** 146,151
--- 146,155
#include
#include
+ #ifdef HAVE_EXIF
+ #include
+ #endif
+
#include
#include
*** static JpegSaveInterface jsint =
*** 278,284
static gchar *image_comment = NULL;
static GtkWidget *restart_markers_scale = NULL;
static GtkWidget *restart_markers_label = NULL;
!
MAIN ()
--- 282,290
static gchar *image_comment = NULL;
static GtkWidget *restart_markers_scale = NULL;
static GtkWidget *restart_markers_label = NULL;
! #ifdef HAVE_EXIF
! static ExifData *exif_data = NULL;
! #endif
MAIN ()
*** run (gchar *name,
*** 424,430
default:
break;
}
!
g_free (image_comment);
image_comment = NULL;
--- 430,440
default:
break;
}
! #ifdef HAVE_EXIF
! exif_data_unref (exif_data);
! exif_data = NULL;
! #endif
!
g_free (image_comment);
image_comment = NULL;
*** run (gchar *name,
*** 434,439
--- 444,457
image_comment = g_strdup (parasite->data);
gimp_parasite_free (parasite);
}
+ #ifdef HAVE_EXIF
+ parasite = gimp_image_parasite_find (orig_image_ID, "exif-data");
+ if (parasite)
+{
+ exif_data = exif_data_new_from_data
Re: [Gimp-developer] EXIF in JPEGs and TIFFs
On 17 Mar 2003 21:26:22 +0100, Sven Neumann <[EMAIL PROTECTED]> wrote: > Jason Van Patten <[EMAIL PROTECTED]> writes: > > I'm sure this has been asked 5 bzillion times, so make this 5 bzillion > > and one. :-) Is there a plan to support reading/writing EXIF > > information found in files such as JPEGs and TIFFs? [...] > this issue is being tracked at > > http://bugzilla.gnome.org/show_bug.cgi?id=56443 > > Actually I was hoping we'd have some support for EXIF metadata by now > since several people volunteered to work on this stuff. Unfortunately > nothing usable has surfaced so far which means that it is very > unlikely that GIMP-1.4 will have this feature. This is mostly my fault. Since last year, I planned to add EXIF support in the "right" way, but I haven't been able to start implementing this. As we have seen the problems caused in the GIMP by some features that are implemented as quick hacks and then become unmaintained, I think that it is important to add EXIF support correctly, in a framework that supports EXIF for JPEG and TIFF (and maybe PNG), but also allows XMP/IPTC metadata (later). Although there have been several proposals to add a quick hack to "support EXIF" by simply copying the whole EXIF block from one JPEG file to another one, this is wrong (according to the EXIF spec) and I don't think that it would be a good idea to include this in the GIMP because this solution would be a dead end. So until a correct implementation is done in the GIMP, I prefer to recommend the usage of external tools. I'm still hoping to be able to start implementing this "soon"... -Raphaël ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] EXIF in JPEGs and TIFFs
Hi, Jason Van Patten <[EMAIL PROTECTED]> writes: > I'm sure this has been asked 5 bzillion times, so make this 5 bzillion > and one. :-) Is there a plan to support reading/writing EXIF > information found in files such as JPEGs and TIFFs? I've followed > older threads that lead me to Lutz's libexif, which I'm up-to-date on. > But, without applying a very hairy patch to 1.3.x, I can't get GIMP to > work with it. this issue is being tracked at http://bugzilla.gnome.org/show_bug.cgi?id=56443 Actually I was hoping we'd have some support for EXIF metadata by now since several people volunteered to work on this stuff. Unfortunately nothing usable has surfaced so far which means that it is very unlikely that GIMP-1.4 will have this feature. Salut, Sven ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] EXIF in JPEGs and TIFFs
Lutz Müller wrote: The current state is that there has been a patch to preserve and edit EXIF information in JPEGs using libexif. This patch never got into the GIMP nor was updated to 1.3.x as Odd. I was able to get the patch to apply (by hand, with a sledge hammer :-)) to 1.3.8. I had no luck getting it to apply to 1.2.x. I haven't tried to apply it to 1.3.12 though. Looks like things in the jpeg.c plugin have changed enough to confuse me. jas -- Jason Van Patten AOL IM: Jason VP ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] EXIF in JPEGs and TIFFs
On Fri, 2003-03-14 at 20:09, Jason Van Patten wrote: > Is there a plan to support reading/writing EXIF information found in > files such as JPEGs and TIFFs? Sure. The plan is to come up with some mechanism to store information (like EXIF) in and convert that information between several different file formats, including JPEG and TIFF (Sven et aliud). The current state is that there has been a patch to preserve and edit EXIF information in JPEGs using libexif. This patch never got into the GIMP nor was updated to 1.3.x as (1) it would add another dependency to an external library (2) it would not reach the goal as stated in above plan. > And, libexif is JPEG-centric. It's certainly handy, but it'd be even moreso > to support other file formats (TIFF specifically.) This request pops up a lot. My camera is really old and can't produce TIFFs. So, I don't have any incentives to add support for TIFFs to libexif. But I will happily integrate patches that are sent to me. -- Lutz Müller <[EMAIL PROTECTED]> ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
[Gimp-developer] EXIF in JPEGs and TIFFs
I'm sure this has been asked 5 bzillion times, so make this 5 bzillion and one. :-) Is there a plan to support reading/writing EXIF information found in files such as JPEGs and TIFFs? I've followed older threads that lead me to Lutz's libexif, which I'm up-to-date on. But, without applying a very hairy patch to 1.3.x, I can't get GIMP to work with it. And, libexif is JPEG-centric. It's certainly handy, but it'd be even moreso to support other file formats (TIFF specifically.) Daniel Stephens has written a C++ based CLI app called metacam http://www.cheeseplant.org/~daniel/pages/metacam.html which actually can read JPEGs and TIFFs. Is that something someone could work with and develop into a plugin? I've contacted Daniel and asked him a similar question; he said anyone can take what they want from his code but he hasn't a lot of time to donate to development. $ file F1A.TIF F1A.TIF: TIFF image data, little-endian $ metacam F1A.TIF File: F1A.TIF Standard Fields --- Image Creation Date: 2002:11:14 13:52:51 Make: Canon Model: Canon EOS-1DS Software Version: Adobe Photoshop 7.0 X Resolution: 72 Pixels/Inch Y Resolution: 72 Pixels/Inch Samples Per Pixel: 3 Bits Per Sample: (8,8,8) Photometric Interpretation: RGB Compression: Uncompressed EXIF Fields --- Image Capture Date: 2002:10:11 12:12:40 Image Digitized Date: 2002:10:11 12:12:40 Exposure Bias: 0 EV Focal Length: 600mm Exposure Time: 1/500 Sec. Aperture: f5.6 Exif Image Width: 4064 pixels Exif Image Height: 2704 pixels Exposure Mode: Manual Exposure White Balance: Auto White Balance ISO Speed Rating: 10 (50) EXIF Version: 0220 FlashPix Version: 0100 Aperture Value: f5.6 Focal Plane X Resolution: 11822545/4096 Pixels/Inch Focal Plane Y Resolution: 2955065/1024 Pixels/Inch Shutter Speed Value: 1/512 Sec. ColorSpace: sRGB Scene Capture Type: Standard jas -- Jason Van Patten AOL IM: Jason VP ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
