Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
Hi everyone,
May I ask someone to give me some feedback about a patch I posted
dealing with bug n° 612931 ?
I probably not understood something ... but I recently checked it
again, and according to me, it does
the trick : allowing the move tool to move individual layer inside a
layer group ( with pick a layer option
selected, of course ).
Gilles.
612931 - Moving individual layer in layer group not possible with
Move Tool
From e42c4afe9c24c644468c4f4f0fcb75088ce782a7 Mon Sep 17 00:00:00 2001
From: Gilles Rochefort gilles@tux.(none)
Date: Sat, 10 Jul 2010 02:45:13 +0200
Subject: [PATCH] bugfix 612931 : Moving individual layer in a group with Move Tool.
Dealing with group layer in gimpimage-pick-layer.c allows
one to move individual layer in a layer group.
---
app/core/gimpimage-pick-layer.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/app/core/gimpimage-pick-layer.c b/app/core/gimpimage-pick-layer.c
index 0a78fba..ddc0b82 100644
--- a/app/core/gimpimage-pick-layer.c
+++ b/app/core/gimpimage-pick-layer.c
@@ -48,7 +48,8 @@ gimp_image_pick_layer (const GimpImage *image,
gimp_item_get_offset (GIMP_ITEM (layer), off_x, off_y);
- if (gimp_pickable_get_opacity_at (GIMP_PICKABLE (layer),
+ if (! GIMP_IS_GROUP_LAYER (layer)
+ gimp_pickable_get_opacity_at (GIMP_PICKABLE (layer),
x - off_x, y - off_y) 63)
{
g_list_free (all_layers);
--
1.6.4.4
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On 03/14/2011 11:59 AM, Joao S. O. Bueno wrote: Hi, This decision, as I see it, change the release date from within months to within some weeks - May I ask for the calculations that led you to the conclusion that we are weeks away from a release? I haven't done the math yet, but I still expect us to be months away from a release. I hope you have in mind that Translators have to know about so they can update translations as possible, as well. At some reasonable point before the release, a string freeze status for GIMPshould be set (even if a few string chanegs are to happen after that). Thanks for the reminder. We should probably enter a soft string freeze soon... Other than translation, we have to work the Python bindings so there are no functionality regressions, (whch includes the ability to work with layer groups) - so to the above list of bugs, we shuld at least have one more about this task. (this also depends on being able to transform layer groups). Not including API to work with layer groups in Python is not a regression, it's just missing functionality in one of the scripting languages. It is unfortunate if GIMP 2.8 will be released without layer groups support in Python, but the alternative is worse: not releasing GIMP 2.8 at all. And we should arrange for the Python bindings to be automatically generated from the PDB rather than wasting man-weeks on manually keeping it up to date. Not an easy task perhaps, but the only sensible one. / Martin -- My GIMP Blog: http://www.chromecode.com/ Why GIMP 2.8 is not released yet ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On 15 March 2011 07:43, Martin Nordholts ense...@gmail.com wrote: Not including API to work with layer groups in Python is not a regression, it's just missing functionality in one of the scripting languages. It is unfortunate if GIMP 2.8 will be released without layer groups support in Python, but the alternative is worse: not releasing GIMP 2.8 at all. And we should arrange for the Python bindings to be automatically generated from the PDB rather than wasting man-weeks on manually keeping it up to date. Not an easy task perhaps, but the only sensible one. Long term, bindings should of course be generated (or rather be dynamic using pygobject, when/if possible). However I need layer groups exposed for the Python API in order to support layer groups in OpenRaster, so I will probably do these bindings for 2.8. Just need to find the time. Do we have a bug open about this issue? -- Jon Nordby - www.jonnor.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On Tue, Mar 15, 2011 at 4:43 AM, Martin Nordholts ense...@gmail.com wrote: On 03/14/2011 11:59 AM, Joao S. O. Bueno wrote: Hi, This decision, as I see it, change the release date from within months to within some weeks - May I ask for the calculations that led you to the conclusion that we are weeks away from a release? I haven't done the math yet, but I still expect us to be months away from a release. I hope you have in mind that Translators have to know about so they can update translations as possible, as well. At some reasonable point before the release, a string freeze status for GIMPshould be set (even if a few string chanegs are to happen after that). Thanks for the reminder. We should probably enter a soft string freeze soon... Other than translation, we have to work the Python bindings so there are no functionality regressions, (whch includes the ability to work with layer groups) - so to the above list of bugs, we shuld at least have one more about this task. (this also depends on being able to transform layer groups). Not including API to work with layer groups in Python is not a regression, it's just missing functionality in one of the scripting languages. It is unfortunate if GIMP 2.8 will be released without layer groups support in Python, but the alternative is worse: not releasing GIMP 2.8 at all. And we should arrange for the Python bindings to be automatically generated from the PDB rather than wasting man-weeks on manually keeping it up to date. Not an easy task perhaps, but the only sensible one. Scripts which previously interated through layers are currently not working. That is a regression. Possibly making layer groups transform work seamlessly. I will do my best to include such support personally over the next few days - allright if you think it shoud not be a blocker. The python bindings do work from the PDB. The current matter with layer groups is that they introduce a new kind o f object, and the Python bindngs on't work with simple integer IDs that the PDB use - there must be a corresponding object on the Python side. (it won't cost a single man week to integrate it - but I've been so absetn I ahven't weven checked the PDB calls available to deal with layer groups yet). js -- / Martin -- My GIMP Blog: http://www.chromecode.com/ Why GIMP 2.8 is not released yet ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On Mon, Mar 14, 2011 at 1:59 PM, Joao S. O. Bueno wrote: Hi, This decision, as I see it, change the release date from within months to within some weeks - I hope you have in mind that Translators have to know about so they can update translations as possible, as well. At some reasonable point before the release, a string freeze status for GIMPshould be set (even if a few string chanegs are to happen after that). Speaking of which, I'd love to know what on Earth the reasoning behind putting https://bugzilla.gnome.org/show_bug.cgi?id=556884 off the milestones is supposed to mean. The prerequisite is in place, making the messages translatable is very little work. So why are we going to ship 2.8 with the horrible mix of English/localized UI once again? Alexandre Prokoudine http://libregraphicsworld.org ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On 03/15/2011 10:44 AM, Jon Nordby wrote: On 15 March 2011 07:43, Martin Nordholtsense...@gmail.com wrote: Not including API to work with layer groups in Python is not a regression, it's just missing functionality in one of the scripting languages. It is unfortunate if GIMP 2.8 will be released without layer groups support in Python, but the alternative is worse: not releasing GIMP 2.8 at all. And we should arrange for the Python bindings to be automatically generated from the PDB rather than wasting man-weeks on manually keeping it up to date. Not an easy task perhaps, but the only sensible one. Long term, bindings should of course be generated (or rather be dynamic using pygobject, when/if possible). However I need layer groups exposed for the Python API in order to support layer groups in OpenRaster, so I will probably do these bindings for 2.8. Just need to find the time. Do we have a bug open about this issue? Take a look at Bug 624303 - Introduce an item class in PyGIMP https://bugzilla.gnome.org/show_bug.cgi?id=624303 / Martin -- My GIMP Blog: http://www.chromecode.com/ Why GIMP 2.8 is not released yet ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On 03/15/2011 12:35 PM, Joao S. O. Bueno wrote: Scripts which previously interated through layers are currently not working. That is a regression. It sure sounds like one, please file a bug report and put it on the 2.8 milestone with a scripts that allows the regression to be easily reproduced. / Martin -- My GIMP Blog: http://www.chromecode.com/ Why GIMP 2.8 is not released yet ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On 03/15/2011 02:12 PM, Alexandre Prokoudine wrote: On Mon, Mar 14, 2011 at 1:59 PM, Joao S. O. Bueno wrote: Hi, This decision, as I see it, change the release date from within months to within some weeks - I hope you have in mind that Translators have to know about so they can update translations as possible, as well. At some reasonable point before the release, a string freeze status for GIMPshould be set (even if a few string chanegs are to happen after that). Speaking of which, I'd love to know what on Earth the reasoning behind putting https://bugzilla.gnome.org/show_bug.cgi?id=556884 off the milestones is supposed to mean. The prerequisite is in place, making the messages translatable is very little work. So why are we going to ship 2.8 with the horrible mix of English/localized UI once again? There are thousands of other small things we could spend time on rather than working on the highest prioritized features dictated by our roadmap. But if we do, it might very well go another 9 years without any support for high bit depths in GIMP. Let's please focus on what's important, and compared to high bit depths, that is not important. / Martin -- My GIMP Blog: http://www.chromecode.com/ Why GIMP 2.8 is not released yet ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On Tue, Mar 15, 2011 at 8:25 PM, Martin Nordholts wrote: Speaking of which, I'd love to know what on Earth the reasoning behind putting https://bugzilla.gnome.org/show_bug.cgi?id=556884 off the milestones is supposed to mean. The prerequisite is in place, making the messages translatable is very little work. So why are we going to ship 2.8 with the horrible mix of English/localized UI once again? There are thousands of other small things we could spend time on rather than working on the highest prioritized features dictated by our roadmap. But if we do, it might very well go another 9 years without any support for high bit depths in GIMP. It looks like you didn't even bother looking at the bug report in question. Right now all it takes is green lights for someone (e.g. me) to enable the messages for translation and then let translators do their work. With all respect due, what 9 years are you talking about? Alexandre Prokoudine http://libregraphicsworld.org ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
On 03/15/2011 06:38 PM, Alexandre Prokoudine wrote: On Tue, Mar 15, 2011 at 8:25 PM, Martin Nordholts wrote: Speaking of which, I'd love to know what on Earth the reasoning behind putting https://bugzilla.gnome.org/show_bug.cgi?id=556884 off the milestones is supposed to mean. The prerequisite is in place, making the messages translatable is very little work. So why are we going to ship 2.8 with the horrible mix of English/localized UI once again? There are thousands of other small things we could spend time on rather than working on the highest prioritized features dictated by our roadmap. But if we do, it might very well go another 9 years without any support for high bit depths in GIMP. It looks like you didn't even bother looking at the bug report in question. Right now all it takes is green lights for someone (e.g. me) to enable the messages for translation and then let translators do their work. With all respect due, what 9 years are you talking about? I did look at it, and I saw that mitch said there was a problem, then you said there wasn't a problem, and now developer needs to verify that there maybe isn't a problem. It is harder to ignore small things like this, but they add up, and as I said: we need to stop working on what is not important and not be trapped in working on things like this. I was referring to the age of Bug 74224 - Add support for 16 bits per channel... / Martin -- My GIMP Blog: http://www.chromecode.com/ Why GIMP 2.8 is not released yet ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Enabling a 2.8 release: planning for a 2.10 release
FYI, I have code to fix #596410, following the guidelines Martin gave me, but I don't want to submit that patch until I can actually compile Gimp again. Eric On 03/14/2011 04:22 AM, Martin Nordholts wrote: Hi everyone, As you all know, getting 2.8 out is highest priority right now. There are however some things that we want to fix before we make a 3.0 release. Thus, we must plan for a 2.10 release. I have updated our milestones in bugzilla with this. After the update, there are only 7 bugs on the 2.8 milestone: 642728 - Function `gdk_gc_new' implicitly converted to pointer causes build failure 631766 - Bad performance when moving brush outline on canvas 612931 - Moving individual layer in layer group not possible with Move Tool 603848 - Single-window mode is not properly session managed yet 600554 - Implement layer group transforms 596410 - gimp-image-get-filename returns NULL for imported files 51112 - clipping groups or masking groups (like in Photoshop files) Let's focus our efforts and smash these last bugs so we can make a 2.8 release as soon as possible. To see what we should fix for the 2.10 release, refer to the 2.10 milestone and our roadmap: 2.10 milestone: https://bugzilla.gnome.org/buglist.cgi?product=GIMPbug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDtarget_milestone=2.10 Roadmap: http://gimp-wiki.who.ee/index.php/GIMP_Roadmap / Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
