Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
Hi, I use Ubuntu 17.10 (Gnome DE) and GIMP 2.9.9 development version. Under GIMP Color Management in Preferences, 'Image display mode' is set to "No color management", 'Monitor profile' is set to "None", 'Try to use system monitor profile' is unchecked, Black point compensation is checked. The Monitor profile chosen by the system is that of the monitor's make, 'BenQ VZ2350'. I tried searching for that profile to select in GIMP Color Management but couldn't find any such file in the system. Thank you. On Sun, Mar 11, 2018 at 8:14 PM, Elle Stone wrote: > On 03/11/2018 01:04 AM, Justus Rajan wrote: > >> I seem to have solved the issue by turning off the colour profile applied >> by the system itself. (Ubuntu -> Settings -> Devices -> Color) >> >> Now I can pick the right colour with the colour picker tool from the >> colour >> dialog box. >> >> Sorry about raising this (irrelevant) issue. ^_^ >> > > Hmm, if the color profile applied by the system itself is somehow causing > GIMP's screen color picker to pick the wrong color, this doesn't seem > irrelevant, but rather indicates a color management problem somewhere. > > In GIMP, in the Color Management section of Preferences, I'm guessing you > have color management enabled, yes? > > In GIMP Color Management Preferences, what monitor profile did you select? > Is the box to try to use the system monitor profile checked or unchecked? > Also, is the box to use black point compensation checked or unchecked? > > Also which version of GIMP are you using? > > Do you know what monitor profile is chosen by the system "(Ubuntu -> > Settings -> Devices -> Color)"? Is this the same monitor profile that you > selected in GIMP in the Color Management section of Preferences? > > If you are happy with results of simply disabling the color profile > applied by the system, and don't want to dig any deeper, please ignore this > email! I'm curious as to what went awry, but sometimes these things can be > difficult to track down. > > Best, > Elle > > ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
On 03/11/2018 01:04 AM, Justus Rajan wrote: I seem to have solved the issue by turning off the colour profile applied by the system itself. (Ubuntu -> Settings -> Devices -> Color) Now I can pick the right colour with the colour picker tool from the colour dialog box. Sorry about raising this (irrelevant) issue. ^_^ Hmm, if the color profile applied by the system itself is somehow causing GIMP's screen color picker to pick the wrong color, this doesn't seem irrelevant, but rather indicates a color management problem somewhere. In GIMP, in the Color Management section of Preferences, I'm guessing you have color management enabled, yes? In GIMP Color Management Preferences, what monitor profile did you select? Is the box to try to use the system monitor profile checked or unchecked? Also, is the box to use black point compensation checked or unchecked? Also which version of GIMP are you using? Do you know what monitor profile is chosen by the system "(Ubuntu -> Settings -> Devices -> Color)"? Is this the same monitor profile that you selected in GIMP in the Color Management section of Preferences? If you are happy with results of simply disabling the color profile applied by the system, and don't want to dig any deeper, please ignore this email! I'm curious as to what went awry, but sometimes these things can be difficult to track down. Best, Elle ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
Hey guys, I seem to have solved the issue by turning off the colour profile applied by the system itself. (Ubuntu -> Settings -> Devices -> Color) Now I can pick the right colour with the colour picker tool from the colour dialog box. Sorry about raising this (irrelevant) issue. ^_^ Thanks. On Wed, Feb 28, 2018 at 3:11 PM, Justus Rajan wrote: > For me the difference is there for most colours except black, white and > some other lighter colours like yellow. > > Can you guys try it with darker shades of colours? > > Thanks. > > On Wed, Feb 28, 2018 at 12:25 AM, Michal Vašut > wrote: > >> Here is the bug, it's minor, but it's good to be logged: >> https://bugzilla.gnome.org/show_bug.cgi?id=793893 >> >> ___ >> gimp-gui-list mailing list >> gimp-gui-list@gnome.org >> https://mail.gnome.org/mailman/listinfo/gimp-gui-list >> >> > ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
For me the difference is there for most colours except black, white and some other lighter colours like yellow. Can you guys try it with darker shades of colours? Thanks. On Wed, Feb 28, 2018 at 12:25 AM, Michal Vašut wrote: > Here is the bug, it's minor, but it's good to be logged: > https://bugzilla.gnome.org/show_bug.cgi?id=793893 > > ___ > gimp-gui-list mailing list > gimp-gui-list@gnome.org > https://mail.gnome.org/mailman/listinfo/gimp-gui-list > > ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
Here is the bug, it's minor, but it's good to be logged: https://bugzilla. gnome.org/show_bug.cgi?id=793893 ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
Yop, I've tested it in Linux Mint now, and here I can pick color from anywhere (desktop, webbrowser, ). I'll log it as Win specific bug to buzilla. ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
On 02/27/2018 12:25 PM, Michal Vašut wrote: I cannot reproduce it either - if I pick the color from outside of the canvas, and then fill the canvas with bucket tool, there is no transition (those 2 are the same). But there is definitely some problem with picking the color outside of Gimp window in Windows (not sure if that is possible in Linux). Hmm, that might be a Windows-specific issue. Using GIMP on Linux, I can pick a color from a solid-color image displayed in Geeqie, and fill an image layer in GIMP, and it's an exact match to the color as displayed in Geeqie, at least when Geeqie and GIMP are using the same monitor profile and color management settings - I didn't check other scenarios. ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
I cannot reproduce it either - if I pick the color from outside of the canvas, and then fill the canvas with bucket tool, there is no transition (those 2 are the same). But there is definitely some problem with picking the color outside of Gimp window in Windows (not sure if that is possible in Linux). All of the Gimp window is OK, even window frame and its decorations (minimize, maximize, close), but anything else outside window border is unreachable for color picker. Tested on GIMP 2.9.8 (commit 18794a6ba2), Win7 64bit. On Tue, Feb 27, 2018 at 5:54 PM, Elle Stone wrote: > On 02/27/2018 10:28 AM, Justus Rajan wrote: > >> Hi, >> >> I think just removing the monitor colour profile variable from the colour >> picker tool would solve this issue. I think that is what normal people and >> professionals would prefer as well. Because the picked colour will be >> different from what they see on the screen once applied elsewhere. >> > > Whenever people support a suggested change by saying what professionals > would prefer, I get nervous :) > > Here is an example... >> >> I had selected the colour for FG with the colour picker tool (which picks >> from screen) from the padding outside the canvas and applied it to the >> layer. >> You can see how they are different. So it would be slightly different to >> the colour that people actually wanted to pick and apply. >> >> > I tried to replicate your results, but I couldn't. I set the padding (the > color surrounding the image, where there's no actual image) to a fairly > saturated color that is still within my monitor's color gamut and also the > sRGB color gamut. Then I used the screen color picker to pick the color and > then the bucket tool to change the image layer. And the blend is perfect > between the image color and the canvas color. > > Can anyone else try this and see if the two colors match or don't match? > > > Best, > Elle > ___ > gimp-gui-list mailing list > gimp-gui-list@gnome.org > https://mail.gnome.org/mailman/listinfo/gimp-gui-list > ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
On 02/27/2018 10:28 AM, Justus Rajan wrote: Hi, I think just removing the monitor colour profile variable from the colour picker tool would solve this issue. I think that is what normal people and professionals would prefer as well. Because the picked colour will be different from what they see on the screen once applied elsewhere. Whenever people support a suggested change by saying what professionals would prefer, I get nervous :) Here is an example... I had selected the colour for FG with the colour picker tool (which picks from screen) from the padding outside the canvas and applied it to the layer. You can see how they are different. So it would be slightly different to the colour that people actually wanted to pick and apply. I tried to replicate your results, but I couldn't. I set the padding (the color surrounding the image, where there's no actual image) to a fairly saturated color that is still within my monitor's color gamut and also the sRGB color gamut. Then I used the screen color picker to pick the color and then the bucket tool to change the image layer. And the blend is perfect between the image color and the canvas color. Can anyone else try this and see if the two colors match or don't match? Best, Elle ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
On 2018-02-27 15:42, Elle Stone wrote: On 02/27/2018 09:21 AM, Jehan wrote: While I understand what you are asking for, I'm wondering why it is really necessary. The 2 options already exist: picking using the color picker tool or using the color dock. I also understand that you may not want to care about the difference. From a simple point of view, they both pick colors, what is the difference? Who even cares about this difference? I get this. Yet the difference exists, we didn't invent it and I'm not sure if trying to blur this difference is not an actual disservice to people. Hi, Hmm, I didn't interpret the request as "why care about the difference" (the difference is very real and very important). I interpreted the request as "Put access to the color picker inside the "Choose Foreground/Background" dialog, along with keeping the "pick screen color" eye-dropper". Having the color picker tool inside the "Choose FG/BG" dialog seems like it might be pretty handy, though given that the color picker is readily available in the toolbox, it's not a big deal. Having the color picker tool also be in the "Choose FG/BG" dialog, along with the screen color picker, might make it more obvious that the two tools indeed have different purposes and do in fact pick different colors. On the other hand, the "Choose FG/BG" dialog would be more complicated. And users might forget which color picking tool they just used, or accidentally use the screen color picker when really they wanted the "pick color from GIMP image" color picker or vice versa. Yes I interpreted the request the same as you, and this last sentence is what I meant by "blurring" the difference. Basically allowing the 2 features from the same place may make it confusing to most people. Right now, it is simple: you either use the tool and you get canvas colors; or you get the more generic color picker from the dock and you can pick color from anywhere on screen. Well most people won't know the difference, but the people who do (graphics professional or amateur who go further in digital graphics subtleties) will directly get the difference between these 2 different features. Trying to get them all at the same place, with slightly different icons or text titles or whatever, or even just a single icon but a checkbox to switch between the 2 features (or whatever else GUI option one might think of) feel to me to me like it makes the separation less clear. Which is also what you are saying in your last sentence. As you say, both features are reachable quite easily already. I don't see a huge gain in trying to have them all at the same place. Jehan Best, Elle ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list -- ZeMarmot open animation film http://film.zemarmot.net Liberapay: https://liberapay.com/ZeMarmot/ Patreon: https://patreon.com/zemarmot Tipeee: https://www.tipeee.com/zemarmot ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
On 02/27/2018 09:21 AM, Jehan wrote: While I understand what you are asking for, I'm wondering why it is really necessary. The 2 options already exist: picking using the color picker tool or using the color dock. I also understand that you may not want to care about the difference. From a simple point of view, they both pick colors, what is the difference? Who even cares about this difference? I get this. Yet the difference exists, we didn't invent it and I'm not sure if trying to blur this difference is not an actual disservice to people. Hi, Hmm, I didn't interpret the request as "why care about the difference" (the difference is very real and very important). I interpreted the request as "Put access to the color picker inside the "Choose Foreground/Background" dialog, along with keeping the "pick screen color" eye-dropper". Having the color picker tool inside the "Choose FG/BG" dialog seems like it might be pretty handy, though given that the color picker is readily available in the toolbox, it's not a big deal. Having the color picker tool also be in the "Choose FG/BG" dialog, along with the screen color picker, might make it more obvious that the two tools indeed have different purposes and do in fact pick different colors. On the other hand, the "Choose FG/BG" dialog would be more complicated. And users might forget which color picking tool they just used, or accidentally use the screen color picker when really they wanted the "pick color from GIMP image" color picker or vice versa. Best, Elle ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
On 2018-02-27 15:38, Ofnuts wrote: On 02/27/18 15:21, Jehan wrote: Hello, On 2018-02-26 06:14, Justus Rajan wrote: The colour picker option currently present in the colour dialog box (of FG/BG and Text) picks colour from the screen. Adding a new option which shares the same functionality of the colour picker tool from the toolbox (i.e. picking colour from the image) would be very helpful. While there are workarounds for selecting and applying a colour from the image, adding this option will significantly save time and effort. Here is a bugzilla link which describes it in detail: https://bugzilla.gnome.org/show_bug.cgi?id=470761 [1] While I understand what you are asking for, I'm wondering why it is really necessary. The 2 options already exist: picking using the color picker tool or using the color dock. These are 2 conceptually close yet different (and explicitly different even!) features. I don't think that we would really make a service to people by blurring this difference with more hidden options. When you use the color picker from the dock, you know you get a color anywhere from the *screen*, which are colors you don't necessarily have original values anyway, you get what is displayed. Having an option which would optionally grab from actually opened image in canvas would not only make the code complicated, it would also make the feature conceptually complicated (basically the feature works differently depending on where your pointer is standing). Whereas right now, it is simple: you have 2 different color pickers which work in 2 different ways. So depending on what you want, you use one or the other. That's my initial reaction, though I can still change it. I also understand that you may not want to care about the difference. From a simple point of view, they both pick colors, what is the difference? Who even cares about this difference? I get this. Yet the difference exists, we didn't invent it and I'm not sure if trying to blur this difference is not an actual disservice to people. Except that the color picking from the 'Colors' dock is, on Windows, limited to the Gimp windows (canvas and dialogs) or perhaps to the windows using the GTK library. But you can't color-pick anywhere on the screen like you can do in Linux. Really? That sucks. I am assuming it should be possible to color-pick everywhere on Windows too, no? So that's mostly an implementation problem/bug. Patches welcome. :-) Jehan ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list -- ZeMarmot open animation film http://film.zemarmot.net Liberapay: https://liberapay.com/ZeMarmot/ Patreon: https://patreon.com/zemarmot Tipeee: https://www.tipeee.com/zemarmot ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
On 02/27/18 15:21, Jehan wrote: Hello, On 2018-02-26 06:14, Justus Rajan wrote: The colour picker option currently present in the colour dialog box (of FG/BG and Text) picks colour from the screen. Adding a new option which shares the same functionality of the colour picker tool from the toolbox (i.e. picking colour from the image) would be very helpful. While there are workarounds for selecting and applying a colour from the image, adding this option will significantly save time and effort. Here is a bugzilla link which describes it in detail: https://bugzilla.gnome.org/show_bug.cgi?id=470761 [1] While I understand what you are asking for, I'm wondering why it is really necessary. The 2 options already exist: picking using the color picker tool or using the color dock. These are 2 conceptually close yet different (and explicitly different even!) features. I don't think that we would really make a service to people by blurring this difference with more hidden options. When you use the color picker from the dock, you know you get a color anywhere from the *screen*, which are colors you don't necessarily have original values anyway, you get what is displayed. Having an option which would optionally grab from actually opened image in canvas would not only make the code complicated, it would also make the feature conceptually complicated (basically the feature works differently depending on where your pointer is standing). Whereas right now, it is simple: you have 2 different color pickers which work in 2 different ways. So depending on what you want, you use one or the other. That's my initial reaction, though I can still change it. I also understand that you may not want to care about the difference. From a simple point of view, they both pick colors, what is the difference? Who even cares about this difference? I get this. Yet the difference exists, we didn't invent it and I'm not sure if trying to blur this difference is not an actual disservice to people. Except that the color picking from the 'Colors' dock is, on Windows, limited to the Gimp windows (canvas and dialogs) or perhaps to the windows using the GTK library. But you can't color-pick anywhere on the screen like you can do in Linux. ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
Re: [Gimp-gui] Suggestion to add an option for colour picker (which picks from image) in colour dialog box.
Hello, On 2018-02-26 06:14, Justus Rajan wrote: The colour picker option currently present in the colour dialog box (of FG/BG and Text) picks colour from the screen. Adding a new option which shares the same functionality of the colour picker tool from the toolbox (i.e. picking colour from the image) would be very helpful. While there are workarounds for selecting and applying a colour from the image, adding this option will significantly save time and effort. Here is a bugzilla link which describes it in detail: https://bugzilla.gnome.org/show_bug.cgi?id=470761 [1] While I understand what you are asking for, I'm wondering why it is really necessary. The 2 options already exist: picking using the color picker tool or using the color dock. These are 2 conceptually close yet different (and explicitly different even!) features. I don't think that we would really make a service to people by blurring this difference with more hidden options. When you use the color picker from the dock, you know you get a color anywhere from the *screen*, which are colors you don't necessarily have original values anyway, you get what is displayed. Having an option which would optionally grab from actually opened image in canvas would not only make the code complicated, it would also make the feature conceptually complicated (basically the feature works differently depending on where your pointer is standing). Whereas right now, it is simple: you have 2 different color pickers which work in 2 different ways. So depending on what you want, you use one or the other. That's my initial reaction, though I can still change it. I also understand that you may not want to care about the difference. From a simple point of view, they both pick colors, what is the difference? Who even cares about this difference? I get this. Yet the difference exists, we didn't invent it and I'm not sure if trying to blur this difference is not an actual disservice to people. Jehan Thank you. Links: -- [1] https://bugzilla.gnome.org/show_bug.cgi?id=470761 ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list -- ZeMarmot open animation film http://film.zemarmot.net Liberapay: https://liberapay.com/ZeMarmot/ Patreon: https://patreon.com/zemarmot Tipeee: https://www.tipeee.com/zemarmot ___ gimp-gui-list mailing list gimp-gui-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-gui-list
