[jira] [Commented] (GIRAPH-146) Maven is running the tests twice during builds

2012-02-09 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205137#comment-13205137 ] Jakob Homan commented on GIRAPH-146: This might be a hiccup on my side. The double ru

[jira] [Commented] (GIRAPH-146) Maven is running the tests twice during builds

2012-02-09 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205131#comment-13205131 ] Jakob Homan commented on GIRAPH-146: >From a run of {{mvn site:site}}. Other targets

[jira] [Created] (GIRAPH-146) Maven is running the tests twice during builds

2012-02-09 Thread Jakob Homan (Created) (JIRA)
Maven is running the tests twice during builds -- Key: GIRAPH-146 URL: https://issues.apache.org/jira/browse/GIRAPH-146 Project: Giraph Issue Type: Bug Components: build Repor

[jira] [Commented] (GIRAPH-143) Add support for giraph to have a conf file

2012-02-09 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205113#comment-13205113 ] Claudio Martella commented on GIRAPH-143: - Yes. I guess this should come along wit

[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205105#comment-13205105 ] Jakob Homan commented on GIRAPH-142: I'll fix it in my next patch. bq. Reviewing would

[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205099#comment-13205099 ] Avery Ching commented on GIRAPH-142: Jakob, your 'if(' still needs to be 'if ('. =) R

[jira] [Commented] (GIRAPH-143) Add support for giraph to have a conf file

2012-02-09 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205086#comment-13205086 ] Jakob Homan commented on GIRAPH-143: Any reviewers about? > Add suppo

[jira] [Commented] (GIRAPH-139) Change PageRankBenchmark to be accessible via bin/giraph

2012-02-09 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205087#comment-13205087 ] Jakob Homan commented on GIRAPH-139: @Avery - does this new approach work for you?

[jira] [Updated] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Jakob Homan (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated GIRAPH-142: --- Attachment: GIRAPH-142-c.patch Updated with formatting changes. > _hadoopBsp should

[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205068#comment-13205068 ] Avery Ching commented on GIRAPH-142: whoops, should have also said that the if () bloc

[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205066#comment-13205066 ] Avery Ching commented on GIRAPH-142: +1 Some minor formatting changes (spacing and 'i

[jira] [Updated] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Jakob Homan (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated GIRAPH-142: --- Attachment: GIRAPH-142-b.patch Updated patch with check for starting slash. > _hadoo

[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205047#comment-13205047 ] Avery Ching commented on GIRAPH-142: Looks fine, could we just add a check somewhere t

[jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205048#comment-13205048 ] Claudio Martella commented on GIRAPH-142: - looks good. +1. > _had

[jira] [Updated] (GIRAPH-142) _hadoopBsp should be prefixable via configuration

2012-02-09 Thread Jakob Homan (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated GIRAPH-142: --- Attachment: GIRAPH-142.patch Patch to add new config value, giraph.zkBaseZNode, that is the top-level

[jira] [Commented] (GIRAPH-144) GiraphJob should not extend Job (users should not be able to call Job methods like waitForCompletion or setMapper..etc)

2012-02-09 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205022#comment-13205022 ] Avery Ching commented on GIRAPH-144: There are basically two approaches we can have he

[jira] [Commented] (GIRAPH-145) Change partition request log level to debug rather than info

2012-02-09 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204920#comment-13204920 ] Hudson commented on GIRAPH-145: --- Integrated in Giraph-trunk-Commit #79 (See [https://builds

[jira] [Commented] (GIRAPH-145) Change partition request log level to debug rather than info

2012-02-09 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204887#comment-13204887 ] Claudio Martella commented on GIRAPH-145: - +1, go on. > Change pa

[jira] [Updated] (GIRAPH-145) Change partition request log level to debug rather than info

2012-02-09 Thread Jakob Homan (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated GIRAPH-145: --- Attachment: GIRAPH-145.patch Quick patch to go down to debug level. Verified with tests and cluster

[jira] [Created] (GIRAPH-145) Change partition request log level to debug rather than info

2012-02-09 Thread Jakob Homan (Created) (JIRA)
Change partition request log level to debug rather than info Key: GIRAPH-145 URL: https://issues.apache.org/jira/browse/GIRAPH-145 Project: Giraph Issue Type: Improvement

[jira] [Commented] (GIRAPH-144) GiraphJob should not extend Job (users should not be able to call Job methods like waitForCompletion or setMapper..etc)

2012-02-09 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204818#comment-13204818 ] Jakob Homan commented on GIRAPH-144: bq. I have already submitted a patch that handles

[jira] [Commented] (GIRAPH-144) GiraphJob should not extend Job (users should not be able to call Job methods like waitForCompletion or setMapper..etc)

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204378#comment-13204378 ] jirapos...@reviews.apache.org commented on GIRAPH-144: --

Review Request: GIRAPH-144 GiraphJob should not extend Job (users should not be able to call Job methods like waitForCompletion or setMapper..etc)

2012-02-09 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3823/ --- Review request for giraph. Summary --- GiraphJob uses composition with Job

[jira] [Updated] (GIRAPH-144) GiraphJob should not extend Job (users should not be able to call Job methods like waitForCompletion or setMapper..etc)

2012-02-09 Thread Avery Ching (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-144: --- Attachment: GIRAPH-144.patch Here's the patch. > GiraphJob should not extend Job (u