[jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy

[ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216292#comment-13216292 ] Eli Reisman commented on GIRAPH-85: --- Hi Avery, It passed "mvn verify" also, just ran it.

[jira] [Updated] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy

[ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman updated GIRAPH-85: -- Attachment: GIRAPH-85.patch This is an improved version of GIRAPH-85.patch done in redone in git and me

[jira] [Updated] (GIRAPH-87) Simplify boolean expression in BspService::checkpointFrequencyMet

[ https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman updated GIRAPH-87: -- Attachment: GIRAPH-87.patch This is an improved version of GIRAPH-87.patch that passes "mvn checkstyle:

[jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy

[ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216047#comment-13216047 ] Avery Ching commented on GIRAPH-85: --- please make sure it passes 'mvn verify' as well. Th

[jira] [Updated] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy

[ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman updated GIRAPH-85: -- Attachment: GIRAPH-85.patch Simplifies 2 return statements without changing program logic or flow. Passe

[jira] [Commented] (GIRAPH-87) Simplify boolean expression in BspService::checkpointFrequencyMet

[ https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215955#comment-13215955 ] Jakob Homan commented on GIRAPH-87: --- Looks good except it fails checkstyle: {noformat}

[jira] [Updated] (GIRAPH-87) Simplify boolean expression in BspService::checkpointFrequencyMet

[ https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman updated GIRAPH-87: -- Attachment: GIRAPH-87.patch This is the patch for GIRAPH-87 JIRA newbie issue. Passed "mvn test", not t

[jira] [Assigned] (GIRAPH-87) Simplify boolean expression in BspService::checkpointFrequencyMet

[ https://issues.apache.org/jira/browse/GIRAPH-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan reassigned GIRAPH-87: - Assignee: Eli Reisman > Simplify boolean expression in BspService::checkpointFrequencyMet > --

[jira] [Resolved] (GIRAPH-132) Simplify boolean expression in GraphMapper::map()

[ https://issues.apache.org/jira/browse/GIRAPH-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching resolved GIRAPH-132. Resolution: Not A Problem Thanks Eli, this was resolved in the massive checkstyle fix (GIRAPH-40).

[jira] [Commented] (GIRAPH-132) Simplify boolean expression in GraphMapper::map()

[ https://issues.apache.org/jira/browse/GIRAPH-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215809#comment-13215809 ] Eli Reisman commented on GIRAPH-132: This seems to have been fixed already but is stil