Re: Review Request: GIRAPH-20 Move temporary test files from the project directory

2012-05-10 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5077/#review7772 --- Ship it! +1, thanks Sebastian! I'm assuming it also passes 'mvn veri

Re: Review Request: GIRAPH-20 Move temporary test files from the project directory

2012-05-10 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5077/ --- (Updated 2012-05-10 09:32:10.140325) Review request for giraph. Changes --

Re: Review Request: GIRAPH-20 Move temporary test files from the project directory

2012-05-10 Thread Sebastian Schelter
> On 2012-05-10 06:57:01, Avery Ching wrote: > > Overall, looks great. Can you address the questions/comments and then I'll > > re-review? Thanks for the quick review! I'll address your comments, merge this with the current trunk and posted a new patch. > On 2012-05-10 06:57:01, Avery Chin

Re: Review Request: GIRAPH-20 Move temporary test files from the project directory

2012-05-09 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5077/#review7756 --- Overall, looks great. Can you address the questions/comments and then

Re: Review Request: GIRAPH-20 Move temporary test files from the project directory

2012-05-09 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5077/#review7745 --- Hey, Sebastian, overall looks good. If no one else gets to it, I'll f

Review Request: GIRAPH-20 Move temporary test files from the project directory

2012-05-09 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5077/ --- Review request for giraph. Summary --- All temporary files that the tests g