[jira] [Commented] (GIRAPH-131) enable creation of test-jars to simplify testing in downstream projects
[
https://issues.apache.org/jira/browse/GIRAPH-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195258#comment-13195258
]
Jakob Homan commented on GIRAPH-131:
+1. Tested patch and verified all the tests and infrastructure are now in the
new jar. Adding -SNAPSHOT makes a few more files break the 100-char path limit
and we get more warnings, but this is expected.
enable creation of test-jars to simplify testing in downstream projects
---
Key: GIRAPH-131
URL: https://issues.apache.org/jira/browse/GIRAPH-131
Project: Giraph
Issue Type: Improvement
Reporter: André Kelpe
Priority: Minor
Attachments: GIRAPH-131.patch
Attached patch enables the creation of test-jars, which are the tests
packaged in a separate jar file. This makes it possible to use the
super-useful test infrastructure in MockUtils in downstream projects. If you
add the patch, you will get a ${giraph.version}-tests.jar, which can be used
for downstream testing like this:
dependency
groupIdorg.apache.giraph/groupId
artifactIdgiraph/artifactId
version${giraph.version}/version
typetest-jar/type
scopetest/scope
/dependency
P.S.: The patch also resets the version to 0.1-SNAPSHOT as discussed in
GIRAPH-129
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-131) enable creation of test-jars to simplify testing in downstream projects
[
https://issues.apache.org/jira/browse/GIRAPH-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan resolved GIRAPH-131.
Resolution: Fixed
Fix Version/s: 0.1.0
Assignee: André Kelpe
I've committed this. Resolving as fixed. Thanks, André!
enable creation of test-jars to simplify testing in downstream projects
---
Key: GIRAPH-131
URL: https://issues.apache.org/jira/browse/GIRAPH-131
Project: Giraph
Issue Type: Improvement
Reporter: André Kelpe
Assignee: André Kelpe
Priority: Minor
Fix For: 0.1.0
Attachments: GIRAPH-131.patch
Attached patch enables the creation of test-jars, which are the tests
packaged in a separate jar file. This makes it possible to use the
super-useful test infrastructure in MockUtils in downstream projects. If you
add the patch, you will get a ${giraph.version}-tests.jar, which can be used
for downstream testing like this:
dependency
groupIdorg.apache.giraph/groupId
artifactIdgiraph/artifactId
version${giraph.version}/version
typetest-jar/type
scopetest/scope
/dependency
P.S.: The patch also resets the version to 0.1-SNAPSHOT as discussed in
GIRAPH-129
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-128) RPC port from BasicRPCCommunications should be only a starting port, and retried
[ https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195286#comment-13195286 ] Avery Ching commented on GIRAPH-128: Thanks for taking a look. I forgot to upload the original (rb only for that one), hence part 2. The main motivation for the obscure case is that it would make debugging simpler. We often see errors like serverX:portY, and can use portY to figure out which mapper to look at. For example, currently the default starts at 3. If I see an error from 30001, then I know to go to mapper 1 to see it's problem. And so on and so forth. If I am running a 900 mapper job then if it's 31001 or 32001 then I still know to look at mapper partition 1. If instead I had a 100 as the constant, then if it's 30101, I have to check both mapper 1 and mapper 101. With up to 20 retries per port, we can handle at least 20 simultaneous jobs running on a single machine that have the same mapper partition id. First of, that is probably unlikely. But even if it does happen, 20 is probably more than an one machine would handle. By the way, port retries are very fast (so I wouldn't worry to much about collisions). Let me resubmit without the whitespace changes and making MAX_BIND_ATTEMPTS configurable. RPC port from BasicRPCCommunications should be only a starting port, and retried Key: GIRAPH-128 URL: https://issues.apache.org/jira/browse/GIRAPH-128 Project: Giraph Issue Type: Improvement Affects Versions: 0.1.0 Reporter: Avery Ching Assignee: Avery Ching Attachments: GIRAPH-128.2.patch Currently Giraph uses a basic port + the task partition to get the RPC port. This doesn't work well for when there are multiple Giraph jobs running simultaneously in the same Hadoop cluster (port conflict). At the same time, it is nice to use this simple algorithm because it makes it very easy to debug problems (you can find the troublesome mapper from the RPC port name). I will be proposing a simple scheme to retry with another port. I will round the total number of mappers up to the nearest power of 10 (let's that that number Z). Then I will increment the port number by Z, retrying up to 20 tries. If you have enough ports, this scheme would guarantee that up to 20 mappers / node would be supported. It should be sufficient for most clusters. At the same time, we still maintain the easy debugging method since you it's still easy to figure out the mapper partition from the port (port % Z = map partition). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-131) enable creation of test-jars to simplify testing in downstream projects
[
https://issues.apache.org/jira/browse/GIRAPH-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195294#comment-13195294
]
Hudson commented on GIRAPH-131:
---
Integrated in Giraph-trunk-Commit #68 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/68/])
GIRAPH-131. enable creation of test-jars to simplify testing in downstream
projects. Contributed by André Kelpe.
jghoman :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1236935
Files :
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/pom.xml
enable creation of test-jars to simplify testing in downstream projects
---
Key: GIRAPH-131
URL: https://issues.apache.org/jira/browse/GIRAPH-131
Project: Giraph
Issue Type: Improvement
Reporter: André Kelpe
Assignee: André Kelpe
Priority: Minor
Fix For: 0.1.0
Attachments: GIRAPH-131.patch
Attached patch enables the creation of test-jars, which are the tests
packaged in a separate jar file. This makes it possible to use the
super-useful test infrastructure in MockUtils in downstream projects. If you
add the patch, you will get a ${giraph.version}-tests.jar, which can be used
for downstream testing like this:
dependency
groupIdorg.apache.giraph/groupId
artifactIdgiraph/artifactId
version${giraph.version}/version
typetest-jar/type
scopetest/scope
/dependency
P.S.: The patch also resets the version to 0.1-SNAPSHOT as discussed in
GIRAPH-129
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: GIRAPH-128: RPC port from BasicRPCCommunications should be only a starting port, and retried
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3596/ --- (Updated 2012-01-28 01:15:26.114994) Review request for giraph. Changes --- Removed whitspace changes for MinimumIntCombiner.java and SimpleSumCombiner.java and made GiraphJob.MAX_RPC_PORT_BIND_ATTEMPTS configurable, but default to 20. Summary --- Simple handling of port collisions on the same machine while preserving debugability from the port number alone. Round up the max number of workers to the next power of 10 and use it as a constant to increase the port number with. Added a unit test to ensure it is working correctly. Fixed 2 minor warnings on src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java of removing 'import java.util.List'. This addresses bug GIRAPH-128. https://issues.apache.org/jira/browse/GIRAPH-128 Diffs (updated) - http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1236935 http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java 1236935 http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/comm/RPCCommunicationsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/3596/diff Testing --- Passed local and MR unittests. Thanks, Avery
[jira] [Commented] (GIRAPH-128) RPC port from BasicRPCCommunications should be only a starting port, and retried
[ https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195330#comment-13195330 ] jirapos...@reviews.apache.org commented on GIRAPH-128: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3596/ --- (Updated 2012-01-28 01:15:26.114994) Review request for giraph. Changes --- Removed whitspace changes for MinimumIntCombiner.java and SimpleSumCombiner.java and made GiraphJob.MAX_RPC_PORT_BIND_ATTEMPTS configurable, but default to 20. Summary --- Simple handling of port collisions on the same machine while preserving debugability from the port number alone. Round up the max number of workers to the next power of 10 and use it as a constant to increase the port number with. Added a unit test to ensure it is working correctly. Fixed 2 minor warnings on src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java of removing 'import java.util.List'. This addresses bug GIRAPH-128. https://issues.apache.org/jira/browse/GIRAPH-128 Diffs (updated) - http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1236935 http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java 1236935 http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/comm/RPCCommunicationsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/3596/diff Testing --- Passed local and MR unittests. Thanks, Avery RPC port from BasicRPCCommunications should be only a starting port, and retried Key: GIRAPH-128 URL: https://issues.apache.org/jira/browse/GIRAPH-128 Project: Giraph Issue Type: Improvement Affects Versions: 0.1.0 Reporter: Avery Ching Assignee: Avery Ching Attachments: GIRAPH-128.2.patch Currently Giraph uses a basic port + the task partition to get the RPC port. This doesn't work well for when there are multiple Giraph jobs running simultaneously in the same Hadoop cluster (port conflict). At the same time, it is nice to use this simple algorithm because it makes it very easy to debug problems (you can find the troublesome mapper from the RPC port name). I will be proposing a simple scheme to retry with another port. I will round the total number of mappers up to the nearest power of 10 (let's that that number Z). Then I will increment the port number by Z, retrying up to 20 tries. If you have enough ports, this scheme would guarantee that up to 20 mappers / node would be supported. It should be sufficient for most clusters. At the same time, we still maintain the easy debugging method since you it's still easy to figure out the mapper partition from the port (port % Z = map partition). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-128) RPC port from BasicRPCCommunications should be only a starting port, and retried
[ https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195347#comment-13195347 ] Jakob Homan commented on GIRAPH-128: Any reason the question about mocks/extending the class wasn't addressed? RPC port from BasicRPCCommunications should be only a starting port, and retried Key: GIRAPH-128 URL: https://issues.apache.org/jira/browse/GIRAPH-128 Project: Giraph Issue Type: Improvement Affects Versions: 0.1.0 Reporter: Avery Ching Assignee: Avery Ching Attachments: GIRAPH-128.2.patch, GIRAPH-128.3.patch Currently Giraph uses a basic port + the task partition to get the RPC port. This doesn't work well for when there are multiple Giraph jobs running simultaneously in the same Hadoop cluster (port conflict). At the same time, it is nice to use this simple algorithm because it makes it very easy to debug problems (you can find the troublesome mapper from the RPC port name). I will be proposing a simple scheme to retry with another port. I will round the total number of mappers up to the nearest power of 10 (let's that that number Z). Then I will increment the port number by Z, retrying up to 20 tries. If you have enough ports, this scheme would guarantee that up to 20 mappers / node would be supported. It should be sufficient for most clusters. At the same time, we still maintain the easy debugging method since you it's still easy to figure out the mapper partition from the port (port % Z = map partition). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: GIRAPH-128: RPC port from BasicRPCCommunications should be only a starting port, and retried
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3596/ --- (Updated 2012-01-28 03:01:01.809862) Review request for giraph. Changes --- Addressed the mockito suggestion. Summary --- Simple handling of port collisions on the same machine while preserving debugability from the port number alone. Round up the max number of workers to the next power of 10 and use it as a constant to increase the port number with. Added a unit test to ensure it is working correctly. Fixed 2 minor warnings on src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java of removing 'import java.util.List'. This addresses bug GIRAPH-128. https://issues.apache.org/jira/browse/GIRAPH-128 Diffs (updated) - http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1236935 http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java 1236935 http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/comm/RPCCommunicationsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/3596/diff Testing --- Passed local and MR unittests. Thanks, Avery
[jira] [Updated] (GIRAPH-128) RPC port from BasicRPCCommunications should be only a starting port, and retried
[ https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-128: --- Attachment: GIRAPH-128.4.patch Sorry, I missed the mocking question. Fixed it here. RPC port from BasicRPCCommunications should be only a starting port, and retried Key: GIRAPH-128 URL: https://issues.apache.org/jira/browse/GIRAPH-128 Project: Giraph Issue Type: Improvement Affects Versions: 0.1.0 Reporter: Avery Ching Assignee: Avery Ching Attachments: GIRAPH-128.2.patch, GIRAPH-128.3.patch, GIRAPH-128.4.patch Currently Giraph uses a basic port + the task partition to get the RPC port. This doesn't work well for when there are multiple Giraph jobs running simultaneously in the same Hadoop cluster (port conflict). At the same time, it is nice to use this simple algorithm because it makes it very easy to debug problems (you can find the troublesome mapper from the RPC port name). I will be proposing a simple scheme to retry with another port. I will round the total number of mappers up to the nearest power of 10 (let's that that number Z). Then I will increment the port number by Z, retrying up to 20 tries. If you have enough ports, this scheme would guarantee that up to 20 mappers / node would be supported. It should be sufficient for most clusters. At the same time, we still maintain the easy debugging method since you it's still easy to figure out the mapper partition from the port (port % Z = map partition). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-128) RPC port from BasicRPCCommunications should be only a starting port, and retried
[ https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195382#comment-13195382 ] Jakob Homan commented on GIRAPH-128: Great, thanks. +1. RPC port from BasicRPCCommunications should be only a starting port, and retried Key: GIRAPH-128 URL: https://issues.apache.org/jira/browse/GIRAPH-128 Project: Giraph Issue Type: Improvement Affects Versions: 0.1.0 Reporter: Avery Ching Assignee: Avery Ching Attachments: GIRAPH-128.2.patch, GIRAPH-128.3.patch, GIRAPH-128.4.patch Currently Giraph uses a basic port + the task partition to get the RPC port. This doesn't work well for when there are multiple Giraph jobs running simultaneously in the same Hadoop cluster (port conflict). At the same time, it is nice to use this simple algorithm because it makes it very easy to debug problems (you can find the troublesome mapper from the RPC port name). I will be proposing a simple scheme to retry with another port. I will round the total number of mappers up to the nearest power of 10 (let's that that number Z). Then I will increment the port number by Z, retrying up to 20 tries. If you have enough ports, this scheme would guarantee that up to 20 mappers / node would be supported. It should be sufficient for most clusters. At the same time, we still maintain the easy debugging method since you it's still easy to figure out the mapper partition from the port (port % Z = map partition). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
