Re: patches

2005-09-09 Thread Jason Riedy
And Patrick Mauritz writes: - - --- git-core-0.99.5.orig/convert-cache.c Wed Aug 17 09:55:00 2005 - +++ git-core-0.99.5/convert-cache.c Wed Aug 17 09:58:48 2005 - @@ -1,4 +1,5 @@ - #define _XOPEN_SOURCE /* glibc2 needs this */ - +#define __EXTENSIONS__ /* solaris needs this */ To be h

Re: [PATCH] Spell __attribute__ correctly in cache.h.

2005-08-28 Thread Jason Riedy
And Junio C Hamano writes: - > +Replace C99 array initializers with code. - I presume this is to help older compilers? Yes, so it's relatively unimportant. I could work around it in my situation; I only included it because it's "necessary" for some Sun compilers on older Solaris installat

Re: [PATCH] Spell __attribute__ correctly in cache.h.

2005-08-23 Thread Jason Riedy
And Junio C Hamano writes: - > BTW, how would people feel about replacing the - > setenv() and unsetenv() calls with the older putenv()? - No comment on this one at this moment until I do my own digging - a bit. If you're interested, I have a few patches in http://www.cs.berkeley.edu/~ejr/g

Re: [PATCH] Spell __attribute__ correctly in cache.h.

2005-08-19 Thread Jason Riedy
And Junio C Hamano writes: - It turns out that your patch breaks GCC build Whoops, sorry. Your fix works with Sun's cc. BTW, how would people feel about replacing the setenv() and unsetenv() calls with the older putenv()? The Solaris version I have to work on doesn't have the nicer functio

[PATCH] Spell __attribute__ correctly in cache.h.

2005-08-18 Thread Jason Riedy
Sun's cc doesn't know __attribute__. Signed-off-by: Jason Riedy <[EMAIL PROTECTED]> --- cache.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) 4181b19f615b3d56f9fae5f3accd435480aa7d2f diff --git a/cache.h b/cache.h --- a/cache.h +++ b/cache.h @@ -41,7 +41,7 @@ #