Re: [PATCH] Documentation: remove unnecessary backslashes

Hi, On Wed, Jan 20, 2016 at 01:24:21PM -0500, Jeff King wrote: > On Wed, Jan 20, 2016 at 09:21:37AM -0800, Matt Kraai wrote: > > -'@\{\}', e.g. 'master@\{yesterday\}', 'HEAD@\{5 minutes > > ago\}':: > > +'@{}', e.g. 'master@\{yesterday\}', 'HEAD@{5 minutes ago}':: >

[PATCH] Documentation: remove unnecessary backslashes

From: Matthew Kraai asciidoctor does not remove backslashes used to escape curly brackets from the HTML output if the contents of the curly brackets are empty or contain at least a <, -, or space. asciidoc does not require the backslashes in these cases, so just remove

Re: [PATCH] remote-http: use argv-array

Jeff King p...@peff.net writes: On Tue, Jul 09, 2013 at 08:05:19AM +0200, Bert Wesarg wrote: + argv_array_pushl(args, send-pack, --stateless-rpc, --helper-status); missing NULL sentinel. GCC has the 'sentinel' [1] attribute to catch such errors. Or use macro magic: void

Re: [PATCH] Improve QNX support in GIT

Hi Mike, Mike Gorchak wrote: diff --git a/config.mak.uname b/config.mak.uname index 8743a6d..2d42ffe 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -527,14 +527,21 @@ ifeq ($(uname_S),QNX) HAVE_STRINGS_H = YesPlease NEEDS_SOCKET = YesPlease NO_FNMATCH_CASEFOLD =

Re: [PATCH] Improve QNX support in GIT

Hi, Please include me in the Cc field, since I'm not subscribed to the list. Mike Gorchak wrote: Do you have a testcase for this (without using git codebase)? I wrote numerous resource managers since QNX 6.0 using threads and fork()s for daemonization in different order and never experienced

Re: [PATCH] Makefile: don't run rm without any files

On Wed, Feb 13, 2013 at 08:51:45AM -0800, Junio C Hamano wrote: Matt Kraai kr...@ftbfs.org writes: From: Matt Kraai matt.kr...@amo.abbott.com rm -f -r fails on QNX when not passed any files to remove. I do not think it is limited to QNX. the clean target, since dep_dirs is empty

Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

On Mon, Feb 11, 2013 at 04:06:21PM -0500, Jeff King wrote: On Mon, Feb 11, 2013 at 12:59:55PM -0800, Matt Kraai wrote: From: Matt Kraai matt.kr...@amo.abbott.com QNX 6.3.2 through 6.5.0 include Expat 1.1, which provides xmlparse.h instead of expat.h, so include the former on QNX

Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

On Mon, Feb 11, 2013 at 01:34:52PM -0800, Junio C Hamano wrote: Two points and a possibly irrelevant half: - If a fix is platform specific (i.e. tempts to use #ifdef PLATFORM_NAME), we would prefer to see a patch that that is isolated to platform-specific compatibility layer, which

[PATCH] Allow building with xmlparse.h

From: Matt Kraai matt.kr...@amo.abbott.com expat 1.1 and 1.2 provide xmlparse.h instead of expat.h. Include the former on systems that define the EXPAT_NEEDS_XMLPARSE_H variable and define that variable on QNX systems, which ship with expat 1.1. Signed-off-by: Matt Kraai matt.kr

[PATCH] Allow building with xmlparse.h

From: Matt Kraai matt.kr...@amo.abbott.com expat 1.1 and 1.2 provide xmlparse.h instead of expat.h. Include the former on systems that define the EXPAT_NEEDS_XMLPARSE_H variable and define that variable on QNX systems, which ship with expat 1.1. Signed-off-by: Matt Kraai matt.kr

[PATCH] Use __VA_ARGS__ for all of error's arguments

From: Matt Kraai matt.kr...@amo.abbott.com QNX 6.3.2 uses GCC 2.95.3 by default, and GCC 2.95.3 doesn't remove the comma if the error macro's variable argument is left out. Instead of testing for a sufficiently recent version of GCC, make __VA_ARGS__ match all of the arguments. Signed-off

[PATCH] Use __VA_ARGS__ for all of error's arguments

From: Matt Kraai matt.kr...@amo.abbott.com QNX 6.3.2 uses GCC 2.95.3 by default, and GCC 2.95.3 doesn't remove the comma if the error macro's variable argument is left out. Instead of testing for a sufficiently recent version of GCC, make __VA_ARGS__ match all of the arguments. Since

Re: [PATCH] Use __VA_ARGS__ for all of error's arguments

On Thu, Feb 07, 2013 at 01:05:19PM -0800, Junio C Hamano wrote: Matt Kraai kr...@ftbfs.org writes: -#if defined(__GNUC__) ! defined(__clang__) -#define error(fmt, ...) (error((fmt), ##__VA_ARGS__), -1) -#endif +#define error(...) (error(__VA_ARGS__), -1) Before your change, we only

[PATCH] Use __VA_ARGS__ for all of error's arguments

From: Matt Kraai matt.kr...@amo.abbott.com QNX 6.3.2 uses GCC 2.95.3 by default, and GCC 2.95.3 doesn't remove the comma if the error macro's variable argument is left out. Instead of testing for a sufficiently recent version of GCC, make __VA_ARGS__ match all of the arguments. Signed-off

Re: [PATCH] Use __VA_ARGS__ for all of error's arguments

On Thu, Feb 07, 2013 at 11:24:28PM -0500, Jeff King wrote: Should you be dropping most of the comment like this? I would expect it to be more like: We have to restrict this trick to gcc, though, because we do not assume all compilers support variadic macros. But since... I'll submit a

Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()

On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) +static struct imap_list *parse_list(char **sp) The commit subject refers to imap_parse_list and imap_list whereas the code refers to parse_imap_list and

Re: [PATCH] tests: turn on test-lint-shell-syntax by default

On Sun, Jan 13, 2013 at 11:25:57AM +0100, Torsten Bögershausen wrote: @@ -16,10 +16,10 @@ sub err { while () { chomp; - /^\s*sed\s+-i/ and err 'sed -i is not portable'; - /^\s*echo\s+-n/ and err 'echo -n is not portable (please use printf)'; - /^\s*declare\s+/ and err

Re: [PATCH] Support FTP-over-SSL/TLS for regular FTP

On Sat, Jan 12, 2013 at 03:59:52PM +0200, Modestas Vainius wrote: @@ -306,6 +311,11 @@ static CURL *get_curl_handle(void) if (curl_ftp_no_epsv) curl_easy_setopt(result, CURLOPT_FTP_USE_EPSV, 0); +#ifdef CURLOPT_USE_SSL +if (curl_ssl_try) +

Re: [PATCH v2 03/21] Export parse_pathspec() and convert some get_pathspec() calls

On Fri, Jan 11, 2013 at 06:20:57PM +0700, Nguyễn Thái Ngọc Duy wrote: +#define PATHSPEC_FROMTOP(10) The previous commit introduces a use of this macro in get_pathspec. Should this be defined by that commit instead? @@ -266,9 +266,9 @@ static int pathspec_item_cmp(const void *a_, const void

Re: [PATCH 03/19] reset.c: pass pathspec around instead of (prefix, argv) pair

On Wed, Jan 09, 2013 at 12:16:00AM -0800, Martin von Zweigbergk wrote: We use the path arguments in two places in reset.c: in interactive_reset() and read_from_tree(). Both of these call get_pathspec(), so we pass the (prefix, arv) pair to both ^^^ argv

Re: [PATCH 07/19] reset.c: extract function for updating {ORIG,}HEAD

In the summary, {ORIG,} should be {ORIG_,}. -- Matt -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

t0024-crlf-archive.sh and t5000-tar-tree.sh, something like the following (modulo UNZIP/GIT_UNZIP)? -- Matt Kraai https://ftbfs.org/kraai diff --git a/t/t0024-crlf-archive.sh b/t/t0024-crlf-archive.sh index ec6c1b3..084f33c 100755 --- a/t/t0024-crlf-archive.sh +++ b/t/t0024-crlf-archive.sh

Re: [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD

these problems. Is there a way to do so using sparse? + n = backtrace(buffer, 100); + symbols = backtrace_symbols(buffer, n); + if (symbols) { + for (i = 0;i n; i++) s/;i/; i/ -- Matt Kraai https://ftbfs.org/kraai -- To unsubscribe

Re: [PATCH] Remove duplicate entry in ./Documentation/Makefile

the results by hand, but this only checked lines containing +=. -- Matt Kraai https://ftbfs.org/kraai -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 0/2] Port to QNX

This series ports Git to QNX. It differs from the previous version in that: * it's rebased on dm/port, so it narrows the scope of the lock variable in builtin/fetch-pack.c instead of fetch-pack.c and uses HAVE_STRINGS_H; and * it disables use of Pthreads, since fork(2) doesn't work once

[PATCH v2 1/2] Make lock local to fetch_pack

From: Matt Kraai matt.kr...@amo.abbott.com lock is only used by fetch_pack, so move it into that function. Signed-off-by: Matt Kraai matt.kr...@amo.abbott.com --- builtin/fetch-pack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builtin/fetch-pack.c b/builtin/fetch

[PATCH v2 2/2] Port to QNX

From: Matt Kraai matt.kr...@amo.abbott.com Signed-off-by: Matt Kraai matt.kr...@amo.abbott.com --- Makefile | 21 + git-compat-util.h | 6 +- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 2c1f04f..a39dc83 100644

Re: What's cooking in git.git (Dec 2012, #04; Sun, 16)

builds fine when sys/param.h is not included. -- Matt Kraai https://ftbfs.org/kraai -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] Port to QNX

On Sat, Dec 15, 2012 at 10:38:30AM -0800, Junio C Hamano wrote: I do not mind queuing this on 'pu' but do you want to see your ftbfs.org address in the commit objects, or the other one that you are not using to interact with us? Great! I'd prefer to use the amo.abbott.com address in the

[PATCH 2/2] Port to QNX

From: Matt Kraai matt.kr...@amo.abbott.com Signed-off-by: Matt Kraai matt.kr...@amo.abbott.com --- Makefile | 19 +++ git-compat-util.h | 8 ++-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 736ecd4..ed2539d 100644

[PATCH 0/2] Port to QNX

This series ports Git to QNX. It builds on both QNX 6.3.2 and QNX 6.5.0. The test suite does not pass. Unless the corresponding software is installed, the following arguments must be passed to Make: NO_CURL=1 NO_GETTEXT=1 NO_OPENSSL=1 NO_PERL=1 NO_PYTHON=1 NO_TCLTK=1 [1/2]: Make lock local

[PATCH 1/2] Make lock local to fetch_pack

From: Matt Kraai matt.kr...@amo.abbott.com lock is only used by fetch_pack, so move it into that function. Signed-off-by: Matt Kraai matt.kr...@amo.abbott.com --- fetch-pack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fetch-pack.c b/fetch-pack.c index 099ff4d

[PATCH] docs: move submodule section

293ab15e (submodule: teach rm to remove submodules unless they contain a git directory, 2012-09-26) inserted the Submodules section between a sentence describing a command and the command. Move the Submodules section further down. Signed-off-by: Matt Kraai kr...@ftbfs.org --- Documentation/git

Re: [PATCH] docs: move submodule section

On Wed, Nov 14, 2012 at 10:49:04AM -0800, Matt Kraai wrote: 293ab15e (submodule: teach rm to remove submodules unless they contain a git directory, 2012-09-26) inserted the Submodules section between a sentence describing a command and the command. Move the Submodules section further down

Re: [PATCH 1/5] t/test-lib-functions.sh: allow to specify the tag name to test_commit

On Wed, Nov 14, 2012 at 05:37:50PM -0800, Brandon Casey wrote: -# Both file and contents default to message. +# Both file contents and tag default to message. I think this line would be better as # file, contents, and tag all default to message. since there's now more than two arguments that

[PATCH] git-credential-gnome-keyring: Remove die

git-credential-gnome-keyring defines die, but it is unused and incorrect (it passes a va_list to error, which does not expect one), so remove it. Signed-off-by: Matt Kraai kr...@ftbfs.org --- .../credential/gnome-keyring/git-credential-gnome-keyring.c | 10 -- 1 file changed, 10

Re: [PATCH] parse_dirstat_params(): use string_list to split comma-separated string

On Wed, Oct 31, 2012 at 10:06:36AM -0400, Jeff King wrote: On Tue, Oct 30, 2012 at 06:43:51PM +, Matt Kraai wrote: Michael Haggerty mhagger at alum.mit.edu writes: + if (*params_copy) params_copy is set to the value returned by xstrdup, which cannot be NULL. This check can

Re: [PATCH] parse_dirstat_params(): use string_list to split comma-separated string

Michael Haggerty mhagger at alum.mit.edu writes: ... -static int parse_dirstat_params(struct diff_options *options, const char ... +static int parse_dirstat_params(struct diff_options *options, const char ... struct strbuf *errmsg) { - const char *p =