2013/12/31 Roman Kagan :
> 2013/12/30 Junio C Hamano :
>> Roman Kagan writes:
>>> I'd like to note that it's IMO worth including in the 'maint' branch
>>> as it's a crasher. Especially so since the real fix has been merged
>>> in
2013/12/30 Junio C Hamano :
> Roman Kagan writes:
>> I'd like to note that it's IMO worth including in the 'maint' branch
>> as it's a crasher. Especially so since the real fix has been merged
>> in the subversion upstream and nominated for 1.8
2013/12/30 Thomas Rast :
> Roman Kagan writes:
>
>> + # workaround for a bug in svn serf backend (v1.8.5 and below):
>> + # store 3d argument to ->add_file() in a local variable, to make it
>> + # have the same lifetime as $fbat
>> + my $
nd (2013-12-27 20:22:19
>> +)
>>
>> ----
>> Roman Kagan (1):
>> git-svn: workaround for a bug in svn serf backend
>>
>> perl/Git/SVN/Editor.pm | 10 --
>> 1 file changed, 8 insertions(+), 2 deletions(-)
&g
by storing the value to be passed as
the third argument to add_file() in a local variable with the same scope
as the file change descriptor, making sure their lifetime is the same.
Cc: Benjamin Pabst
Cc: Eric Wong
Cc: Jonathan Nieder
Signed-off-by: Roman Kagan
---
changes since v1:
- fix gram
2013/12/27 Roman Kagan :
> 2013/12/27 Jonathan Nieder :
>> Could this be reproduced with a test script to make sure we don't
>> reintroduce the bug again later? (It's okay if the test only fails on
>> machines with the problematic svn version.)
>
> That woul
2013/12/27 Jonathan Nieder :
> Roman Kagan wrote:
>
>> Subversion serf backend in versions 1.8.5 and below has a bug that the
>> function creating the descriptor of a file change -- add_file() --
>> doesn't make a copy of its 3d argument when storing it on the return
d-off-by: Roman Kagan
---
perl/Git/SVN/Editor.pm | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/perl/Git/SVN/Editor.pm b/perl/Git/SVN/Editor.pm
index b3bcd47..ae399c3 100644
--- a/perl/Git/SVN/Editor.pm
+++ b/perl/Git/SVN/Editor.pm
@@ -304,8 +304,12 @@ sub C {
2013/12/25 Roman Kagan :
> 2013/12/25 Roman Kagan :
>> I've hit this problem too, and tracked it down to what I think is a
>> bug in svn.
>> [...]
>> I'm going to submit a patch adding apr_pstrdup() to subversion folks.
>
> http://thread.gmane.org/gmane.c
2013/12/25 Roman Kagan :
> I've hit this problem too, and tracked it down to what I think is a
> bug in svn.
> [...]
> I'm going to submit a patch adding apr_pstrdup() to subversion folks.
http://thread.gmane.org/gmane.comp.version-control.subversion.devel/145186
Roman.
Benjamin Pabst gmail.com> writes:
> is it possible to debug git-svn or get a more verbose / debug output
> from it? I already tried with the "GIT_TRACE" variable, but it does
> not include any further output on the svn methods.
I've hit this problem too, and tracked it down to what I think is a
b
11 matches
Mail list logo
