[PATCH] NUL terminate the object data in patch_delta()

2005-09-04 Thread Sergey Vlasov
patch_delta() did not do it, which caused problems with, e.g., git-rev-list --pretty when there are delta-compressed commit objects. Signed-off-by: Sergey Vlasov <[EMAIL PROTECTED]> --- Actually I noticed the problem when trying to do "git log ^v2.6.12 v2.6.13" on the linux-2.6

Re: please pull ppc64-2.6.git

2005-08-31 Thread Sergey Vlasov
On Tue, 30 Aug 2005 15:25:22 -0700 Junio C Hamano wrote: > Christian Meder <[EMAIL PROTECTED]> writes: > > > Is alternates unthinkable with URLs (e.g. remote alternates). > > In order to read an object data, the low level core GIT layer > does open()/mmap() of a file on the locally mounted files

[PATCH] git-rev-list: avoid crash on broken repository

2005-08-19 Thread Sergey Vlasov
When following tags, check for parse_object() success and error out properly instead of segfaulting. Signed-off-by: Sergey Vlasov <[EMAIL PROTECTED]> --- rev-list.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) f4ec41063d2f43b06b7c8e511108b4c9bf9e6ebe diff --git a/rev-li

[RFC] [PATCH] Add "--compression-level=N" option to git-pack-objects

2005-08-13 Thread Sergey Vlasov
Signed-off-by: Sergey Vlasov <[EMAIL PROTECTED]> --- Documentation/git-pack-objects.txt | 14 +- csum-file.c|5 +++-- csum-file.h|2 +- pack-objects.c | 15 +-- 4 files changed, 30

[RFC] Improving compression in git network protocols

2005-08-13 Thread Sergey Vlasov
(it will need to reconstruct all objects represented by deltas to find their hash values). BTW, it could be possible to improve the global compression even more by optimizing the order of objects in the pack file (currently trees and blobs seems to be intermixed). I did not try this yet,

Re: Fwd: Re: git checkout -f branch doesn't remove extra files

2005-08-13 Thread Sergey Vlasov
and, what's more important, it actually uses some information from the passed commit (it writes the commit ID to the tar file as an extended header, and sets timestamp of all archive members to the time of the commit). Therefore reducing the ID passed to git-tar-tree to a plain tree ID is

[PATCH 4/4] Plug memory leak in git-pack-objects

2005-08-08 Thread Sergey Vlasov
[PATCH] Plug memory leak in git-pack-objects find_deltas() should free its temporary objects before returning. Signed-off-by: Sergey Vlasov <[EMAIL PROTECTED]> --- pack-objects.c |4 1 files changed, 4 insertions(+), 0 deletions(-) 8b38f80b97affd0d9808b8f276a9e2e04bf03464 diff

[PATCH 3/4] Plug memory leak in sha1close()

2005-08-08 Thread Sergey Vlasov
[PATCH] Plug memory leak in sha1close() sha1create() and sha1fd() malloc the returned struct sha1file; sha1close() should free it. Signed-off-by: Sergey Vlasov <[EMAIL PROTECTED]> --- csum-file.c |1 + 1 files changed, 1 insertions(+), 0 del

[PATCH 2/4] Plug memory leak in write_sha1_to_fd()

2005-08-08 Thread Sergey Vlasov
[PATCH] Plug memory leak in write_sha1_to_fd() If the object to write was packed, both its uncompressed and compressed data were leaked. If the object was not packed, its file was not unmapped. Signed-off-by: Sergey Vlasov <[EMAIL PROTECTED]> --- sha1_file.c | 14 -- 1

[PATCH 1/4] Plug memory leak in read_object_with_reference()

2005-08-08 Thread Sergey Vlasov
[PATCH] Plug memory leak in read_object_with_reference() When following a reference, read_object_with_reference() did not free the intermediate object data. Signed-off-by: Sergey Vlasov <[EMAIL PROTECTED]> --- sha1_file.c |1 + 1 files changed, 1 insertions(+), 0 del

[PATCH 0/4] Plug some more memory leaks in git

2005-08-08 Thread Sergey Vlasov
Hello! This set of patches fixes some more memory leaks which I have found in git. Especially the write_sha1_to_fd() leak was noticeable when running git-ssh-push. -- Sergey Vlasov pgpHMTIIDB3N1.pgp Description: PGP signature

Re: Request for help from binary packaging people.

2005-08-08 Thread Sergey Vlasov
On Mon, 08 Aug 2005 10:38:44 -0700 Junio C Hamano wrote: > For RPM, from my lack of RPM expertise (and RPM capable > environment until recently), I have not updated the "Prereq:" > field in git-core.spec.in at all. That "Prereq:" should be "Requires:" instead. "Prereq:" also enforces installatio

[PATCH] Plug memory leaks in git-unpack-objects

2005-08-03 Thread Sergey Vlasov
- Call inflateEnd to release zlib state after use. - After resolving delta, free base object data. Signed-off-by: Sergey Vlasov <[EMAIL PROTECTED]> --- unpack-objects.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) 890ab530c0c0aad5c070690498d3b1254c7a30bc diff --git a/

Re: [PATCH 1/3] Add git-send-email-script - tool to send emails from git-format-patch-script

2005-07-31 Thread Sergey Vlasov
On Sun, 31 Jul 2005 04:17:25 -0400 Ryan Anderson wrote: > This is based off of GregKH's script, send-lots-of-email.pl, and > strives to do all the nice things a good subsystem maintainer does > when forwarding a patch or 50 upstream: > > All the prior handlers of the patch, as determined by

gitk merge display bugs (was: Re: Display of merges in gitk)

2005-07-30 Thread Sergey Vlasov
On Fri, 29 Jul 2005 20:51:40 -0500 Paul Mackerras wrote: > I have reworked the way gitk displays merges. I have found a reproducible bug in gitk which seems to be in that new code for merges. Run gitk f4b3a4c30b5ea3a5de2a2597a3c53266017d02ba on the git or cogito repository (that commit