On Wed, 01 May 2013 11:38:47 -0700 Junio C Hamano gits...@pobox.com wrote:
JCH Felipe Contreras felipe.contre...@gmail.com writes:
On Wed, May 1, 2013 at 11:39 AM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
So let's go ahead and apply these
Simple patch to avoid unitialized warning and log what we'll do.
---
contrib/credential/netrc/git-credential-netrc | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/contrib/credential/netrc/git-credential-netrc
b/contrib/credential/netrc/git-credential-netrc
index
On Tue, 3 Sep 2013 13:35:44 -0400 Jeff King p...@peff.net wrote:
JK On Tue, Sep 03, 2013 at 11:23:14AM -0400, Ted Zlatanov wrote:
Yes, you're right. Something like the following (untested) could work
and does the wildcards, which I will make into a proper patch and test
if it looks OK to you
On Tue, 8 Oct 2013 12:41:47 -0700 Jonathan Nieder jrnie...@gmail.com wrote:
JN Ted Zlatanov wrote:
Simple patch to avoid unitialized warning and log what we'll do.
JN Sign-off?
I didn't realize it was a requirement, must I?
JN [...]
--- a/contrib/credential/netrc/git-credential-netrc
Simple patch to avoid unitialized warning and log what we'll do.
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
contrib/credential/netrc/git-credential-netrc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/credential/netrc/git-credential-netrc
b/contrib
On Tue, 08 Oct 2013 21:58:41 +0200 Stefan Beller stefanbel...@googlemail.com
wrote:
SB On 10/08/2013 09:55 PM, Ted Zlatanov wrote:
JN Sign-off?
I didn't realize it was a requirement, must I?
SB Yes, this is a requirement. See Documentation/SubmittingPatches
SB to read what signing off
On Tue, 8 Oct 2013 13:02:35 -0700 Jonathan Nieder jrnie...@gmail.com wrote:
JN Ted Zlatanov wrote:
On Tue, 8 Oct 2013 12:41:47 -0700 Jonathan Nieder jrnie...@gmail.com
wrote:
JN Ted Zlatanov wrote:
Simple patch to avoid unitialized warning and log what we'll do.
JN Sign-off?
I didn't
On Tue, 20 Aug 2013 12:28:39 -0700 Junio C Hamano gits...@pobox.com wrote:
JCH Ted Zlatanov t...@lifelogs.com writes:
A while has passed since contrib/credential/netrc was added. Is it OK to
promote it to be part of the main installation?
JCH I gave it a quick glance, and it seems
On Tue, 27 Aug 2013 16:05:51 -0400 Jeff King p...@peff.net wrote:
JK On Mon, Aug 26, 2013 at 08:56:23PM -0700, Junio C Hamano wrote:
Antoine Pelisse apeli...@gmail.com writes:
I've tried to use the netrc credential with git-send-email
(v1.8.4-rc2), and I've had the following log (running
A while has passed since contrib/credential/netrc was added. Is it OK to
promote it to be part of the main installation? In that directory
there's also gnome-keyring, osxkeychain, and wincred; I don't know if
those are ready for promotion.
Thanks
Ted
--
To unsubscribe from this list: send the
This credential helper supports multiple files, returning the first one
that matches. It checks file permissions and owner. For *.gpg files,
it will run GPG to decrypt the file.
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
Changes since PATCHv6:
- change Makefile test to test.pl (using
On Fri, 8 Feb 2013 01:18:55 -0500 Jeff King p...@peff.net wrote:
+# the following check is copied from Net::Netrc, for non-GPG files
+# OS/2 and Win32 do not handle stat in a way compatable with this check
:-(
JK s/compatable/compatible/
This is from the Net::Netrc module. Fixed
On Sat, 9 Feb 2013 05:58:47 -0500 John Szakmeister j...@szakmeister.net
wrote:
JS On Thu, Feb 7, 2013 at 9:46 AM, Ted Zlatanov t...@lifelogs.com wrote:
On Thu, 27 Oct 2011 12:05:03 -0400 John Szakmeister j...@szakmeister.net
wrote:
JS Just wanted to keep folks in the loop. It turns out
On Thu, 07 Feb 2013 08:08:59 +0100 Matthieu Moy matthieu@grenoble-inp.fr
wrote:
MM Plus, read/write has already been used for a while in the C API, so I'd
MM rather keep the same names for the Perl equivalent.
That makes perfect sense.
Ted
--
To unsubscribe from this list: send the line
On Sat, 10 Nov 2012 23:12:50 +0800 乙酸鋰 ch3co...@gmail.com wrote:
In credential.c, line 67:
if (!strcmp(key, helper))
string_list_append(c-helpers, value);
In global config, I add one credential helper.
But I do not want to use any credential helper in a specific repository.
On Thu, 27 Oct 2011 12:05:03 -0400 John Szakmeister j...@szakmeister.net
wrote:
JS Just wanted to keep folks in the loop. It turns out that the Secrets
JS API is still to young. I asked about the format to store credentials
JS in (as far as attributes), and got a response from a KDE developer
On Thu, 07 Feb 2013 10:23:20 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Clear everything you saw so far would be useful for variables
JCH other than credential.helper; shouldn't it be done by adding a
JCH general syntax to the configuration file format and teach the
JCH configuration
On Thu, 07 Feb 2013 15:52:41 -0800 Junio C Hamano gits...@pobox.com wrote:
+@echo = Look for any entry in the default file set
+echo | ./git-credential-netrc -d -v get
+@echo = Look for github.com in the default file set
+echo host=google.com | ./git-credential-netrc -d -v
On Wed, 06 Feb 2013 14:26:46 +0100 Michal Nazarewicz min...@mina86.com wrote:
MN On Wed, Feb 06 2013, Junio C Hamano gits...@pobox.com wrote:
I see a lot of rerolls on the credential helper front, but is there
anybody working on hooking send-email to the credential framework?
MN I assumed
On Wed, 06 Feb 2013 09:11:17 +0100 Matthieu Moy matthieu@grenoble-inp.fr
wrote:
MM Junio C Hamano gits...@pobox.com writes:
I see a lot of rerolls on the credential helper front, but is there
anybody working on hooking send-email to the credential framework?
MM Not answering the
On Mon, 04 Feb 2013 15:10:45 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Ted Zlatanov t...@lifelogs.com writes:
JCH I thought that we tend to avoid Emacs/Vim formatting cruft left in
JCH the file. Do we have any in existing file outside contrib/?
No, but it's a nice way to express
On Wed, 06 Feb 2013 16:10:12 +0100 Matthieu Moy matthieu@grenoble-inp.fr
wrote:
MM Ted Zlatanov t...@lifelogs.com writes:
MM [...] so the way to go for send-email is probably to libify the
MM credential support in git-remote-mediawiki, and to use it in send-email.
I looked and that's
On Wed, 06 Feb 2013 17:41:01 +0100 Matthieu Moy matthieu@grenoble-inp.fr
wrote:
MM Ted Zlatanov t...@lifelogs.com writes:
- sort the output tokens (after 'url' is extracted) so the output is
consistent and testable
MM Why not, if you want to use the output of credential_write in tests
Update the coding guidelines for Perl 5.
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
Documentation/CodingGuidelines | 44
1 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/Documentation/CodingGuidelines b/Documentation
On Wed, 06 Feb 2013 08:29:30 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Is it ever (as opposed to not always) possible to omit braces?
Oh yes! Not that I recommend it, and I'm not even going to touch on
Perl Golf :)
JCH It sounds as if we encourage the use of statement modifiers, which
On Wed, 06 Feb 2013 10:16:21 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH I'd suggest to just drop that try to write without braces entirely.
OK, I'll do it on the reroll, or you can just make the change directly.
I agree it was not going anywhere :)
Ted
diff --git
On Wed, 6 Feb 2013 19:25:43 +0100 demerphq demer...@gmail.com wrote:
d On 6 February 2013 19:05, Ted Zlatanov t...@lifelogs.com wrote:
On Wed, 06 Feb 2013 08:29:30 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Is it ever (as opposed to not always) possible to omit braces?
Oh yes
On Wed, 6 Feb 2013 19:44:16 +0100 demerphq demer...@gmail.com wrote:
d Ah ok. Right, at a low level:
d if (condition) { do_this() }
d is identical to
d condition do_this();
d IOW, Perl allows logical operators to act as control flow statements.
d I hope your document include something that
Update the coding guidelines for Perl 5.
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
Changes since PATCHv1:
- removed brace guidelines
- add don't try to be clever at beginning
Documentation/CodingGuidelines | 42
1 files changed, 42 insertions
On Wed, 6 Feb 2013 16:57:24 -0500 Jeff King p...@peff.net wrote:
JK On Wed, Feb 06, 2013 at 10:58:13AM -0500, Ted Zlatanov wrote:
MM I don't know about the netrc credential helper, but I guess that's
MM another layer. The git-remote-mediawiki code is the code to call the
MM credential C API
On Tue, 05 Feb 2013 08:15:48 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Ted Zlatanov t...@lifelogs.com writes:
+# build reverse token map
+my %rmap;
+foreach my $k (keys %{$options{tmap}}) {
+push @{$rmap{$options{tmap}-{$k}}}, $k;
+}
JCH Mental note: $rmap{foo} -eq 'bar' means
log_debug() and -d for logging for the developer
- use Net::Netrc parser and `man netrc' to improve parsing
- ignore 'default' and 'macdef' netrc entries
- require 'machine' token in netrc lines
- ignore netrc files with bad permissions or owner (from Net::Netrc)
Signed-off-by: Ted Zlatanov t
On Tue, 05 Feb 2013 11:47:56 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Ted Zlatanov t...@lifelogs.com writes:
JCH Oh, another thing. 'default' is like 'machine' followed by any
JCH machine name, so the above while loop that reads two tokens
JCH pair-wise needs to be aware that 'default
On Tue, 05 Feb 2013 11:53:20 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Ted Zlatanov t...@lifelogs.com writes:
Changes since PATCHv3:
- simple tests in Makefile
- support multiple files, code refactored
- documentation and comments updated
- fix IO::File for GPG pipe
- exit
Add Git credential helper that can parse netrc/authinfo files.
This credential helper support multiple files, returning the first one
that matches. It checks file permissions and owner. For *.gpg files,
it will run GPG to decrypt the file.
Signed-off-by: Ted Zlatanov t...@lifelogs.com
Add Git credential helper that can parse netrc/authinfo files.
This credential helper supports multiple files, returning the first one
that matches. It checks file permissions and owner. For *.gpg files,
it will run GPG to decrypt the file.
Signed-off-by: Ted Zlatanov t...@lifelogs.com
On Sun, 3 Feb 2013 14:41:49 -0500 Jeff King p...@peff.net wrote:
JK On Sat, Feb 02, 2013 at 06:57:29AM -0500, Ted Zlatanov wrote:
If the file name ends with .gpg, it will run gpg --decrypt FILE and
use the output. So non-interactively, that could hang if GPG was
waiting for input. Does Git
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
contrib/credential/netrc/git-credential-netrc | 242 +
1 files changed, 242 insertions(+), 0 deletions(-)
create mode 100755 contrib/credential/netrc/git-credential-netrc
diff --git a/contrib/credential/netrc/git
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
contrib/credential/netrc/git-credential-netrc |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/contrib/credential/netrc/git-credential-netrc
b/contrib/credential/netrc/git-credential-netrc
index 92fc306..a47a223 100755
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
contrib/credential/netrc/git-credential-netrc | 38 +
1 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/contrib/credential/netrc/git-credential-netrc
b/contrib/credential/netrc/git-credential-netrc
index
Grr, sorry for the bad formatting. First time doing format-patch.
Ted
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 04 Feb 2013 17:33:58 +0100 Michal Nazarewicz min...@mina86.com wrote:
MN As far as I understand, there could be a git-credential helper that
MN reads ~/.authinfo and than git-send-email would just call “git
MN credential fill”, right?
MN I've noticed though, that git-credential does not
, and apologize for
the inconvenience.
JCH Ted Zlatanov t...@lifelogs.com writes:
+foreach my $v (values %{$options{tmap}})
+{
+ $options{tmap}-{$v} = $v;
+}
JCH Please follow the styles of existing Perl scripts, e.g. indent with
JCH tab, etc. Style requests are not optional; it is a prerequisite
On Mon, 04 Feb 2013 09:27:46 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Ted Zlatanov t...@lifelogs.com writes:
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
contrib/credential/netrc/git-credential-netrc | 38
+
1 files changed, 20 insertions(+), 18
On Mon, 04 Feb 2013 11:06:16 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Ted Zlatanov t...@lifelogs.com writes:
Sorry, I didn't realize contrib/ stuff was under the same rules.
JCH I had a feeling that this may start out from contrib/ but will soon
JCH prove to be fairly important
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
contrib/credential/netrc/git-credential-netrc | 223 +
1 files changed, 223 insertions(+), 0 deletions(-)
create mode 100755 contrib/credential/netrc/git-credential-netrc
diff --git a/contrib/credential/netrc/git
On Mon, 4 Feb 2013 15:10:40 -0500 Jeff King p...@peff.net wrote:
JK Technically you can speak a particular protocol on an alternate port:
JK https://example.com:31337/repo.git
JK In this case, git will send you the host as:
JK example.com:31337
JK You might want to map this to port in
On Mon, 4 Feb 2013 15:59:11 -0500 Jeff King p...@peff.net wrote:
JK On Mon, Feb 04, 2013 at 03:28:52PM -0500, Ted Zlatanov wrote:
JK You might want to map this to port in .autoinfo separately if it's
JK available.
That would create the following possibilities:
* host example.com:31337
On Mon, 4 Feb 2013 16:17:26 -0500 Jeff King p...@peff.net wrote:
JK Do you need to quote \n here?
Fixed.
JK Hmm, so it's not an error (just a warning) to say:
JK git credential-netrc -f /does/not/exist
JK but it is an error to say:
JK git credential-netrc
JK and have it fail to find
On Mon, 4 Feb 2013 16:22:03 -0500 Jeff King p...@peff.net wrote:
Currently, we map both the port and protocol netrc tokens to the
credential helper protocol's protocol. So this will have undefined
results. To do what you specify could be pretty simple: we could do a
preliminary scan of the
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
contrib/credential/netrc/git-credential-netrc | 236 +
1 files changed, 236 insertions(+), 0 deletions(-)
create mode 100755 contrib/credential/netrc/git-credential-netrc
diff --git a/contrib/credential/netrc/git
Signed-off-by: Ted Zlatanov t...@lifelogs.com
---
contrib/credential/netrc/git-credential-netrc | 243 +
1 files changed, 243 insertions(+), 0 deletions(-)
create mode 100755 contrib/credential/netrc/git-credential-netrc
diff --git a/contrib/credential/netrc/git-credential
On Mon, 04 Feb 2013 14:56:06 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH I recall that netrc/authinfo files are _not_ line oriented. Earlier
JCH you said looks for entries that match which is a lot more correct,
JCH but then we see look for lines in authfile.
Hmm, do you mean backslashed
On Mon, 4 Feb 2013 18:23:17 -0500 Jeff King p...@peff.net wrote:
Perhaps -r $file, if you say is not accessible?
JK Even better: look at whether opening the file was successful. Though I
JK guess that is complicated by the use of gpg, who will probably not
JK distinguish ENOENT from other
On Mon, 04 Feb 2013 15:40:32 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Sorry we couldn't sounded like an error messag to me. If this is
JCH a normal exit, then please make sure it is a normal exit.
OK; done in PATCHv4: removed all Sorry because they are not abnormal
exits. I'll hold
On Thu, 31 Jan 2013 14:38:45 -0500 Jeff King p...@peff.net wrote:
JK On Thu, Jan 31, 2013 at 10:23:51AM -0500, Ted Zlatanov wrote:
Jeff, is there a way for git-credential to currently support
authinfo/netrc parsing? I assume that's the right way, instead of using
Michal's proposal to parse
On Wed, 30 Jan 2013 07:57:29 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Jeff King p...@peff.net writes:
But it would probably make sense for send-email to support the existing
git-credential subsystem, so that it can take advantage of secure
system-specific storage. And that is where
On Tue, 29 Jan 2013 11:53:19 -0800 Junio C Hamano gits...@pobox.com wrote:
JCH Makes one wonder why .authinfo and not .netrc;
JCH http://www.gnu.org/software/emacs/manual/html_node/auth/Help-for-users.html
JCH phrases it amusingly:
JCH “Netrc” files are usually called .authinfo or
58 matches
Mail list logo
