Re: [PATCH v2 2/2] t0027: Support NATIVE_CRLF

2015-04-17 Thread Torsten Bögershausen
On 2015-04-17 17.44, Torsten Bögershausen wrote: Without this patch, t0027 expects the native end-of-lines to be a single line feed character. On Windows, however, we set it to a carriage return character followed by a line feed character. Thus, we have to modify t0027 to expect different

[PATCH v2 1/2] t0027: Cleanup: rename functions; avoid non-leading TABs

2015-04-17 Thread Torsten Bögershausen
: check_files_in_ws() Replace non-leading TABS with spaces Signed-off-by: Torsten Bögershausen tbo...@web.de --- Changes since v1: - patch 1 is the same - patch 2 is taken from Dscho (but slightly modified) Dscho, please tell if this is not OK with you - patch 3 temporally removed to simplify life

[PATCH v2 2/2] t0027: Support NATIVE_CRLF

2015-04-17 Thread Torsten Bögershausen
-by: Johannes Schindelin johannes.schinde...@gmx.de Signed-off-by: Torsten Bögershausen tbo...@web.de --- t/t0027-auto-crlf.sh | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh index 5858397..8975b97

Re: [PATCH] fast-import: add options to enable/disable case folding

2015-04-17 Thread Torsten Bögershausen
On 04/17/2015 01:52 PM, Mike Hommey wrote: Currently, fast-import does case folding depending on `core.ignorecase`. `core.ignorecase` depends on the file system where the working tree is. However, different kind of imports require different kinds of semantics, and they usually aren't tied

Re: [PATCH] dir: allow a BOM at the beginning of exclude files

2015-04-16 Thread Torsten Bögershausen
On 2015-04-16 16.05, Carlos Martín Nieto wrote: [] May be it is easier to move this into an own function, like remove_utf8_bom() ? dir.c | 8 +++- t/t7061-wtstatus-ignore.sh | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/dir.c b/dir.c index

[PATCH 3/3] t0027: Add repoMIX and LF_nul

2015-04-15 Thread Torsten Bögershausen
and checking eol coversion does not make much sense (CRLF will stay CRLF). Use the file LF_nul instead: It is handled a binary in auto modes, and when declared as text the LF should be replaced with CRLF Signed-off-by: Torsten Bögershausen tbo...@web.de --- t/t0027-auto-crlf.sh | 155

[PATCH 1/3] t0027: Cleanup: rename functions, avoid TABs

2015-04-15 Thread Torsten Bögershausen
: check_files_in_ws() Replace non-leading TABS with spaces Signed-off-by: Torsten Bögershausen tbo...@web.de --- Before this changes manage to stay on the FINO stack (First In, Never Out), I send them as RFC. t/t0027-auto-crlf.sh | 184 +-- 1 file

[PATCH 2/3] t0027: Adapt check_warning() to MINGW

2015-04-15 Thread Torsten Bögershausen
test_cmp to show which warning is missing (or should'n t be there) Signed-off-by: Torsten Bögershausen tbo...@web.de --- t/t0027-auto-crlf.sh | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh index 5858397

Re: [PATCH 3/3] t0027: Add repoMIX and LF_nul

2015-04-15 Thread Torsten Bögershausen
On 2015-04-15 19.36, Johannes Schindelin wrote: Hi Torsten, On 2015-04-15 19:01, Torsten Bögershausen wrote: t/t0027-auto-crlf.sh | 155 --- I fear that we duplicated work here, due to me working on Git for Windows 2.x and you sending

Re: What's cooking in git.git (Apr 2015, #02; Tue, 14)

2015-04-15 Thread Torsten Bögershausen
On 2015-04-14 23.49, Junio C Hamano wrote: * tg/perf-lib-test-perf-cleanup (2013-09-19) 2 commits - perf-lib: add test_perf_cleanup target - perf-lib: split starting the test from the execution Add test_perf_cleanup shell function to the perf suite, that allows the script writers to

[PATCH/RFC] connect.c: Ignore extra colon after hostname

2015-04-07 Thread Torsten Bögershausen
broken in 86ceb3, allow ssh://user@[2001:db8::1]/repo.git Reported-by: Reid Woodbury Jr. re...@rawsound.com Signed-off-by: Torsten Bögershausen tbo...@web.de --- Thanks everybody else for comments, I was especially not aware about the very details in RFC 3986, and now we should have some TC covering

Re: EOL conversion on checkout for text files only

2015-04-07 Thread Torsten Bögershausen
On 2015-04-06 20.05, Borek Bernard wrote: Hi, I'd like to propose a new behavior around EOL normalization / forcing using gitattributes. My use case is this: I want to ensure that LF line endings are used in the repo *and* in all working directories, on all platforms (in our case, the

Re: [PATCH 1/3] t7300: add tests to document behavior of clean and nested git

2015-04-07 Thread Torsten Bögershausen
On 2015-04-07 21.40, Eric Sunshine wrote: On Mon, Apr 6, 2015 at 7:48 AM, Erik Elfström erik.elfst...@gmail.com wrote: Signed-off-by: Erik Elfström erik.elfst...@gmail.com --- diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh index 99be5d9..cfdf6d4 100755 --- a/t/t7300-clean.sh +++

[PATCH v2] connect.c: Ignore extra colon after hostname

2015-04-07 Thread Torsten Bögershausen
broken in 86ceb3, allow ssh://user@[2001:db8::1]/repo.git Reported-by: Reid Woodbury Jr. re...@rawsound.com Signed-off-by: Torsten Bögershausen tbo...@web.de --- Changes since v1 (Thanks to Eric Sunshine) - typo: s/ment/meant/ - remove wrong test_done connect.c | 2 ++ t/t5500-fetch

Re: [PATCH 2/3] p7300: added performance tests for clean

2015-04-06 Thread Torsten Bögershausen
On 2015-04-06 13.48, Erik Elfström wrote: Signed-off-by: Erik Elfström erik.elfst...@gmail.com --- t/perf/p7300-clean.sh | 37 + 1 file changed, 37 insertions(+) create mode 100755 t/perf/p7300-clean.sh diff --git a/t/perf/p7300-clean.sh

Re: Freeing struct lock_file?

2015-04-04 Thread Torsten Bögershausen
On 2015-04-04 02.24, David Turner wrote: On Fri, 2015-04-03 at 15:01 -0700, Junio C Hamano wrote: David Turner dtur...@twopensource.com writes: Why is it impossible to free struct lock_files? I understand that they become part of a linked list, and that there's an atexit handler that goes

Re: git 2.3.4, ssh: Could not resolve hostname

2015-04-04 Thread Torsten Bögershausen
...@gmail.com wrote: On Apr 2, 2015, at 17:02, Torsten Bögershausen wrote: On 2015-04-02 21.35, Jeff King wrote: On Thu, Apr 02, 2015 at 12:31:14PM -0700, Reid Woodbury Jr. wrote: Ah, understand. Here's my project URL for 'remote origin' with a more meaningful representation of their internal

Re: git 2.3.4, ssh: Could not resolve hostname

2015-04-02 Thread Torsten Bögershausen
On 2015-04-02 21.35, Jeff King wrote: On Thu, Apr 02, 2015 at 12:31:14PM -0700, Reid Woodbury Jr. wrote: Ah, understand. Here's my project URL for 'remote origin' with a more meaningful representation of their internal FQDN: url =

Re: [PATCH/RFC 2/4] t1505: add tests for '-' notation in rev-parse

2015-03-30 Thread Torsten Bögershausen
On 03/30/2015 07:41 PM, Kenny Lee Sin Cheong wrote: Signed-off-by: Kenny Lee Sin Cheong kenny.le...@gmail.com --- t/t1505-rev-parse-last.sh | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/t/t1505-rev-parse-last.sh b/t/t1505-rev-parse-last.sh index

Re: [PATCHv3 3/6] line-log.c: fix a memleak

2015-03-30 Thread Torsten Bögershausen
On 03/31/2015 03:22 AM, Stefan Beller wrote: Signed-off-by: Stefan Beller sbel...@google.com --- line-log.c | 3 +++ 1 file changed, 3 insertions(+) Would it make sense to join 2/6 and 3/6 into a single patch ? Both fix the memleaks in the same file, and the header can be fix memleaks. --

Re: how to make full copy of a repo

2015-03-28 Thread Torsten Bögershausen
On 2015-03-28 03.56, Christoph Anton Mitterer wrote: Hey. I was looking for an ideally simple way to make a full copy of a git repo. Many howtos are floating around on this on the web, with also lots of voodoo. First, it shouldn't be just a clone, i.o.w. - I want to have all refs

Re: [PATCH 4/5] Add tests for git-log --merges=show|hide|only

2015-03-22 Thread Torsten Bögershausen
On 22.03.15 19:28, Koosha Khajehmoogahi wrote: Signed-off-by: Koosha Khajehmoogahi koo...@posteo.de --- t/t4202-log.sh | 141 + 1 file changed, 141 insertions(+) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index 5f2b290..ab6f371

Re: [PATCH 4/5] Add tests for git-log --merges=show|hide|only

2015-03-22 Thread Torsten Bögershausen
Back to the original discussion: +test_expect_success 'log with config log.merges=show' ' +git config log.merges show +git log --pretty=tformat:%s actual +test_cmp both_commits_merges actual +git config --unset log.merges These days I would probably shorten the code, the

[PATCH] t6039: fix broken chain

2015-03-21 Thread Torsten Bögershausen
Add missing %%, detected by the --chain-lint option --- t/t6039-merge-ignorecase.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t6039-merge-ignorecase.sh b/t/t6039-merge-ignorecase.sh index a977653..531850d 100755 --- a/t/t6039-merge-ignorecase.sh +++

Re: [PATCH] t6039: fix broken chain

2015-03-21 Thread Torsten Bögershausen
On 2015-03-21 08.04, Torsten Bögershausen wrote: Add missing %%, detected by the --chain-lint option Oh, early morning typo, should be Add missing , detected by the --chain-lint option (I'll re-run the testsuite with the --chain-lint in a minute, thanks everybody for this nice feature

[PATCH v2] t6039: fix broken chain

2015-03-21 Thread Torsten Bögershausen
Add missing , detected by the --chain-lint option Signed-off-by: Torsten Bögershausen tbo...@web.de --- side note: All other tests passed on jk/test-chain-lint t/t6039-merge-ignorecase.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t6039-merge-ignorecase.sh b/t/t6039

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-16 Thread Torsten Bögershausen
One little question, how to better resend it? Just send v2 for the 1/3 or resend all with v2? Or maybe will be better to make one patch from these 3 pathes? Thank you. My personal suggestion would be: Please wait 24 hours to collect feedback from the different time-zones in the world, where

Re: [PATCH 3/3] t3700-add: added test for --exclude option

2015-03-15 Thread Torsten Bögershausen
+test_expect_success 'Test that git add --exclude works' ' + touch foo + touch bar can be written shorter as foo bar + git add --exclude=bar . Side question: Do we need here ? Or should we test files with white space as well, like this: foo

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Torsten Bögershausen
On 2015-03-15 18.51, Torsten Bögershausen wrote: OPT_BOOL('A', all, addremove_explicit, N_(add changes from all tracked and untracked files)), +{ OPTION_CALLBACK, 0, exclude, exclude_list, N_(pattern), What does pattern mean ? I was too fast, take that back: Documentation

Re: [PATCH RFC 1/3] add: add new --exclude option to git add

2015-03-15 Thread Torsten Bögershausen
On 2015-03-15 14.49, Alexander Kuleshov wrote: Thanks for working on Git, some minor remarks/suggestions inline. This patch introduces new --exclude option for the git add command. This patch is redundant. Shorter may be: Introduce the --exclude option for git add We already have

Re: Is it possible get the tag name of working copy in Git?

2015-03-13 Thread Torsten Bögershausen
On 03/13/2015 08:08 AM, chen chang wrote: I want to use make file auto generate the revision number of working copy from the tag name in git. You should have the tag name, as it is set up before running make, and probably feed into both git checkout tagXXYYXX and the Makefile. If you want the

Re: Surprising interaction of binary and eol gitattributes

2015-03-12 Thread Torsten Bögershausen
On 10.03.15 20:25, Michael Haggerty wrote: On 03/06/2015 10:30 PM, Torsten Bögershausen wrote: Oops, I misunderstood an internal bug report. In seems that it is the following scenario that is incorrect: *.png text=auto eol=crlf Hm, I don't know if we support this combination at all

Re: [PATCH] config.txt: stick to CamelCase naming convention

2015-03-10 Thread Torsten Bögershausen
On 10.03.15 11:39, Nguyễn Thái Ngọc Duy wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- .. while I'm looking at config.txt. I think this is the preferred naming convention for config keys. I think the default is unix-like lowercase, this is what Git itself produces.

Re: [v2 PATCH 2/2] reset: add tests for git reset -

2015-03-10 Thread Torsten Bögershausen
On 2015-03-10 16.38, Sundararajan R wrote: Helped-by: Torsten Bögershausen tbo...@web.de There seems to be an issue that the mail is encoded from (what ? Latin-1) into UTF-8 2 times The easy solution is to remove the line, I'm OK with that, since a review-comment is not necessarily motivating

Re: Surprising interaction of binary and eol gitattributes

2015-03-10 Thread Torsten Bögershausen
On 03/10/2015 11:54 PM, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: Well, that's true, but the eol attribute can regain its effect if binary is followed by text or text=auto. So I guess the simplest question is as follows. Suppose I have the following .gitattributes:

Re: [PATCH 1/3] connect.c: Fix memory leak

2015-03-09 Thread Torsten Bögershausen
On 2015-03-09 17.58, Stefan Beller wrote: Signed-off-by: Stefan Beller sbel...@google.com --- connect.c | 1 + 1 file changed, 1 insertion(+) diff --git a/connect.c b/connect.c index ce0e121..6090211 100644 --- a/connect.c +++ b/connect.c @@ -739,6 +739,7 @@ struct child_process

Re: [PATCH 2/2] Added tests for git reset -

2015-03-09 Thread Torsten Bögershausen
On 03/09/2015 09:46 PM, Sundararajan R wrote: As you had suggested @Junio, I have added the required tests. Please let me know if there is something is I should add. Signed-off-by: Sundararajan R dyou...@gmail.com Thanks-to: Junio C Hamano --- I have added 6 tests to check for the following

Re: Surprising interaction of binary and eol gitattributes

2015-03-06 Thread Torsten Bögershausen
Oops, I misunderstood an internal bug report. In seems that it is the following scenario that is incorrect: *.png text=auto eol=crlf Hm, I don't know if we support this combination at all. The current logic supports auto-detection of text/binary, * text=auto (the files will get the line

Re: Surprising interaction of binary and eol gitattributes

2015-03-05 Thread Torsten Bögershausen
On 2015-03-05 17.38, Michael Haggerty wrote: I would expect that the following .gitattributes file * eol=crlf *.png -text would leave EOL translation turned off for PNG files. In other words, I would expect that explicitly setting -text would take precedence over the fact

Re: Surprising interaction of binary and eol gitattributes

2015-03-05 Thread Torsten Bögershausen
On 03/05/2015 11:08 PM, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: I would expect that the following .gitattributes file * eol=crlf *.png -text would leave EOL translation turned off for PNG files. In other words, I would expect that explicitly

Re: [PATCH 0/5] Retry if fdopen() fails due to ENOMEM

2015-03-05 Thread Torsten Bögershausen
On 03/05/2015 05:07 PM, Michael Haggerty wrote: One likely reason for fdopen() to fail is the lack of memory for allocating a FILE structure. When that happens, try freeing some memory and calling fdopen() again in the hope that it will work the second time. This change was suggested by

Re: [PATCH] xmerge.c: fix xdl_merge to conform with the manual

2015-03-03 Thread Torsten Bögershausen
On 2015-03-03 18.37, Anton Trunov wrote: [] Signed-off-by: Anton Trunov anton.a.trunov at gmail.com Should we use the real email here (with the '@') ? --- t/t3032-merge-recursive-options.sh | 43 ++ xdiff/xmerge.c | 10 - 2

Re: [PATCH v2] diff --shortstat --dirstat: remove duplicate output

2015-03-01 Thread Torsten Bögershausen
On 2015-03-01 08.39, Mårten Kongstad wrote: [] index ed7e093..128f7bf 100755 --- a/t/t4047-diff-dirstat.sh +++ b/t/t4047-diff-dirstat.sh @@ -973,4 +973,15 @@ test_expect_success 'diff.dirstat=future_param,0,lines should warn, but still wo test_i18ngrep -q diff\\.dirstat actual_error

Re: [RFC/PATCH 3/5] connect.c: connect to a remote service with some flags

2015-02-28 Thread Torsten Bögershausen
On 2015-02-28 02.01, Stefan Beller wrote: If this is over git protocol, the flags is appended as the next parameter after host=. If it's ssh, a new argument is appended to the command line. None of the callers use this now though. [sb: originally by pclouds, rebased as jk implemented

Re: [PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git

2015-02-22 Thread Torsten Bögershausen
(Sorry for the spam, a few things need correction already now, and forgot cc: Brian) On 2015-02-21 16.52, Torsten Bögershausen wrote: The ssh:// syntax was added in 2386d65822c91, it accepted ssh://user@2001:db8::1/repo.git, which is now legacy. Over the years the parser was improved

Re: [PATCH v2 2/3] t5601: add more test cases for IPV6

2015-02-22 Thread Torsten Bögershausen
On 02/23/2015 03:50 AM, Junio C Hamano wrote: Torsten Bögershausen tbo...@web.de writes: @@ -359,7 +366,7 @@ done for repo in rep rep/home/project 123 do test_expect_success clone [::1]:$repo ' - test_clone_url [::1]:$repo ::1 $repo + test_clone_url [::1

[PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git

2015-02-21 Thread Torsten Bögershausen
legacy URL's as well, to be backwards compatible, and avoid regressions for users which upgrade an existing installation to a later Git version. Signed-off-by: Torsten Bögershausen tbo...@web.de --- Thanks for the reviews I hope the intention of being backward compatible is a little bit clearer now

[PATCH v2 3/3] t5500: show user name and host in diag-url

2015-02-21 Thread Torsten Bögershausen
Signed-off-by: Torsten Bögershausen tbo...@web.de --- connect.c | 35 +++ t/t5500-fetch-pack.sh | 51 +-- 2 files changed, 56 insertions(+), 30 deletions(-) diff --git a/connect.c b/connect.c index b608976

[PATCH v2 2/3] t5601: add more test cases for IPV6

2015-02-21 Thread Torsten Bögershausen
to be used as a workaround. Test that user@::1 user@[::1] and [user@::1] all do the same. Signed-off-by: Torsten Bögershausen tbo...@web.de --- t/t5601-clone.sh | 57 +++- 1 file changed, 40 insertions(+), 17 deletions(-) diff --git a/t/t5601

Re: git blame swallows up lines in case of mixed line endings

2015-02-21 Thread Torsten Bögershausen
On 2015-02-19 14.48, Sokolov, Konstantin (ext) wrote: Hi Folks, I encounter unexpected behavior in the following case: file content: line1CRLF line2CR line3CRLF line4 This is what I get as console output (on Windows): git blame -s file.txt 7db36436 1) line1 line3436 2) line2

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-02-20 Thread Torsten Bögershausen
On 2015-02-19 20.40, brian m. carlson wrote: On Thu, Feb 19, 2015 at 09:54:52AM -0800, Junio C Hamano wrote: I can see that you do not agree with the If we accept it part (where it refers to allowing [...] was a bug.)---past acceptance was not a bug for you. Do we talk about the same thing

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-02-19 Thread Torsten Bögershausen
On 02/18/2015 07:40 PM, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: On Thu, Jan 22, 2015 at 11:05:29PM +0100, Torsten Bögershausen wrote: We want to support ssh://bmc@2001:470:1f05:79::1/git/bmc/homedir.git/ because e.g. the Git shipped with Debian (1.7.10.4

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-17 Thread Torsten Bögershausen
On 17/02/15 17:58, Fairuzan Roslan wrote: On Feb 17, 2015, at 4:51 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Fairuzan Roslan fairuzan.ros...@gmail.com writes: $ git clone https://github.com/robbyrussell/oh-my-zsh.git Cloning into 'oh-my-zsh'... remote: Counting objects:

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-16 Thread Torsten Bögershausen
On 16.02.15 20:06, Junio C Hamano wrote: Matthieu Moy matthieu@grenoble-inp.fr writes: The issue is that having object and pack files read-only on the filesystem is a safety feature to prevent accidental modifications (even though it's actually not that effective, since brute-force sed

Re: odb_mkstemp's 0444 permission broke write/delete access on AFP

2015-02-16 Thread Torsten Bögershausen
On 02/17/2015 04:22 AM, Fairuzan Roslan wrote: On Feb 17, 2015, at 3:08 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: [ Please, don't top post on this list ] Fairuzan Roslan fairuzan.ros...@gmail.com writes: I don’t see the issue for the owner of his/her own file to have write access.

Re: [msysGit] Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT

2015-02-14 Thread Torsten Bögershausen
On 2015-02-12 23.36, Junio C Hamano wrote: So after discussing this one and queuing the resulting three-patch series jk/sanity that consists of the three patches: * jk/sanity (2015-01-27) 3 commits - test-lib.sh: set prerequisite SANITY by testing what we really need - tests:

Re: EOL handling (EGit/svn/Windows)

2015-02-10 Thread Torsten Bögershausen
On 2015-02-10 11.52, Piotr Krukowiecki wrote: On Tue, Feb 10, 2015 at 6:49 AM, Torsten Bögershausen tbo...@web.de wrote: Which Git versions are you using ? The one I'm testing currently: git version 1.7.9 (cygwin) git version 1.9.0.msysgit.0 (msys) EGit from Eclipse Luna Cygwin git

Re: EOL handling (EGit/svn/Windows)

2015-02-09 Thread Torsten Bögershausen
On 02/09/2015 11:22 PM, Piotr Krukowiecki wrote: Any other suggestions? My, somewhat personally, suggestion: If there is more than one developer, don't use core.autocrlf at all- it is a local setting, which doesn't travel through the repo, and is slightly different in Git Egit, depending on the

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Torsten Bögershausen
On 2015-02-07 17.45, Joachim Schmitz wrote: Hi there While investigating the problem with hung git-upload-pack we think to have found a bug in wrapper.c: #define MAX_IO_SIZE (8*1024*1024) This is then used in xread() to split read()s into suitable chunks. So far so good, but read() is

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Torsten Bögershausen
On 2015-02-07 18.29, Joachim Schmitz wrote: Torsten Bögershausen tboegi at web.de writes: On 2015-02-07 17.45, Joachim Schmitz wrote: snip How about changing wrapper.c like this: #ifndef MAX_IO_SIZE #define MAX_IO_SIZE (8*1024*1024) #endif - and to change

Re: folder naming bug?

2015-02-03 Thread Torsten Bögershausen
On 02/03/2015 07:23 AM, Kevin Coleman wrote: Awesome reply! That makes sense. So basically if I accidentally capitalize a folder name and commit it, I need to be very careful when I correct it. Definitely ran into this problem with my repo and ‘lost’ a few commits before I noticed something

Re: folder naming bug?

2015-02-03 Thread Torsten Bögershausen
On 02/03/2015 05:52 AM, Kevin Coleman wrote: Yes, I am on a Mac. I just tried that, but I don’t think that completely fixed it. As you can see it tracks “foo/bar.md” and then it tracks “Foo/bar.md”. It still tracks both “foo” and “Foo” even tho only “Foo” exists in my dir after the

Re: [PATCH v2 1/4] apply: reject input that touches outside $cwd

2015-02-02 Thread Torsten Bögershausen
If I am allowed to to some load thinking: The commit msh header says: reject input that touches outside $cwd The commit message says: By default, a patch that affects outside the working area And the new command line option is this: --unsafe-paths (Which may be a good choice to pretend

Re: [PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-28 Thread Torsten Bögershausen
On 28.01.15 18:38, Junio C Hamano wrote: On Wed, Jan 28, 2015 at 12:28 AM, Torsten Bögershausen tbo...@web.de wrote: On 27.01.15 23:20, Junio C Hamano wrote: How about extending it like this (not tested)? Thanks, this looks good: the test is more extensive, I can test this next week. -- 8

Re: [PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-28 Thread Torsten Bögershausen
On 27.01.15 23:20, Junio C Hamano wrote: How about extending it like this (not tested)? Thanks, this looks good: the test is more extensive, I can test this next week. -- 8 -- From: Torsten Bögershausen tbo...@web.de Date: Tue, 27 Jan 2015 16:39:01 +0100 Subject: [PATCH] test-lib.sh: set

[PATCH 2/2] test-lib.sh: Dynamic test for the prerequisite SANITY

2015-01-27 Thread Torsten Bögershausen
-by: Torsten Bögershausen tbo...@web.de --- t/test-lib.sh | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 93f7cad..887e986 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1038,8 +1038,23 @@ test_lazy_prereq NOT_ROOT ' # When

[PATCH 1/2] t2026 needs procondition SANITY

2015-01-27 Thread Torsten Bögershausen
When running t0026 as root 'prune directories with unreadable gitdir' fails. Skip this test if SANITY is not set (the use of POSIXPERM is wrong here) Signed-off-by: Torsten Bögershausen tbo...@web.de --- Here is the promised patch, on top of pu: The fix of t0026 is unrelated to all other

Re: [msysGit] Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT

2015-01-23 Thread Torsten Bögershausen
On 2015-01-22 23.07, Junio C Hamano wrote: Torsten Bögershausen tbo...@web.de writes: If I run that sequence manually: chmod 755 . touch x chmod a-w . rm x touch y x is gone, (but shoudn't according to POSIX) y is not created, access denied Good (or is that Sad?). diff --git a/t

Re: [PATCH 7/7] fast-import: minor style fix

2015-01-23 Thread Torsten Bögershausen
On 2015-01-23 12.08, Alexander Kuleshov wrote: .. Asterisk must be next with variable .. But this is a function: -static char* make_fast_import_path(const char *path) +static char *make_fast_import_path(const char *path) (Sorry when I need to read this:) - Fixing style violations while

Re: [msysGit] Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT

2015-01-22 Thread Torsten Bögershausen
On 2015-01-21 23.33, Junio C Hamano wrote: Are you reporting differences between the state before these patches and after, or just the fact that with these patches the named tests break (which may or may not be broken before the patches)? The intention was to report what is now breaking. One

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-01-22 Thread Torsten Bögershausen
On 2015-01-22 21.07, brian m. carlson wrote: On Mon, Jan 19, 2015 at 06:21:24PM +0100, Torsten Bögershausen wrote: When parsing an URL, older Git versions did handle URLs like ssh://2001:db8::1/repo.git the same way as ssh://[2001:db8::1]/repo.git Commit 83b058 broke the parsing of IPV6

Re: [msysGit] Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT

2015-01-22 Thread Torsten Bögershausen
On 2015-01-22 23.07, Junio C Hamano wrote: Torsten Bögershausen tbo...@web.de writes: If I run that sequence manually: chmod 755 . touch x chmod a-w . rm x touch y x is gone, (but shoudn't according to POSIX) y is not created, access denied Good (or is that Sad?). It feels

Re: Git messes up 'ø' character

2015-01-20 Thread Torsten Bögershausen
On 2015-01-20 20.46, Noralf Trønnes wrote: could it be that your ø is not encoded as UTF-8, but in ISO-8859-15 (or so) $ git log -1 commit b2a4f6abdb097c4dc092b56995a2af8e42fbea79 Author: Noralf TrF8nnes no...@tronnes.org What does git config -l | grep Noralf | xxd say ? -- To unsubscribe

Re: [PATCH] move MAXDEPTH definition to the cache.h

2015-01-20 Thread Torsten Bögershausen
--- a/cache.h +++ b/cache.h @@ -1010,6 +1010,7 @@ extern int read_ref(const char *refname, unsigned char *sha1); * Caps and underscores refers to the special refs, such as HEAD, * FETCH_HEAD and friends, that all live outside of the refs/ directory. */ What happened to the comment

Re: [PATCH 00/24] nd/untracked-cache update

2015-01-20 Thread Torsten Bögershausen
On 2015-01-20 14.03, Nguyễn Thái Ngọc Duy wrote: Sorry for this really late update. This fixes bugs in extension writing code (10/24), support using the same cache from different hosts (23/24), and adds a new bug to point the user to untracked cache from 'git status -uno' (new patch 24/24)

[PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-01-19 Thread Torsten Bögershausen
] should be declared a feature. Signed-off-by: Torsten Bögershausen tbo...@web.de --- Unfortunatly my attemps to improve connect.c introduced some regressions: - git clone ssh://::1/repo did not work anymore (for some reason I assumed that literall IPV6 addresses always should have brackets

[PATCH 3/3] t5500: Show user name and host in diag-url

2015-01-19 Thread Torsten Bögershausen
Signed-off-by: Torsten Bögershausen tbo...@web.de --- connect.c | 35 +++ t/t5500-fetch-pack.sh | 51 +-- 2 files changed, 56 insertions(+), 30 deletions(-) diff --git a/connect.c b/connect.c index b608976

[PATCH 2/3] t5601: Add more test cases for IPV6

2015-01-19 Thread Torsten Bögershausen
to be used as a workaround. Test that user@::1 user@[::1] and [user@::1] all do the same. Signed-off-by: Torsten Bögershausen tbo...@web.de --- t/t5601-clone.sh | 57 +++- 1 file changed, 40 insertions(+), 17 deletions(-) diff --git a/t/t5601

Re: [PATCH v7 1/1] http: Add Accept-Language header if possible

2015-01-18 Thread Torsten Bögershausen
On 18.01.15 13:26, Yi EungJun wrote: From: Yi EungJun eungjun...@navercorp.com diff --git a/http.c b/http.c index 040f362..349b033 100644 --- a/http.c +++ b/http.c @@ -68,6 +68,8 @@ static struct curl_slist *no_pragma_header; static struct active_request_slot *active_queue_head;

Re: [msysGit] Re: [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT

2015-01-17 Thread Torsten Bögershausen
Hm, being one day offline and there are lots of ideas and new patches, I like that. I run these test under msys and cygwin on latest pu (a3dc223ff234481356c): ./t0001-init.sh ./t0004-unwritable.sh ./t0061-run-command.sh ./t0070-fundamental.sh ./t1004-read-tree-m-u-wf.sh ./t1300-repo-config.sh

Re: t5539 broken under Mac OS X

2015-01-14 Thread Torsten Bögershausen
On 2015-01-14 19.37, Junio C Hamano wrote: Torsten Bögershausen tbo...@web.de writes: t5539 doesn't seem to work as expected under Mac OX X 10.6 (10.9 is OK) I am not root. Are there any ideas how we can improve the situation, or how to debug ? As to how to debug, the first step

t5539 broken under Mac OS X

2015-01-14 Thread Torsten Bögershausen
t5539 doesn't seem to work as expected under Mac OX X 10.6 (10.9 is OK) I am not root. Are there any ideas how we can improve the situation, or how to debug ? t t ./t5539-fetch-http-shallow.sh ; echo $? 1..0 # SKIP Cannot run httpd tests as root 0 t t GIT_TEST_HTTPD=t

Re: [msysGit] Re: Probably a bug with ~ symbol in filenames on Windows 7 x64 in git 1.9.5

2015-01-08 Thread Torsten Bögershausen
On 01/08/2015 11:28 AM, Jeff King wrote: On Thu, Jan 08, 2015 at 11:06:18AM +0100, Johannes Schindelin wrote: ICON~714.PNG is a valid short name for a long name (such as 'icon.background.png') because it fits the shortening scheme (8.3 format, the base name ends in ~n). As this can clash with

Re: [msysGit] Re: Probably a bug with ~ symbol in filenames on Windows 7 x64 in git 1.9.5

2015-01-08 Thread Torsten Bögershausen
On 01/08/2015 04:58 PM, Johannes Schindelin wrote: Hi Torsten, On Thu, 8 Jan 2015, Torsten Bögershausen wrote: There is something more then just the tilde protection going on, [...] Indeed. What is going on is that you build Git yourself, from git.git, while Dmitry obviously used Git

Re: git 2.2.x: Unexpected, overstrict file permissions after git update-server-info

2015-01-05 Thread Torsten Bögershausen
On 2015-01-05 20.07, Paul Sokolovsky wrote: Hello, We recently upgraded to git 2.2.1 from 2.1.x and faced issue with accessing repositories over dump HTTP protocol. In our setting, repositories are managed by Gerrit, so owned by Gerrit daemon user, but we also offer anon access via smart

Re: Git's Perl scripts can fail if user is configured for perlbrew

2014-12-29 Thread Torsten Bögershausen
On 2014-12-28 23.36, Randy J. Ray wrote: I use git on MacOS via homebrew (http://brew.sh/), and a custom Perl installation built and managed via perlbrew (http://perlbrew.pl/). At some point, commands like git add -i broke. I say at some point, because I'm not a git power-user and I only

Re: [msysGit] Re: Announcing Git for Windows 1.9.5

2014-12-23 Thread Torsten Bögershausen
On 2014-12-23 10.48, Pat Tressel wrote: Bugfixes - Safeguards against bogus file names on NTFS (CVE-2014-9390). Apologies, but...is it possible to get back an old version? I installed this version, and it no longer recognizes non-English characters that appear

Re: [PATCH] is_hfs_dotgit: loosen over-eager match of \u{..47}

2014-12-23 Thread Torsten Bögershausen
On 2014-12-23 09.45, Jeff King wrote: Our is_hfs_dotgit function relies on the hackily-implemented next_hfs_char to give us the next character that an HFS+ filename comparison would look at. It's hacky because it doesn't implement the full case-folding table of HFS+; it gives us just enough

Re: [PATCH v2 3/5] update_unicode.sh: shorten uniset invocation path

2014-12-19 Thread Torsten Bögershausen
- ./uniset/uniset --32 cat:Me,Mn,Cf + U+1160..U+11FF - U+00AD | + uniset/uniset --32 cat:Me,Mn,Cf + U+1160..U+11FF - U+00AD | (Technically both do the same) I personally think that using ./ it is extra obvious that a command is not from the path somewhere. But that may

Re: bug patch: exit codes from internal commands are handled incorrectly

2014-12-18 Thread Torsten Bögershausen
On 18.12.14 03:15, Kenneth Lorber wrote: The situation is actually slightly more complex than I stated previously. From the docs: The exit value of this program is negative on error, But there’s no such thing as a negative error code under Unix, so (at best) that will be exit(255). No

Re: [PATCH v3] remote: add --fetch and --both options to set-url

2014-12-17 Thread Torsten Bögershausen
On 11/25/2014 12:48 PM, Peter Wu wrote: git remote set-url knew about the '--push' option to update just the pushurl, but it does not have a similar option for update fetch URL and leave whatever was in place for the push URL. This patch adds support for a '--fetch' option which implements that

Re: [PATCH 1/1] skip RFC1991 tests with gnupg 2.1.x

2014-12-11 Thread Torsten Bögershausen
On 11.12.14 10:30, Christian Hesse wrote: --- t/lib-gpg.sh | 6 ++ t/t7004-tag.sh | 14 +++--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh index cd2baef..05b07c6 100755 --- a/t/lib-gpg.sh +++ b/t/lib-gpg.sh @@ -22,6 +22,12

Re: [PATCH v3 23/23] untracked cache: guard and disable on system changes

2014-12-11 Thread Torsten Bögershausen
On 10.12.14 13:22, Duy Nguyen wrote: On Wed, Dec 10, 2014 at 12:08 PM, Torsten Bögershausen tbo...@web.de wrote: That opens another question: How flexible/extensible/self-describing is the format of the UNTR extension ? If we drop the OS name root dir check because it disallows network use

Re: [PATCH v3 23/23] untracked cache: guard and disable on system changes

2014-12-09 Thread Torsten Bögershausen
On 12/09/2014 11:53 PM, Duy Nguyen wrote: On Tue, Dec 9, 2014 at 5:04 PM, brian m. carlson sand...@crustytoothpaste.net wrote: On Mon, Dec 08, 2014 at 09:05:07PM +0700, Nguyễn Thái Ngọc Duy wrote: If the user enables untracked cache, then - move worktree to an unsupported filesystem - or

Re: [PATCH] git-svn: Support for git-svn propset

2014-12-07 Thread Torsten Bögershausen
On 2014-12-07 06.45, Torsten Bögershausen wrote: [] + +test_expect_success 'add multiple props' ' +git svn propset svn:keywords FreeBSD=%H foo +git svn propset fbsd:nokeywords yes foo +echo hello foo +git commit -m testing propset foo +git svn dcommit +svn_cmd

Re: Accept-language test fails on Mac OS

2014-12-07 Thread Torsten Bögershausen
On 07.12.14 07:54, Yi, EungJun wrote: I'm sorry for bothering you, but could you tell me the result of locale command without -a option? What I want to know is locale environment variables and its values, so I want to reproduce the test failures on my laptop. (Just for completeness:) locale

Re: Accept-language test fails on Mac OS

2014-12-07 Thread Torsten Bögershausen
On 07.12.14 08:18, Jeff King wrote: On Sat, Dec 06, 2014 at 10:04:06PM +0100, Torsten Bögershausen wrote: I get this: expecting success: check_language ko-KR, *;q=0.1 ko_KR.UTF-8 de_DE.UTF-8 ja_JP.UTF-8 en_US.UTF-8 check_language de-DE, *;q=0.1 de_DE.UTF-8

Re: How to repair a shallow clone (?)

2014-12-07 Thread Torsten Bögershausen
On 2014-12-07 12.44, Duy Nguyen wrote: Is this a known issue/problem ? No. Thanks everybody for the support. The machine was equipped with git version 1.7.10.4 in /usr/bin. I installed 2.1 or so under /usr/local/bin, (and even /root/bin) thinking that this would help, but it didn't.

Re: git push hung?

2014-12-07 Thread Torsten Bögershausen
On 2014-12-07 15.24, Jason Pyeron wrote: I am trying to push to our local intranet git (smart https behind apache), and it has been at this point for 10+ hours. jpyeron@black /projects/git/git $ GIT_TRACE=1 git push 09:08:45.662902 git.c:349 trace: built-in: git 'push'

Re: Accept-language test fails on Mac OS

2014-12-06 Thread Torsten Bögershausen
On 2014-12-06 00.01, Michael Blume wrote: On Fri, Dec 5, 2014 at 2:51 PM, Junio C Hamano gits...@pobox.com wrote: Michael Blume blume.m...@gmail.com writes: Test #25 'git client sends Accept-Language based on LANGUAGE, LC_ALL, LC_MESSAGES and LANG' in t5550 fails consistently on my mac, and

<    2   3   4   5   6   7   8   9   10   11   >