[PATCH][GSoC] branch.c:install_branch_config Simplified long chain of if statements

2014-03-10 Thread Vincenzo di Cicco
From: NaN enzodici...@gmail.com Hi there, I've made this patch in according to the rules to participate at GSoC. I've seen other patches about this issue very well constructed, so this is only another way to solve this microproject and to test how I can send a patch and discuss about it.

Re: [PATCH][GSoC] branch.c:install_branch_config Simplified long chain of if statements

2014-03-10 Thread Eric Sunshine
Thanks for the submission. Comments below to give you a feel for the Git review process... On Mon, Mar 10, 2014 at 6:04 PM, Vincenzo di Cicco enzodici...@gmail.com wrote: From: NaN enzodici...@gmail.com Drop this line unless it is intentionally different from your email From: header, which git

Re: [PATCH][GSoC] branch.c:install_branch_config Simplified long chain of if statements

2014-03-10 Thread Vincenzo di Cicco
Thank you very much for the answer! I've learned a lot in this few rows. If we take the time to trace through the code, we can see that remote_is_branch is indeed either 0 or 1, thus this expression is safe today, however, if the implementation of starts_with() ever changes so that it returns