Re: [PATCH] Build in gettext poison feature unconditionally

2012-08-21 Thread Junio C Hamano
Jonathan Nieder writes: > Nguyễn Thái Ngọc Duy wrote: > >> The runtime cost should be small. "gcc -O2" inlines _() and >> use_gettext_poison(). But even if it does not, performance should not >> be impacted as _() calls are usually not on critical path. If some of >> them are, we better fix there

Re: [PATCH] Build in gettext poison feature unconditionally

2012-08-20 Thread Jonathan Nieder
Nguyễn Thái Ngọc Duy wrote: > The runtime cost should be small. "gcc -O2" inlines _() and > use_gettext_poison(). But even if it does not, performance should not > be impacted as _() calls are usually not on critical path. If some of > them are, we better fix there as gettext() may or may not be c

[PATCH] Build in gettext poison feature unconditionally

2012-08-20 Thread Nguyễn Thái Ngọc Duy
Making gettext poison second citizen makes it easy to forget to run the test suite with it. This is step one to running test suite with gettext poison by default. The runtime cost should be small. "gcc -O2" inlines _() and use_gettext_poison(). But even if it does not, performance should not be im