Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-17 Thread Florian Achleitner
On Tuesday 17 July 2012 16:02:12 Jonathan Nieder wrote: > Hi, > > Florian Achleitner wrote: > > So we want the transport-helper to touch only private refs, i.e. some > > subdir of refs/, ok. > > On the other hand I thought we expect git-fetch to update the RHS of the > > passed refspec (or the def

Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-17 Thread Jonathan Nieder
Hi, Florian Achleitner wrote: > So we want the transport-helper to touch only private refs, i.e. some subdir > of refs/, ok. > On the other hand I thought we expect git-fetch to update the RHS of the > passed refspec (or the default one ). How? Now I am getting confused by terminology. By "th

Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-17 Thread Florian Achleitner
On Tuesday 17 July 2012 08:48:20 Jonathan Nieder wrote: > Florian Achleitner wrote: > > On Monday 16 July 2012 22:27:25 Jonathan Nieder wrote: > >> Hm, that still doesn't look right. The RHS of the refspec is supposed to > >> be a _private_ namespace for the remote helper, and refs/remotes/ is > >

Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-17 Thread Jonathan Nieder
Florian Achleitner wrote: > On Monday 16 July 2012 22:27:25 Jonathan Nieder wrote: >> Hm, that still doesn't look right. The RHS of the refspec is supposed to >> be a _private_ namespace for the remote helper, and refs/remotes/ is >> not private. [...] > remote-svn now uses get_fetch_map to retri

Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-17 Thread Florian Achleitner
On Monday 16 July 2012 22:27:25 Jonathan Nieder wrote: > Florian Achleitner wrote: > > When it does advertise refspec like: > > Debug: Remote helper: <- refspec > > refs/heads/master:refs/remotes/svnfile/master it all works. Unfortunatly > > I didn't understand that a day ago. > > Hm, that still d

Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-16 Thread Jonathan Nieder
Florian Achleitner wrote: > When it does advertise refspec like: > Debug: Remote helper: <- refspec refs/heads/master:refs/remotes/svnfile/master > it all works. Unfortunatly I didn't understand that a day ago. Hm, that still doesn't look right. The RHS of the refspec is supposed to be a _privat

Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-16 Thread Florian Achleitner
On Sunday 15 July 2012 19:30:25 Jonathan Nieder wrote: > Hi Florian, > > Florian Achleitner wrote: > > After importing new commits on top of refs/remotes/* the > > ref was overwritten with the local refs/heads/master, because the name > > of the remote reference to fetch, i.e. refs/heads/master, w

Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-15 Thread Junio C Hamano
Jonathan Nieder writes: > Hi Florian, > > Florian Achleitner wrote: > >> After importing new commits on top of refs/remotes/* the >> ref was overwritten with the local refs/heads/master, because the name >> of the remote reference to fetch, i.e. refs/heads/master, was used to >> retrieve old_sha1

Re: [PATCH] Fix overwritten remote ref on with fast-import.

2012-07-15 Thread Jonathan Nieder
Hi Florian, Florian Achleitner wrote: > After importing new commits on top of refs/remotes/* the > ref was overwritten with the local refs/heads/master, because the name > of the remote reference to fetch, i.e. refs/heads/master, was used to > retrieve old_sha1 for it's local counterpart. Therefo

[PATCH] Fix overwritten remote ref on with fast-import.

2012-07-15 Thread Florian Achleitner
After importing new commits on top of refs/remotes/* the ref was overwritten with the local refs/heads/master, because the name of the remote reference to fetch, i.e. refs/heads/master, was used to retrieve old_sha1 for it's local counterpart. Therefore, old_sha1 pointed to the local head which was