Re: [PATCH] Update hard-coded header dependencies

2014-08-21 Thread Jeff King
On Sun, Aug 10, 2014 at 03:48:24PM -0400, Jeff King wrote: > On Fri, Aug 08, 2014 at 02:58:26PM -0700, Jonathan Nieder wrote: > > > Maybe it's worth switching to plain > > > > LIB_H += $(wildcard *.h) > > > > ? People using ancient compilers that never change headers wouldn't > > be hurt,

Re: [PATCH] Update hard-coded header dependencies

2014-08-10 Thread Junio C Hamano
Junio C Hamano writes: > Jonathan Nieder writes: > >> ? People using ancient compilers that never change headers wouldn't >> be hurt, people using modern compilers that do change headers also >> wouldn't be hurt, and we could stop pretending to maintain an >> up-to-date list. > > I agree that i

Re: [PATCH] Update hard-coded header dependencies

2014-08-10 Thread Junio C Hamano
Jonathan Nieder writes: > The fall-back rules used when compilers don't support the -MMD switch > to generate makefile rules based on #includes have been out of date > since v1.7.12.1~22^2~8 (move git_version_string into version.c, > 2012-06-02). > > Checked with 'make CHECK_HEADER_DEPENDENCIES=y

Re: [PATCH] Update hard-coded header dependencies

2014-08-10 Thread Jeff King
On Fri, Aug 08, 2014 at 02:58:26PM -0700, Jonathan Nieder wrote: > Maybe it's worth switching to plain > > LIB_H += $(wildcard *.h) > > ? People using ancient compilers that never change headers wouldn't > be hurt, people using modern compilers that do change headers also > wouldn't be hu

[PATCH] Update hard-coded header dependencies

2014-08-08 Thread Jonathan Nieder
The fall-back rules used when compilers don't support the -MMD switch to generate makefile rules based on #includes have been out of date since v1.7.12.1~22^2~8 (move git_version_string into version.c, 2012-06-02). Checked with 'make CHECK_HEADER_DEPENDENCIES=yes'. Signed-off-by: Jonathan Nieder